[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...

2017-03-28 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [![Coverage Status](https://coveralls.io/builds/10821765/badge)](https://coveralls.io/builds/10821765) Coverage decreased (-0.08%) to 31.791% when pulling

[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...

2017-03-28 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 > So do you agree this is indeed an issue that needed to be solved? If yes, I will try doing that. Changing specific dependency to a neutral logging framework is good to have

[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...

2017-03-28 Thread Jaskey
Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 @lizhanhui So do you agree this is indeed an issue that needed to be solved? If yes, I will try doing that. But actually it is a little different from the clientLogger

[GitHub] incubator-rocketmq issue #79: [ROCKETMQ-144]Aggregate packaging specific fil...

2017-03-28 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/79 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...

2017-03-28 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [![Coverage Status](https://coveralls.io/builds/10807112/badge)](https://coveralls.io/builds/10807112) Coverage increased (+0.04%) to 31.662% when pulling

[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...

2017-03-28 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [![Coverage Status](https://coveralls.io/builds/10806993/badge)](https://coveralls.io/builds/10806993) Coverage increased (+0.03%) to 31.644% when pulling

[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...

2017-03-28 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [![Coverage Status](https://coveralls.io/builds/10806993/badge)](https://coveralls.io/builds/10806993) Coverage increased (+0.03%) to 31.644% when pulling

[GitHub] incubator-rocketmq-externals pull request #5: [ROCKETMQ-81] import rocketmq ...

2017-03-28 Thread hustfxj
GitHub user hustfxj opened a pull request: https://github.com/apache/incubator-rocketmq-externals/pull/5 [ROCKETMQ-81] import rocketmq plugin for spark streaming This plugin is for spark streaming based on pull mode. And you can see READ.ME for more details. You can merge this

[GitHub] incubator-rocketmq issue #79: [ROCKETMQ-144]Aggregate packaging specific fil...

2017-03-28 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/79 [![Coverage Status](https://coveralls.io/builds/10803343/badge)](https://coveralls.io/builds/10803343) Coverage increased (+1.0%) to 31.798% when pulling

[GitHub] incubator-rocketmq issue #79: [ROCKETMQ-144]Aggregate packaging specific fil...

2017-03-28 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/79 [![Coverage Status](https://coveralls.io/builds/10803343/badge)](https://coveralls.io/builds/10803343) Coverage increased (+1.0%) to 31.798% when pulling

[GitHub] incubator-rocketmq issue #79: [ROCKETMQ-144]Aggregate packaging specific fil...

2017-03-28 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/79 [![Coverage Status](https://coveralls.io/builds/10803343/badge)](https://coveralls.io/builds/10803343) Coverage increased (+1.0%) to 31.798% when pulling

[GitHub] incubator-rocketmq pull request #79: [ROCKETMQ-144]Aggregate packaging speci...

2017-03-28 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108344089 --- Diff: distribution/pom.xml --- @@ -0,0 +1,125 @@

[GitHub] incubator-rocketmq issue #75: [ROCKETMQ-138]Add AuthenticationException clas...

2017-03-28 Thread Jaskey
Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/75 @vongosling Now nothing special has been done unless remove the hard corded aliyun code snippet. I will close this pr after merge. --- If your project is set up for

[GitHub] incubator-rocketmq issue #75: [ROCKETMQ-138]Add AuthenticationException clas...

2017-03-28 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/75 @Jaskey Thanks for your elaborative consideration about exception. Let it go as you have changed. we will merge this PR. --- If your project is set up for it, you can reply to this