[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

2017-04-16 Thread shroman
Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/87 @dongeforever Sorry, I don't think this modification is needed. A user will modify this file anyway in order to match his/her system requirements. Also, there are even more flags,

[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors

2017-04-16 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111704133 --- Diff: common/src/main/java/org/apache/rocketmq/common/protocol/header/GetEarliestMsgStoreTimeResponseHeader.java --- @@ -16,15 +16,15 @@

[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors

2017-04-16 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111704125 --- Diff: common/src/main/java/org/apache/rocketmq/common/protocol/header/GetEarliestMsgStoreTimeRequestHeader.java --- @@ -16,15 +16,15 @@

Semantics of timeout in asynchronous/one-way send methods

2017-04-16 Thread Zhanhui Li
Hi, RocketMQ provides three message sending models: synchronous, asynchronous and one-way. For asynchronous and one-way sending methods, internal implementation employs semaphore to ensure client memory usage is properly bounded. The following code snippet reflects this idea:

[GitHub] incubator-rocketmq issue #90: [ROCKETMQ-172]log improvement for rocketmq cli...

2017-04-16 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/90 [![Coverage Status](https://coveralls.io/builds/11106460/badge)](https://coveralls.io/builds/11106460) Coverage increased (+2.7%) to 34.586% when pulling

[GitHub] incubator-rocketmq issue #90: [ROCKETMQ-172]log improvement for rocketmq cli...

2017-04-16 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/90 [![Coverage Status](https://coveralls.io/builds/11106460/badge)](https://coveralls.io/builds/11106460) Coverage increased (+2.7%) to 34.586% when pulling

[GitHub] incubator-rocketmq issue #90: [ROCKETMQ-172]log improvement for rocketmq cli...

2017-04-16 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/90 [![Coverage Status](https://coveralls.io/builds/11106460/badge)](https://coveralls.io/builds/11106460) Coverage increased (+2.7%) to 34.586% when pulling

[GitHub] incubator-rocketmq issue #93: [ROCKETMQ-178] Fix -p -m options

2017-04-16 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 [![Coverage Status](https://coveralls.io/builds/11106432/badge)](https://coveralls.io/builds/11106432) Coverage decreased (-0.03%) to 34.591% when pulling

[GitHub] incubator-rocketmq issue #93: [ROCKETMQ-178] Fix -p -m options

2017-04-16 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 [![Coverage Status](https://coveralls.io/builds/11106432/badge)](https://coveralls.io/builds/11106432) Coverage decreased (-0.03%) to 34.591% when pulling

[GitHub] incubator-rocketmq pull request #90: [ROCKETMQ-172]log improvement for rocke...

2017-04-16 Thread Jaskey
Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/90#discussion_r111701589 --- Diff: remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java --- @@ -321,6 +321,7 @@ public void

[GitHub] incubator-rocketmq pull request #90: [ROCKETMQ-172]log improvement for rocke...

2017-04-16 Thread Jaskey
Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/90#discussion_r111701497 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java --- @@ -577,12 +577,12 @@ public void

[GitHub] incubator-rocketmq issue #93: [ROCKETMQ-178] Fix -p -m options

2017-04-16 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 > No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Check the details on how to adjust your build

[GitHub] incubator-rocketmq pull request #93: [ROCKETMQ-178] Fix -p -m options

2017-04-16 Thread lizhanhui
Github user lizhanhui closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-rocketmq pull request #93: [ROCKETMQ-178] Fix -p -m options

2017-04-16 Thread lizhanhui
GitHub user lizhanhui reopened a pull request: https://github.com/apache/incubator-rocketmq/pull/93 [ROCKETMQ-178] Fix -p -m options You can merge this pull request into a Git repository by running: $ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-178

[GitHub] incubator-rocketmq pull request #90: [ROCKETMQ-172]log improvement for rocke...

2017-04-16 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/90#discussion_r111700022 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java --- @@ -577,12 +577,12 @@ public void

[GitHub] incubator-rocketmq pull request #90: [ROCKETMQ-172]log improvement for rocke...

2017-04-16 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/90#discussion_r111699977 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java --- @@ -577,12 +577,12 @@ public void

[GitHub] incubator-rocketmq-externals issue #5: [ROCKETMQ-81] import rocketmq plugin ...

2017-04-16 Thread zhouxinyu
Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/5 @vesense How much the merge progress has been made now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-rocketmq issue #93: [ROCKETMQ-178] Fix -p -m options

2017-04-16 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 [![Coverage Status](https://coveralls.io/builds/11106131/badge)](https://coveralls.io/builds/11106131) Coverage decreased (-0.4%) to 34.204% when pulling

[GitHub] incubator-rocketmq pull request #93: [ROCKETMQ-178] Fix -p -m options

2017-04-16 Thread lizhanhui
GitHub user lizhanhui opened a pull request: https://github.com/apache/incubator-rocketmq/pull/93 [ROCKETMQ-178] Fix -p -m options You can merge this pull request into a Git repository by running: $ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-178

[GitHub] incubator-rocketmq-externals pull request #10: RocketMQ-Go-Client-Init

2017-04-16 Thread StyleTang
GitHub user StyleTang opened a pull request: https://github.com/apache/incubator-rocketmq-externals/pull/10 RocketMQ-Go-Client-Init Add rocketmq go client's design, roadmap and package. ![alternative