[GitHub] incubator-rocketmq pull request #105: [ROCKETMQ-200]-Cluster name is always ...

Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/105#discussion_r118622000 --- Diff: namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java --- @@ -125,11 +125,7 @@ public

[GitHub] incubator-rocketmq pull request #105: [ROCKETMQ-200]-Cluster name is always ...

Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/105#discussion_r118621860 --- Diff: common/src/main/java/org/apache/rocketmq/common/protocol/route/BrokerData.java --- @@ -15,9 +15,7 @@ * limitations under the

Errored: apache/incubator-rocketmq#545 (ROCKETMQ-206 - ceeef8e)

Build Update for apache/incubator-rocketmq - Build: #545 Status: Errored Duration: 1 minute and 41 seconds Commit: ceeef8e (ROCKETMQ-206) Author: yukon Message: [ROCKETMQ-206] Fix bug when non-1byte character exists in JSON config files. View the changeset:

[GitHub] incubator-rocketmq issue #57: [ROCKETMQ-91] Reduce lock granularity for putM...

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/57 [](https://coveralls.io/builds/11685815) Coverage increased (+0.2%) to 38.626% when pulling

[GitHub] incubator-rocketmq issue #34: [ROCKETMQ-39] avoid duplicated codes.

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/34 @wu-sheng this PR has been merged. you may close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-rocketmq issue #3: [ROCKETMQ-6] Use logger for exceptions instead ...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/3 @shroman please resolve the conflicts and merge this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-rocketmq issue #92: [ROCKETMQ-175] Consumer may miss messages beca...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/92 @zhouxinyu @vongosling --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-rocketmq issue #95: [ROCKETMQ-184]-It takes too long(3-33 seconds)...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/95 LGTM @zhouxinyu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-rocketmq issue #98: [ROCKETMQ-188]RemotingExecption is not consist...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/98 LGTM @zhouxinyu @vongosling --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-rocketmq issue #99: Correct comment information

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/99 @liumian97 could you please follow the apache way of PR: create issue and rename pull request --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-rocketmq issue #104: Remove spaces before and after the properties

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/104 IMO. if using trim, it is better to trim in all related places --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-rocketmq pull request #104: Remove spaces before and after the pro...

Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/104#discussion_r118433272 --- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java --- @@ -279,7 +279,7 @@ public static String properties2String(final

[GitHub] incubator-rocketmq issue #104: Remove spaces before and after the properties

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/104 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] incubator-rocketmq issue #105: [ROCKETMQ-200]-Cluster name is always missing...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/105 LGTM @zhouxinyu @vongosling --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-rocketmq-externals pull request #24: RocketMQ-MySQL 1.0-snapshot

GitHub user zhaoqun911 opened a pull request: https://github.com/apache/incubator-rocketmq-externals/pull/24 RocketMQ-MySQL 1.0-snapshot You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhaoqun911/incubator-rocketmq-externals

[GitHub] incubator-rocketmq pull request #87: [ROCKETMQ-161] Update runbroker.sh and ...

Github user dongeforever closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/87 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-rocketmq issue #40: [ROCKETMQ-40]Ack mode support for consume conc...

Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/40 It seems good. And maybe the name(suffixed with V2) could be polished. And maybe different ack mode should support orderly consuming too. --- If your project is set up for it,