[GitHub] incubator-rocketmq issue #111: [ROCKETMQ-28] Add TLS support to provide end-...

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/111 [![Coverage Status](https://coveralls.io/builds/11880510/badge)](https://coveralls.io/builds/11880510) Coverage increased (+0.1%) to 38.566% when pulling

[GitHub] incubator-rocketmq-site issue #16: [ROCKETMQ-221] Website beta version finis...

2017-06-07 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/16 This pull request has been merged and please close it at your convenient time. Thanks for your efforts and contribution. --- If your project is set up for it, you can reply to

[GitHub] incubator-rocketmq issue #117: [ROCKETMQ-215]-Use java 7 syntax to refator c...

2017-06-07 Thread Jaskey
Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/117 @dongeforever it looks no changes have been made to the modules which rocketmq-client depends on. But what I am concerned is that should rocketmq-tools needs to be compatable

[GitHub] incubator-rocketmq-site issue #16: [ROCKETMQ-221] Website beta version finis...

2017-06-07 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/16 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] incubator-rocketmq issue #112: [ROCKETMQ-219] Add batch example

2017-06-07 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/112 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-rocketmq issue #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-rocketmq-site issue #15: [ROCKETMQ-217] Polish scheduled message e...

2017-06-07 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/15 This PR contains contents simple enough, IMO, we can merge it directly as the original content is pretty misleading. --- If your project is set up for it, you can reply to this

[GitHub] incubator-rocketmq-site issue #16: [ROCKETMQ-221] Website beta version finis...

2017-06-07 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/16 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-rocketmq issue #111: [ROCKETMQ-28] Add TLS support to provide end-...

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/111 [![Coverage Status](https://coveralls.io/builds/11866450/badge)](https://coveralls.io/builds/11866450) Coverage decreased (-0.2%) to 38.44% when pulling

[GitHub] incubator-rocketmq issue #111: [ROCKETMQ-28] Add TLS support to provide end-...

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/111 [![Coverage Status](https://coveralls.io/builds/11866450/badge)](https://coveralls.io/builds/11866450) Coverage decreased (-0.2%) to 38.44% when pulling

[GitHub] incubator-rocketmq-site issue #15: [ROCKETMQ-217] Polish scheduled message e...

2017-06-07 Thread zhouxinyu
Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/15 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] incubator-rocketmq pull request #117: [ROCKETMQ-215]-Use java 7 syntax to re...

2017-06-07 Thread lindzh
Github user lindzh commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/117#discussion_r120603647 --- Diff: logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java --- @@ -39,7 +39,7 @@ public

[GitHub] incubator-rocketmq-site issue #15: [ROCKETMQ-217] Polish scheduled message e...

2017-06-07 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/15 @dongeforever @zhouxinyu Any idea? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-rocketmq-site issue #16: [ROCKETMQ-221] Website beta version finis...

2017-06-07 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/16 Could you resolve the conflict firstly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-rocketmq-site issue #15: [ROCKETMQ-217] Polish scheduled message e...

2017-06-07 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/15 LGTM, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-rocketmq-site pull request #16: [ROCKETMQ-221] Website beta versio...

2017-06-07 Thread zhoudiqiu
GitHub user zhoudiqiu opened a pull request: https://github.com/apache/incubator-rocketmq-site/pull/16 [ROCKETMQ-221] Website beta version finished https://issues.apache.org/jira/browse/ROCKETMQ-221 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-rocketmq issue #117: [ROCKETMQ-215]-Use java 7 syntax to refator c...

2017-06-07 Thread dongeforever
Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/117 the client module and its dependencies should be compatible with 1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-rocketmq issue #117: [ROCKETMQ-215]-Use java 7 syntax to refator c...

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/117 [![Coverage Status](https://coveralls.io/builds/11864245/badge)](https://coveralls.io/builds/11864245) Coverage increased (+0.5%) to 39.145% when pulling

[GitHub] incubator-rocketmq issue #117: [ROCKETMQ-215]-Use java 7 syntax to refator c...

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/117 [![Coverage Status](https://coveralls.io/builds/11864245/badge)](https://coveralls.io/builds/11864245) Coverage increased (+0.5%) to 39.145% when pulling

[GitHub] incubator-rocketmq issue #117: [ROCKETMQ-215]-Use java 7 syntax to refator c...

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/117 [![Coverage Status](https://coveralls.io/builds/11864245/badge)](https://coveralls.io/builds/11864245) Coverage increased (+0.5%) to 39.145% when pulling

[GitHub] incubator-rocketmq pull request #117: [ROCKETMQ-215]-Use java 7 syntax to re...

2017-06-07 Thread Jaskey
Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/117#discussion_r120577910 --- Diff: logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java --- @@ -39,7 +39,7 @@ public

[GitHub] incubator-rocketmq issue #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 [![Coverage Status](https://coveralls.io/builds/11863968/badge)](https://coveralls.io/builds/11863968) Coverage increased (+0.03%) to 38.707% when pulling

[GitHub] incubator-rocketmq pull request #117: remove

2017-06-07 Thread dzyangxi
GitHub user dzyangxi opened a pull request: https://github.com/apache/incubator-rocketmq/pull/117 remove JIRA:https://issues.apache.org/jira/browse/ROCKETMQ-215?jql=project%20%3D%20ROCKETMQ You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-rocketmq pull request #116: [Rocketmq 215]Use java 7 syntax to ref...

2017-06-07 Thread dzyangxi
Github user dzyangxi closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-rocketmq issue #116: [Rocketmq 215]Use java 7 syntax to refator co...

2017-06-07 Thread Jaskey
Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/116 Hi , welcome to contribute! Please relate the jira issue and also please submit the pr to branch develop. --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-rocketmq pull request #116: [Rocketmq 215]Use java 7 syntax to ref...

2017-06-07 Thread dzyangxi
GitHub user dzyangxi opened a pull request: https://github.com/apache/incubator-rocketmq/pull/116 [Rocketmq 215]Use java 7 syntax to refator code base You can merge this pull request into a Git repository by running: $ git pull https://github.com/dzyangxi/incubator-rocketmq

[GitHub] incubator-rocketmq issue #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 [![Coverage Status](https://coveralls.io/builds/11863183/badge)](https://coveralls.io/builds/11863183) Coverage decreased (-0.07%) to 38.61% when pulling

[GitHub] incubator-rocketmq issue #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 [![Coverage Status](https://coveralls.io/builds/11863183/badge)](https://coveralls.io/builds/11863183) Coverage decreased (-0.07%) to 38.61% when pulling

[GitHub] incubator-rocketmq pull request #111: [ROCKETMQ-28] Add TLS support to provi...

2017-06-07 Thread Jaskey
Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/111#discussion_r120285629 --- Diff: remoting/src/main/java/org/apache/rocketmq/remoting/netty/SslHelper.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache

[GitHub] incubator-rocketmq pull request #111: [ROCKETMQ-28] Add TLS support to provi...

2017-06-07 Thread Jaskey
Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/111#discussion_r120276124 --- Diff: remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java --- @@ -128,6 +131,19 @@ public Thread

[GitHub] incubator-rocketmq issue #111: [ROCKETMQ-28] Add TLS support to provide end-...

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/111 [![Coverage Status](https://coveralls.io/builds/11863024/badge)](https://coveralls.io/builds/11863024) Coverage increased (+0.3%) to 38.92% when pulling

[GitHub] incubator-rocketmq issue #114: [ROCKETMQ-220]Add IT test for Filter By SQL 9...

2017-06-07 Thread zhouxinyu
Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/114 +1, LGTM~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-rocketmq issue #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 [![Coverage Status](https://coveralls.io/builds/11863006/badge)](https://coveralls.io/builds/11863006) Coverage increased (+0.5%) to 39.208% when pulling

[GitHub] incubator-rocketmq issue #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 [![Coverage Status](https://coveralls.io/builds/11863006/badge)](https://coveralls.io/builds/11863006) Coverage increased (+0.5%) to 39.208% when pulling

[GitHub] incubator-rocketmq issue #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 [![Coverage Status](https://coveralls.io/builds/11863006/badge)](https://coveralls.io/builds/11863006) Coverage increased (+0.5%) to 39.208% when pulling

[GitHub] incubator-rocketmq pull request #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/113#discussion_r120558511 --- Diff: README.md --- @@ -30,12 +30,11 @@ It offers a variety of features as follows: ## Apache RocketMQ Community *

[GitHub] incubator-rocketmq issue #112: [ROCKETMQ-219] Add batch example

2017-06-07 Thread zhouxinyu
Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/112 +1, LGTM~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-rocketmq pull request #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/113#discussion_r120557452 --- Diff: README.md --- @@ -3,18 +3,18 @@ [![GitHub

[GitHub] incubator-rocketmq issue #114: [ROCKETMQ-220]Add IT test for Filter By SQL 9...

2017-06-07 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/114 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-rocketmq pull request #114: [ROCKETMQ-220]Add IT test for Filter B...

2017-06-07 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/114#discussion_r120556852 --- Diff: test/src/main/java/org/apache/rocketmq/test/listener/AbstractListener.java --- @@ -95,6 +95,28 @@ public void stopRecv() {

[GitHub] incubator-rocketmq issue #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 [![Coverage Status](https://coveralls.io/builds/11862791/badge)](https://coveralls.io/builds/11862791) Coverage decreased (-0.3%) to 38.412% when pulling

[GitHub] incubator-rocketmq issue #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 [![Coverage Status](https://coveralls.io/builds/11862791/badge)](https://coveralls.io/builds/11862791) Coverage decreased (-0.3%) to 38.412% when pulling

[GitHub] incubator-rocketmq issue #115: [Rocketmq 204]-when all brokers is offline, c...

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/115 [![Coverage Status](https://coveralls.io/builds/11862708/badge)](https://coveralls.io/builds/11862708) Coverage increased (+0.3%) to 38.894% when pulling

[GitHub] incubator-rocketmq issue #112: [ROCKETMQ-219] Add batch example

2017-06-07 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/112 Overall +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-rocketmq issue #115: [Rocketmq 204]-when all brokers is offline, c...

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/115 [![Coverage Status](https://coveralls.io/builds/11862708/badge)](https://coveralls.io/builds/11862708) Coverage increased (+0.3%) to 38.894% when pulling

[GitHub] incubator-rocketmq pull request #112: [ROCKETMQ-219] Add batch example

2017-06-07 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/112#discussion_r120554000 --- Diff: example/src/main/java/org/apache/rocketmq/example/batch/SplitBatchProducer.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to

[GitHub] incubator-rocketmq issue #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 [![Coverage Status](https://coveralls.io/builds/11862588/badge)](https://coveralls.io/builds/11862588) Coverage increased (+0.07%) to 38.748% when pulling

[GitHub] incubator-rocketmq pull request #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread zhouxinyu
Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/113#discussion_r120553463 --- Diff: README.md --- @@ -3,18 +3,18 @@ [![GitHub

[GitHub] incubator-rocketmq pull request #112: [ROCKETMQ-219] Add batch example

2017-06-07 Thread Jaskey
Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/112#discussion_r120535326 --- Diff: example/src/main/java/org/apache/rocketmq/example/batch/SplitBatchProducer.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the

[GitHub] incubator-rocketmq issue #115: [Rocketmq 204]-when all brokers is offline, c...

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/115 [![Coverage Status](https://coveralls.io/builds/11862612/badge)](https://coveralls.io/builds/11862612) Coverage increased (+0.08%) to 38.692% when pulling

[GitHub] incubator-rocketmq issue #115: [Rocketmq 204]-when all brokers is offline, c...

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/115 [![Coverage Status](https://coveralls.io/builds/11862612/badge)](https://coveralls.io/builds/11862612) Coverage increased (+0.08%) to 38.692% when pulling

[GitHub] incubator-rocketmq issue #112: [ROCKETMQ-219] Add batch example

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/112 [![Coverage Status](https://coveralls.io/builds/11862558/badge)](https://coveralls.io/builds/11862558) Coverage decreased (-0.05%) to 38.628% when pulling

[GitHub] incubator-rocketmq issue #114: [ROCKETMQ-220]Add IT test for Filter By SQL 9...

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/114 [![Coverage Status](https://coveralls.io/builds/11862485/badge)](https://coveralls.io/builds/11862485) Coverage decreased (-0.05%) to 38.625% when pulling

[GitHub] incubator-rocketmq issue #114: [ROCKETMQ-220]Add IT test for Filter By SQL 9...

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/114 [![Coverage Status](https://coveralls.io/builds/11862485/badge)](https://coveralls.io/builds/11862485) Coverage decreased (-0.05%) to 38.625% when pulling

[GitHub] incubator-rocketmq issue #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 [![Coverage Status](https://coveralls.io/builds/11862406/badge)](https://coveralls.io/builds/11862406) Coverage increased (+0.004%) to 38.681% when pulling

[GitHub] incubator-rocketmq issue #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 [![Coverage Status](https://coveralls.io/builds/11862406/badge)](https://coveralls.io/builds/11862406) Coverage increased (+0.004%) to 38.681% when pulling

[GitHub] incubator-rocketmq pull request #115: [Rocketmq 204]-when all brokers is off...

2017-06-07 Thread Jaskey
GitHub user Jaskey opened a pull request: https://github.com/apache/incubator-rocketmq/pull/115 [Rocketmq 204]-when all brokers is offline, client still attempts to send heartbeat JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-204?jql=project%20%3D%20ROCKETMQ You can

[GitHub] incubator-rocketmq pull request #114: [ROCKETMQ-220]Add IT test for Filter B...

2017-06-07 Thread dongeforever
GitHub user dongeforever opened a pull request: https://github.com/apache/incubator-rocketmq/pull/114 [ROCKETMQ-220]Add IT test for Filter By SQL 92 https://issues.apache.org/jira/browse/ROCKETMQ-220 @lizhanhui @zhouxinyu You can merge this pull request into a Git

[GitHub] incubator-rocketmq pull request #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread zhoudiqiu
Github user zhoudiqiu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/113#discussion_r120545980 --- Diff: README.md --- @@ -30,12 +30,11 @@ It offers a variety of features as follows: ## Apache RocketMQ Community *

[GitHub] incubator-rocketmq pull request #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread Jaskey
Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/113#discussion_r120535519 --- Diff: README.md --- @@ -30,12 +30,11 @@ It offers a variety of features as follows: ## Apache RocketMQ Community * [RocketMQ

[GitHub] incubator-rocketmq pull request #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread Jaskey
Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/113#discussion_r120535658 --- Diff: README.md --- @@ -3,18 +3,18 @@ [![GitHub

[GitHub] incubator-rocketmq pull request #113: [ROCKETMQ-218] README.md update

2017-06-07 Thread Jaskey
Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/113#discussion_r120535540 --- Diff: README.md --- @@ -3,18 +3,18 @@ [![GitHub