[GitHub] incubator-rocketmq pull request #133: [ROCKETMQ-249] Do not attempt to clear...

2017-09-21 Thread dongeforever
Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/133#discussion_r140402297 --- Diff: store/src/test/java/org/apache/rocketmq/store/CleanCommitLogServiceTest.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to

[GitHub] incubator-rocketmq pull request #138: [ROCKETMQ-138]add implement SelectMess...

2017-09-21 Thread dongeforever
Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/138#discussion_r140401564 --- Diff: client/src/main/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByConsistentHash.java --- @@ -0,0 +1,132 @@

[GitHub] incubator-rocketmq issue #154: [Rocketmq-285] file test error when make link

2017-09-21 Thread zwillim
Github user zwillim commented on the issue: https://github.com/apache/incubator-rocketmq/pull/154 changed as needed. ---

[GitHub] incubator-rocketmq issue #168: [ROCKETMQ-291]Fix System.out.printf throws Un...

2017-09-21 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/168 [![Coverage Status](https://coveralls.io/builds/13367180/badge)](https://coveralls.io/builds/13367180) Coverage decreased (-0.2%) to 38.646% when pulling

[GitHub] incubator-rocketmq pull request #169: [ROCKETMQ-292]Delete system.exit in MQ...

2017-09-21 Thread lindzh
GitHub user lindzh opened a pull request: https://github.com/apache/incubator-rocketmq/pull/169 [ROCKETMQ-292]Delete system.exit in MQAdminStartup ### What is the purpose of the change When using MQAdminStartup in a java process,some args problem may cause MQAdminStartup to

[GitHub] incubator-rocketmq pull request #168: Fix System.out.printf throws UnknownFo...

2017-09-21 Thread lindzh
GitHub user lindzh opened a pull request: https://github.com/apache/incubator-rocketmq/pull/168 Fix System.out.printf throws UnknownFormatConversionException ### What is the purpose of the change When using mqadmin command printmsg to print retry topic msgs,it throw an