[GitHub] incubator-rocketmq issue #100: BugFix: ROCKETMQ-191

2017-05-06 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 That's a good polish, but I must point out the 2 point for this optimization. 1. please comply with PR best practice for title as you have corrected before. 2. you can consider the

[GitHub] incubator-rocketmq issue #100: BugFix: ROCKETMQ-191

2017-04-28 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 [![Coverage Status](https://coveralls.io/builds/11287015/badge)](https://coveralls.io/builds/11287015) Coverage decreased (-0.09%) to 37.876% when pulling

[GitHub] incubator-rocketmq issue #100: BugFix: ROCKETMQ-191

2017-04-28 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 [![Coverage Status](https://coveralls.io/builds/11287015/badge)](https://coveralls.io/builds/11287015) Coverage decreased (-0.09%) to 37.876% when pulling

[GitHub] incubator-rocketmq issue #100: BugFix: ROCKETMQ-191

2017-04-27 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 [![Coverage Status](https://coveralls.io/builds/11283185/badge)](https://coveralls.io/builds/11283185) Coverage decreased (-0.06%) to 37.906% when pulling

[GitHub] incubator-rocketmq issue #100: BugFix: ROCKETMQ-191

2017-04-27 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 [![Coverage Status](https://coveralls.io/builds/11283185/badge)](https://coveralls.io/builds/11283185) Coverage decreased (-0.06%) to 37.906% when pulling

[GitHub] incubator-rocketmq issue #100: BugFix: ROCKETMQ-191

2017-04-27 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 [![Coverage Status](https://coveralls.io/builds/11283185/badge)](https://coveralls.io/builds/11283185) Coverage decreased (-0.06%) to 37.906% when pulling