Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
[](https://coveralls.io/builds/12633575)
Coverage increased (+0.02%) to 38.744% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
[](https://coveralls.io/builds/12633575)
Coverage increased (+0.02%) to 38.744% when pulling
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
OK. IT tests have been added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
[](https://coveralls.io/builds/12590728)
Coverage increased (+0.5%) to 39.174% when pulling
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
@lindzh It seems lack IT tests for TLS. IMO, it needs two IT Test at
least. one for old client which dose not support TLS, one for new.
---
If your project is set up for it, you
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
[](https://coveralls.io/builds/12231167)
Coverage increased (+0.3%) to 38.725% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
[](https://coveralls.io/builds/12165746)
Coverage increased (+0.02%) to 38.461% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
[](https://coveralls.io/builds/12165746)
Coverage increased (+0.02%) to 38.461% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
[](https://:/builds/12024484)
Coverage increased (+0.7%) to 39.117% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
[](https://:/builds/12024484)
Coverage increased (+0.7%) to 39.117% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
[](https://:/builds/12024484)
Coverage increased (+0.7%) to 39.117% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
[](https://:/builds/11982999)
Coverage increased (+0.3%) to 38.702% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/118
[](https://:/builds/11982999)
Coverage increased (+0.3%) to 38.702% when pulling
14 matches
Mail list logo
