Github user Ritabrata-TW commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@vongosling We do not need a messaging queue in our Project as of yet. Will
be advocating for RocketMQ if the scenario arises.
---
If your project is set up for it, you can reply
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@Ritabrata-TW Thanks for your attention for rocketmq community, whats' your
scenario when using apache rocketmq in your company :-)
---
If your project is set up for it, you can
Github user Ritabrata-TW commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@zhouxinyu Thanks a lot. Will look forward to working with you again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@Ritabrata-TW this PR has been merged into `develop` branch and will be
released in next version, you can close it now safely.
---
If your project is set up for it, you can reply to
Github user Ritabrata-TW commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@zhouxinyu Thanks. I will keep the suggested things in mind next time.
Please let me know if you need anything to close the PR.
I would also like to get more involved with
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@Ritabrata-TW I found so many code format in your PR, could you import our
code style file as instruction,
http://rocketmq.incubator.apache.org/docs/code-guidelines/
---
If your
Github user Ritabrata-TW commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@vongosling @zhouxinyu Anything else that I need to do on this? Otherwise,
can you please have a look and merge it?
---
If your project is set up for it, you can reply to this
Github user Ritabrata-TW commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@zhouxinyu My pleasure. I have set the merge target to develop. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
Is there something wrong with your code style ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@Ritabrata-TW thanks, I will take a close look it later :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
[](https://coveralls.io/builds/12692862)
Coverage decreased (-0.3%) to 38.78% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
[](https://coveralls.io/builds/12692862)
Coverage decreased (-0.3%) to 38.78% when pulling
12 matches
Mail list logo
