Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
@shroman It seems that last cleaning, for too long-time no-resolved prs,
included this one.
If you feel it is necessary to reopen this PR, please feel free to do it.
you may
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
And why is it closed?
---
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
@shroman could you please resolve the conflicts?
IMO, the return value of flush() and commit(), means whether there is data
left to be flushed or committed, that is OK.
if
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
Ok, guys, I set the fix version of the JIRA issue to 4.1.0 then ð
@vongosling what are your recommendations on how to treat the storage
module? Should I create a JIRA issue if I
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
We must keep cautious about storage polish, although some minor rename.
IMO, Could we optimize here in the 4.1.0 or more later version :-)
---
If your project is set up for it, you
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
@zhouxinyu I made changes according to your comments, and added more tests.
In {{CommitLog.FlushRealTimeService#run()}}, we will try to flush as long
as the data is available or
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
Hi, the github says "This branch has no conflicts with the base branch"
I think conflicts are resolved.
Reviewing it by several committers is already being cautious, isn't it?
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
Hi, shroman
Could you please resolve conflicts in this pr?
And we will remain cautious about the changes of rocketmq-store module, so
this pr may be won't merge
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
@vongosling Does `RETRY_TIMES_OVER` here means retries on failures, or the
number of times to flush on success? I think the former, but need to be sure I
understand the intentions of the
