Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
LGTM~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
this PR has been merged into develop branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
[](https://coveralls.io/builds/10543227)
Coverage increased (+0.9%) to 31.863% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
[](https://coveralls.io/builds/10543227)
Coverage increased (+0.9%) to 31.863% when pulling
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
@dongeforever we can continue to polish this PR, IMO. if you have any
problem. please let me know. BTW, can you post your performance test result for
us
---
If your project is set up
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
Yep agreed @lizhanhui . I will make some comment as much detail as possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
@Jaskey Sorry. You are right. And it is worth a new PR, maybe we can add
batch id along with a new optimized consumeOrderlyService.
---
If your project is set up for it, you can
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
@Jaskey Now there is no batch id, but the messages in one batch are sent to
the same queue, and they can only be sent all successfully or all
unsuccessfully.
You could check the
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
@dongeforever
I have the same wishes for batch send too, but what drives me is that user
may propably need a batch id for one batch of message, and these message should
be
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
[](https://coveralls.io/builds/10167156)
Coverage increased (+0.5%) to 32.046% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
[](https://coveralls.io/builds/10167156)
Coverage increased (+0.5%) to 32.046% when pulling
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
Sounds good to check for the protocol version in the request header, and
reject with an error when not matched.
Probably, `RemotingCommand.REMOTING_VERSION_KEY` will work, but I would
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
[](https://coveralls.io/builds/10029487)
Coverage increased (+0.4%) to 31.909% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
[](https://coveralls.io/builds/10029487)
Coverage increased (+0.4%) to 31.909% when pulling
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
Cool, Thanks @dongeforever providing this feature. We will have a look at
this implementation. please hold your horses :-)
---
If your project is set up for it, you can reply to this
15 matches
Mail list logo
