GitHub user lizhanhui opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/100

    BugFix: ROCKETMQ-191

    As we are setting socket options(sndbuf/recvbuf size) for the future 
SocketChannel, we need to use childOption for ServerBootstrap class.
    
    Semantics differences can be found [Netty 
docs](http://netty.io/wiki/user-guide-for-4.x.html)
    
    Actually, this is an easy-to-get-confused issue, [Spark had a similar bug 
too](https://issues.apache.org/jira/browse/SPARK-3502)
    
    [Vertx has similar settings that we can refer 
to](https://github.com/eclipse/vert.x/blob/master/src/main/java/io/vertx/core/net/impl/NetServerBase.java)
 See the `applyConnectionOptions` method.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-191

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #100
    
----
commit c80d40abecfe745ff7b17e297d8f04f969f54d8e
Author: Li Zhanhui <lizhan...@apache.org>
Date:   2017-04-28T03:29:24Z

    BugFix: ROCKETMQ-191

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to