Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103833
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -68,10 +68,10 @@ private void syncTopicConfig() {
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103841
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -85,9 +85,9 @@ private void syncConsumerOffset() {
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103642
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/filtersrv/FilterServerUtil.java
---
@@ -26,9 +26,9 @@ public static void
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103929
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java
---
@@ -247,6 +248,7 @@ public void
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103845
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -106,12 +106,12 @@ private void syncDelayOffset()
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103933
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java
---
@@ -258,6 +260,7 @@ public void
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103499
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java ---
@@ -497,7 +497,7 @@ private void printMasterAndSlaveDiff()
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94101345
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -469,6 +467,7 @@ private void onExceptionImpl(final
GitHub user dongeforever opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/21
[ROCKETMQ-18]Clean code prompted by IntelliJ
Clean code prompted by IntelliJ for branch 'ROCKETMQ-18'.
@vongosling @zhouxinyu please take a time to review it.
You can merge
