[GitHub] incubator-rocketmq-externals issue #4: [ROCKETMQ-81] Add the RocketMq plugin...

Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/4 @vesense thanks, please @hustfxj help review this incorporative PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...

Github user wenfengwang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/13 @zhouxinyu Can you point out the Chinese docs in this PR, I didn't find it. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Semantics of timeout in asynchronous/one-way send methods

Hi, folks, Any one? Any idea on this issue? Zhanhui Li. > 在 2017年4月17日，上午11:43，Zhanhui Li 写道： > > Hi, > > RocketMQ provides three message sending models: synchronous, asynchronous and > one-way. For asynchronous and one-way sending methods, internal > implementation

[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...

Github user wenfengwang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/13 @zhouxinyu Hi yukon, the PR can be merged, which mainly include: *Basic Model: message, (pull/query/send)_result, topic, header, config, constants *Remoting: Not

[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...

Github user StyleTang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/13 Well done. @wenfengwang There are still some minor problems here, but I think we can merge it first. I will implement the package of remoting base on it. --- If

[GitHub] incubator-rocketmq-externals pull request #13: [ROCKETMQ-182] RocketMQ Go SD...

Github user StyleTang commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-externals/pull/13#discussion_r112834996 --- Diff: rocketmq-go/hook/rpchook.go --- @@ -14,4 +14,10 @@ * See the License for the specific language governing permissions

[GitHub] incubator-rocketmq issue #95: [ROCKETMQ-184]-It takes too long(3-33 seconds)...

Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/95 You are right that more changes are required for my suggested approach. But, IMO, the suggested way is more unified in design and may also save a few memory footprint in case we have

[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...

Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/13 @wenfengwang cool, please polish request_code.go before we can merge this PR, remove or translate the Chinese docs. --- If your project is set up for it, you can reply to

[GitHub] incubator-rocketmq-externals pull request #13: [ROCKETMQ-182] RocketMQ Go SD...

Github user StyleTang commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-externals/pull/13#discussion_r112835033 --- Diff: rocketmq-go/model/response_code.go --- @@ -0,0 +1,67 @@ +package model + +const ( + // success +

[GitHub] incubator-rocketmq-externals issue #4: [ROCKETMQ-81] Add the RocketMq plugin...

Github user vesense commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/4 @hustfxj Yes, I will try to add more unit tests, especially pull mode. @zhouxinyu Do you mind merging this firstly? I will add the tests maybe a few days later because of my

[GitHub] incubator-rocketmq pull request #94: [ROCKETMQ-179] Fix errors of test cases

Github user vsair closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the