[GitHub] incubator-rocketmq pull request #134: Rito - #44 - Extracting out duplicated...

2017-07-30 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130238308 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java --- @@ -1215,9 +1210,13 @@ public TopicRouteData

[GitHub] incubator-rocketmq pull request #134: Rito - #44 - Extracting out duplicated...

2017-07-30 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130238297 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java --- @@ -1215,9 +1210,13 @@ public TopicRouteData

[GitHub] incubator-rocketmq pull request #134: Rito - #44 - Extracting out duplicated...

2017-07-30 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130238369 --- Diff: store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java --- @@ -717,22 +718,28 @@ public long

[GitHub] incubator-rocketmq pull request #140: [ROCKETMQ-253]Compress RegisterBrokerB...

2017-07-30 Thread lizhanhui
GitHub user lizhanhui opened a pull request: https://github.com/apache/incubator-rocketmq/pull/140 [ROCKETMQ-253]Compress RegisterBrokerBody Refer to the description part of [this issue](https://issues.apache.org/jira/browse/ROCKETMQ-253) please. You can merge this pull request

[GitHub] incubator-rocketmq issue #140: [ROCKETMQ-253]Compress RegisterBrokerBody

2017-07-30 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/140 [![Coverage Status](https://coveralls.io/builds/12613613/badge)](https://coveralls.io/builds/12613613) Coverage decreased (-0.08%) to 39.122% when pulling