[GitHub] incubator-rocketmq issue #145: [ROCKETMQ-264]Fix unit test cost too long and...

Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/145 @lindzh Thanks, I made some modifications and merged this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-rocketmq pull request #145: [ROCKETMQ-264]Fix unit test cost too l...

Github user lindzh closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/145 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-rocketmq issue #152: [ROCKETMQ-278]add clusterlist cmd by specifie...

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/152 [](https://coveralls.io/builds/13014639) Coverage increased (+0.03%) to 38.68% when pulling

[GitHub] incubator-rocketmq issue #152: [ROCKETMQ-278]add clusterlist cmd by specifie...

Github user vsair commented on the issue: https://github.com/apache/incubator-rocketmq/pull/152 nice! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-rocketmq pull request #158: [Rocketmq-281] add check policy for pr...

Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/158#discussion_r135678070 --- Diff: broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java --- @@ -257,4 +268,28 @@ public static Options

[GitHub] incubator-rocketmq pull request #157: [Rocketmq-277] fix get localhost throw...

Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/157#discussion_r135678680 --- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java --- @@ -407,12 +408,50 @@ private static String localhost() {

[GitHub] incubator-rocketmq pull request #158: [Rocketmq-281] add check policy for pr...

Github user lindzh commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/158#discussion_r135681629 --- Diff: broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java --- @@ -257,4 +268,28 @@ public static Options

[GitHub] incubator-rocketmq issue #158: [Rocketmq-281] add check policy for preventin...

Github user lindzh commented on the issue: https://github.com/apache/incubator-rocketmq/pull/158 After merge develop branch,all checks will pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-rocketmq pull request #159: [ROCKETMQ-279] commit log data and con...

Github user fuyou001 commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/159#discussion_r135692614 --- Diff: store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java --- @@ -84,6 +84,59 @@ public boolean load() { return

[GitHub] incubator-rocketmq issue #157: [Rocketmq-277] fix get localhost throw java.n...

Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/157 Thank you everyone. I will make some polish and merge this PR :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-rocketmq pull request #157: [Rocketmq-277] fix get localhost throw...

Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/157#discussion_r135698929 --- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java --- @@ -407,12 +408,50 @@ private static String localhost() {

[GitHub] incubator-rocketmq pull request #157: [Rocketmq-277] fix get localhost throw...

Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/157#discussion_r135681743 --- Diff: common/src/test/java/org/apache/rocketmq/common/MixAllTest.java --- @@ -93,4 +90,12 @@ public void testString2File() throws

[GitHub] incubator-rocketmq issue #160: [ROCKETMQ-284] ExpressionMessageFilter will p...

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/160 [](https://coveralls.io/builds/13028196) Coverage increased (+0.02%) to 38.67% when pulling

[GitHub] incubator-rocketmq pull request #159: [ROCKETMQ-279] commit log data and con...

Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/159#discussion_r135688453 --- Diff: store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java --- @@ -84,6 +84,59 @@ public boolean load() { return