+1
On Wed, Aug 30, 2017 at 10:15 AM, Huxing Zhang wrote:
> +1 (Non-binding)
>
> On Wed, Aug 30, 2017 at 10:46 AM, John D. Ament
> wrote:
> > +1
> >
> > On Tue, Aug 29, 2017 at 10:13 PM Von Gosling
> wrote:
> >
> >> Hello IPMC,
>
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
Though there are still quite a few unused files, I am fine to merge this PR
first and fix issues later on.
---
If your project is set up for it, you can reply to this email
+1 (Non-binding)
On Wed, Aug 30, 2017 at 10:46 AM, John D. Ament wrote:
> +1
>
> On Tue, Aug 29, 2017 at 10:13 PM Von Gosling wrote:
>
>> Hello IPMC,
>>
>> The recent DISCUSS thread in PPMC, IPMC and VOTE thread in Community on
>> the topic of
Github user fuyou001 closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/154
Please link the jira in the description and modify the title accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/160#discussion_r135724026
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -369,4 +367,36 @@ public void
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/160#discussion_r135722707
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -369,4 +367,36 @@ public void
Github user dongeforever commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/158#discussion_r135689337
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java ---
@@ -257,4 +268,28 @@ public static Options
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/160
@vongosling pls have a review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/157#discussion_r135705543
--- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java ---
@@ -407,12 +408,50 @@ private static String localhost() {
Github user fuyou001 commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/158#discussion_r135705590
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java ---
@@ -257,4 +268,28 @@ public static Options
Github user fuyou001 commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/158#discussion_r135705577
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java ---
@@ -257,4 +268,28 @@ public static Options
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/160#discussion_r135768140
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -79,24 +79,17 @@
try {
Build Update for apache/incubator-rocketmq
-
Build: #797
Status: Errored
Duration: 1 minute and 42 seconds
Commit: 23b7d7a (develop)
Author: vongosling
Message: Remove star import rule in checkstyle
View the changeset:
Build Update for apache/incubator-rocketmq
-
Build: #796
Status: Errored
Duration: 4 minutes and 2 seconds
Commit: bbe825f (develop)
Author: fuyou001
Message: ROCKETMQ-277 Fix UnknownHostException when nothing configuration in
etc file closes
Build Update for apache/incubator-rocketmq
-
Build: #802
Status: Passed
Duration: 26 minutes and 51 seconds
Commit: 1b853e8 (master)
Author: yukon
Message: Merge branch 'develop'
View the changeset:
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/160#discussion_r135773045
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -79,24 +79,17 @@
try {
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/160
[![Coverage
Status](https://coveralls.io/builds/13031998/badge)](https://coveralls.io/builds/13031998)
Coverage increased (+0.1%) to 38.755% when pulling
Build Update for apache/incubator-rocketmq
-
Build: #798
Status: Passed
Duration: 22 minutes and 22 seconds
Commit: 38d70bd (develop)
Author: vongosling
Message: Polish
View the changeset:
GitHub user StyleTang opened a pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/28
[ROCKETMQ-282]RocketMQ-GO-Client
[ROCKETMQ-282
RocketMQ-GO-Client](https://issues.apache.org/jira/browse/ROCKETMQ-282)
Github user vsair closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
+1
We see a healthy and active community during podling. Expect our community
to build a better and stronger apache project after graduation.
Thanks,
Xin Wang
2017-08-30 10:13 GMT+08:00 Von Gosling :
> Hello IPMC,
>
> The recent DISCUSS thread in PPMC, IPMC and VOTE
+1
On Tue, Aug 29, 2017 at 10:13 PM Von Gosling wrote:
> Hello IPMC,
>
> The recent DISCUSS thread in PPMC, IPMC and VOTE thread in Community on
> the topic of Apache RocketMQ graduation have been opened for at least 72
> hours, and I believe all questions have been
Hello IPMC,
The recent DISCUSS thread in PPMC, IPMC and VOTE thread in Community on the
topic of Apache RocketMQ graduation have been opened for at least 72 hours, and
I believe all questions have been answered and issues addressed at this point.
With the discussion having settled down, I
24 matches
Mail list logo