Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/1
@vongosling The unit test is included in the PR. I don't quite understand
what else is needed...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/1
@shroman
Thanks for your PR, Could you paste some unit test for these question :-) .
please see our contributing checklist,
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/4
Could you abide our PR process(modify your PR subject and mention your jira
address in the description), please follow this PR.
https://github.com/apache/incubator-rocketmq/pull/5
---
GitHub user lollipopjin opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/5
[ROCKETMQ-8]Standardize build script using maven wrapper.
Step1:
Remove original scripts.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user nottyjay opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/4
Null check is not needed -- can't be null when reaches this point.
Validators.checkGroup(String group) will ensure group is not null
You can merge this pull request into a Git repository
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/2
@vongosling
please check the commited unit test .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
