[GitHub] incubator-rocketmq pull request #39: [ROCKETMQ-45]Delete hanged consume queu...

[lizhanhui]

GitHub user lizhanhui opened a pull request:

https://github.com/apache/incubator-rocketmq/pull/39

[ROCKETMQ-45]Delete hanged consume queue files



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-45

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #39


commit 4bb113ce87c6ff52fc9af7ddf2a389e2a45853b6
Author: Zhanhui Li 
Date:   2017-01-12T07:02:26Z

Delete hanged consume queue files




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...

[wu-sheng]

Github user wu-sheng commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/38
  
ref issue https://issues.apache.org/jira/browse/ROCKETMQ-44


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #38: fix/ROCKETMQ-44: Refactor to avoid dupl...

[wu-sheng]

GitHub user wu-sheng opened a pull request:

https://github.com/apache/incubator-rocketmq/pull/38

fix/ROCKETMQ-44:  Refactor to avoid duplicated codes in DefaultMessageStore

Refactor methods and create a new method. And format code by the given 
code-style.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wu-sheng/incubator-rocketmq fix/ROCKETMQ-44

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #38


commit f9fe61f9d516cd1aa8c02b6b2d2493bffce01352
Author: wusheng 
Date:   2017-01-12T03:40:22Z

fix/ROCKETMQ-44:  Refactor methods and create a new method. And format code 
by the given code-style.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #37: [ROCKETMQ-38] Some unit tests for rocketmq-rem...

[iskl]

Github user iskl commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/37
  
@zhouxinyu Apologize... It's my mistake to use a wrong version of 
assertj.-core I've modified it to the correct version for jdk7 :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #34: fix/ROCKETMQ-39: avoid duplicated codes...

[WillemJiang]

Github user WillemJiang commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/34#discussion_r95544500
  
--- Diff: 
filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java ---
@@ -135,27 +137,17 @@ public static FiltersrvController 
createController(String[] args) {
 System.exit(-3);
 }
 
-Runtime.getRuntime().addShutdownHook(new Thread(new Runnable() 
{
-private volatile boolean hasShutdown = false;
-private AtomicInteger shutdownTimes = new AtomicInteger(0);
-
+Runtime.getRuntime().addShutdownHook(new 
ShutdownHookThread(log, new Callable() {
 @Override
-public void run() {
-synchronized (this) {
-log.info("shutdown hook was invoked, " + 
this.shutdownTimes.incrementAndGet());
-if (!this.hasShutdown) {
-this.hasShutdown = true;
-long begineTime = System.currentTimeMillis();
-controller.shutdown();
-long consumingTimeTotal = 
System.currentTimeMillis() - begineTime;
-log.info("shutdown hook over, consuming time 
total(ms): " + consumingTimeTotal);
-}
-}
+public Object call() throws Exception {
--- End diff --

If you don't want to return any thing here , you could define the method 
just like this.
public Void call() throws Exception {
}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #37: [ROCKETMQ-38] Some unit tests for rocketmq-rem...

[zhouxinyu]

Github user zhouxinyu commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/37
  
Hi @iskl, please make sure the PR can pass the CI test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #37: [ROCKETMQ-38] Some unit tests for rocke...

[iskl]

GitHub user iskl opened a pull request:

https://github.com/apache/incubator-rocketmq/pull/37

[ROCKETMQ-38] Some unit tests for rocketmq-remoting

[ref issue](https://issues.apache.org/jira/browse/ROCKETMQ-38).

I wish to improve unit test coverage for RocketMQ and wrote these 
**sample** tests following @vongosling 's guidance. 

> 1. Using testMethod_Condition naming conversion,
Because it's more friendly for maven surefire and idea moreunit plugin
> 2. Mock the module's interaction parts. 
We can use mockito tool to do this
> 3. More assert instead of simple printting. 
Recommend to use assert4j tool
> 4. Do not throw exception in test method
> 5. Use latch instead of thead.sleep
> 6. Pay more attention for your test time-consuming

@vongosling , @zhouxinyu , Would you mind review these **sample** test code 
to see whether the code style is suitable? Peg for suggestion. If that's OK, 
The remaining part would be finished just like the sample test code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/iskl/incubator-rocketmq ROCKETMQ-38

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #37


commit 62da108245029c10f8fe84c8b041ec6c44d73493
Author: Kailai Shao 
Date:   2017-01-10T08:52:09Z

[ROCKETMQ-38] Add unit tests for request & response RemotingCommand 
creating.

commit bca350ff17f2fab2aee4e350d0692e08fab59e7c
Author: Kailai Shao 
Date:   2017-01-11T06:36:22Z

[ROCKETMQ-38] Add unit tests for RemotingCommand encoding and decoding

commit 79c5b9951727a499f6481719e31a8306c8ab1959
Author: Kailai Shao 
Date:   2017-01-11T07:46:43Z

[ROCKETMQ-38] According to vongosling's guidance, modify the code style and 
use AssertJ instead of JUnit.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #36: [ROCKETMQ-43] Remove NoWhitespaceBefore...

[wu-sheng]

GitHub user wu-sheng opened a pull request:

https://github.com/apache/incubator-rocketmq/pull/36

[ROCKETMQ-43] Remove NoWhitespaceBefore module in “rmq_checkstyle.xml”

There are both NoWhitespaceBefore and WhitespaceAfter modules in 
checkstyle.xml, like this:



ref https://issues.apache.org/jira/browse/ROCKETMQ-43

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wu-sheng/incubator-rocketmq fix/ROCKETMQ-43

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit 30bbee67d030c3d0910be773beb3eb1578ac4644
Author: wusheng 
Date:   2017-01-11T08:04:06Z

ROCKETMQ-43: remove NoWhitespaceBefore module in “rmq_checkstyle.xml”




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---