Github user dhchao11 commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/67#discussion_r116650808
--- Diff:
common/src/main/java/org/apache/rocketmq/common/consistenthash/ConsistentHashRouter.java
---
@@ -0,0 +1,140 @@
+/*
+ *
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/60
@zhouxinyu @vongosling
Any comments on this pr and any ideas about `hasTempMessage()`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/101
[](https://coveralls.io/builds/11538511)
Coverage increased (+0.3%) to 31.268% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/101
[](https://coveralls.io/builds/11538511)
Coverage increased (+0.3%) to 31.268% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/101
[](https://coveralls.io/builds/11538511)
Coverage increased (+0.3%) to 31.268% when pulling
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r116641839
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r116641020
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r116638805
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/60
@Jaskey No idea about `hasTempMessage()` -- no comments or unit tests...
All the rest is ok to merge.
---
If your project is set up for it, you can reply to this email and have your
