[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code

2017-09-03 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/27 This Pull Request has been merged and it's safe to close this PR. @vincentWangKB --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code

2017-09-03 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/27 This patch looks good enough to be merged. Thanks @vincentWangKB --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-rocketmq issue #154: [Rocketmq-285] file test error when make link

2017-09-03 Thread zwillim
Github user zwillim commented on the issue: https://github.com/apache/incubator-rocketmq/pull/154 title modified --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-rocketmq issue #154: file test error when make link

2017-09-03 Thread shroman
Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/154 The title should be "[Rocketmq-285] file test error when make link" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-rocketmq issue #154: file test error when make link

2017-09-03 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/154 [![Coverage Status](https://coveralls.io/builds/13109931/badge)](https://coveralls.io/builds/13109931) Coverage decreased (-0.06%) to 38.712% when pulling

[GitHub] incubator-rocketmq pull request #154: file test error when make link

2017-09-03 Thread zwillim
GitHub user zwillim reopened a pull request: https://github.com/apache/incubator-rocketmq/pull/154 file test error when make link line 62. cannot test ${HOME}/tmpfs while making link to ./tmpfs change "ln -s /dev/shm tmpfs" to "ln -s /dev/shm ${HOME}/tmpfs"

[GitHub] incubator-rocketmq issue #154: file test error when make link

2017-09-03 Thread zwillim
Github user zwillim commented on the issue: https://github.com/apache/incubator-rocketmq/pull/154 modified as required. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-rocketmq pull request #154: file test error when make link

2017-09-03 Thread zwillim
Github user zwillim closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the