Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/82#discussion_r108886049
--- Diff:
filter/src/main/java/org/apache/rocketmq/filter/expression/BinaryExpression.java
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/82#discussion_r108886427
--- Diff:
filter/src/main/java/org/apache/rocketmq/filter/parser/ParseException.java ---
@@ -0,0 +1,204 @@
+/*
+ * Licensed
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/82#discussion_r108883657
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/filter/CommitLogDispatcherCalcBitMap.java
---
@@ -0,0 +1,112
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/82#discussion_r108883414
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/filter/CommitLogDispatcherCalcBitMap.java
---
@@ -0,0 +1,112
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/82#discussion_r108883867
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/filter/ConsumerFilterData.java
---
@@ -0,0 +1,180 @@
+/*
+ * Licensed
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/82#discussion_r108887819
--- Diff:
filter/src/main/java/org/apache/rocketmq/filter/util/LRUCache.java ---
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/82#discussion_r108887358
--- Diff:
filter/src/main/java/org/apache/rocketmq/filter/util/HashAlgorithm.java ---
@@ -0,0 +1,239 @@
+/*
+ * Licensed to the Apache
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/82#discussion_r108884747
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/CommitLogDispatcherCalcBitMapTest.java
---
@@ -0,0 +1,213
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/82#discussion_r108884189
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/filter/ConsumerFilterData.java
---
@@ -0,0 +1,180 @@
+/*
+ * Licensed
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/82#discussion_r108881956
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerIdsChangeListener.java
---
@@ -16,9 +16,7 @@
*/
package
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/5
@dongeforever @shroman @stevenschew thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/82
@shroman @lizhanhui How do you think about this feature~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/56
LGTM~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r108614905
--- Diff:
tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java ---
@@ -196,22 +196,11 @@ private static void initLog
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
@shroman We'd better merge PR not the same guys. you pull, the other guy
merge. @dongeforever Could you help us to merge this PR :-)
---
If your project is set up for it, you can
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/57
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
@Jaskey Thanks for your elaborative consideration about exception. Let it
go as you have changed. we will merge this PR.
---
If your project is set up for it, you can reply
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
If we remove it, all authentication fail will have one log, and this could
be possibly very often and fill up with the remoting log, which I do not think
it is good enough.
We
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
@lizhanhui @Jaskey we'd better close after merge :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
LGTM~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/83
LGTM,please @shroman @lizhanhui help to review it~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/79
LGTM,please @shroman @zhouxinyu help to review it~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
@lizhanhui Done for dev. branch ~ Could you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/71
@Ah39 Could you modify your PR topic?
http://rocketmq.incubator.apache.org/docs/pull-request/,please refer to it ~
---
If your project is set up for it, you can reply to this email
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
LGTM~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/8
@shroman LGTM :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/76
@eoss1990 If you have not confirm PR process, please start your demo to
practice it ?
BTW, please close this meaningless PR, thanks
---
If your project is set up for it, you
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
please notice your PR topic
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/51
LGTM :-) We will degrade the client SDK version to 1.6 in the developer
branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/51
@shroman Recently, some our customer resort to us to degrade JDK version to
1.6. IMO, we can keep the pace with netty for our SDK. So, if we polish code
associating with SDK, we'd
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/69
thanks @yilingfeng . Consider this PR has been merged, we will commit your
unit-test in another commit. @shroman I have a same understand as @zhouxinyu
about your unit-test said
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
@lizhanhui Cool. Did you check the commits, letting all passed in at least
2 windows environment ?
---
If your project is set up for it, you can reply to this email and have your
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/69
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101991874
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -278,14 +280,14 @@ public void createTopic(final
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101995717
--- Diff:
store/src/main/java/org/apache/rocketmq/store/AppendMessageResult.java ---
@@ -119,6 +129,7 @@ public String toString
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101989915
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
---
@@ -442,6 +449,202 @@ private
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101994094
--- Diff:
common/src/main/java/org/apache/rocketmq/common/message/MessageBatch.java ---
@@ -0,0 +1,77 @@
+/*
+ * Licensed
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101992848
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
---
@@ -595,8 +596,11 @@ private
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101993057
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
---
@@ -737,6 +742,10 @@ public
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101990343
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
---
@@ -442,6 +449,202 @@ private
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101965587
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
---
@@ -72,7 +73,13 @@ public RemotingCommand
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
@dongeforever we can continue to polish this PR, IMO. if you have any
problem. please let me know. BTW, can you post your performance test result for
us
---
If your project is set up
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
Yep agreed @lizhanhui . I will make some comment as much detail as possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Thanks Bruce,
IMO, Service Desk is a design for customer support. So, we have not apply
this feature. We just want to make some works on use of Agile board.
I have a permission to create a sprint now. I think that's ok for use.
Thanks bruce again :-)
2017-02-15 6:25 GMT+08:00 Bruce Snyder
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
Agree
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
Cool, Thanks @dongeforever providing this feature. We will have a look at
this implementation. please hold your horses :-)
---
If your project is set up for it, you can reply
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/51
@shroman since 4.1.0, we will start a new branching model, more
formalized, more flexible. All PRs except those hotfixs, we recommended to
merge back to develop branch. This guide
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/48
alright
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/38
@wu-sheng Thanks for your clean code actions. Why so many format operation,
what had happend when you use our checkstyle, let me know. BTW, you know, UT is
the best assistant
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/44
Thanks @naughtybear
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user vongosling opened a pull request:
https://github.com/apache/incubator-rocketmq-site/pull/6
Update deploy guide
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vongosling/incubator-rocketmq-site patch-1
Alternatively
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/37
Thanks @iskl @shroman @WillemJiang , I will work on the rocketmq remoting
module these days.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/41
@tain198127 Could you follow other PR[1] style at first
[1] https://github.com/apache/incubator-rocketmq/pull/5
---
If your project is set up for it, you can reply
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/34
@wu-sheng Could you modify your PR , following our codestyle and PR
guide[1] :-)
[1]http://rocketmq.incubator.apache.org/docs/code-guidelines/
---
If your project is set up
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/3
IMO, we should prefer slf4j or String.format effective format way to log in
4.x :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94732806
--- Diff: _docs/06-best-practice-pull-request.md ---
@@ -4,23 +4,40 @@ permalink: /docs/pull-request/
modified: 2016-12-24T15:01:43-04
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/3
Alright. please @zhouxinyu @lizhanhui review again:-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94728311
--- Diff: _docs/06-best-practice-pull-request.md ---
@@ -4,23 +4,40 @@ permalink: /docs/pull-request/
modified: 2016-12-24T15:01:43-04
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/17
Thanks for your ISSUE review before PR @Zhang-Ke
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/21
That's ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/19
IMO, we could close this pr without any more works @lollipopjin
thanks @Jaskey
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
We must keep cautious about storage polish, although some minor rename.
IMO, Could we optimize here in the 4.1.0 or more later version :-)
---
If your project is set up for it, you
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103833
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -68,10 +68,10 @@ private void syncTopicConfig
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103841
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -85,9 +85,9 @@ private void syncConsumerOffset
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103642
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/filtersrv/FilterServerUtil.java
---
@@ -26,9 +26,9 @@ public static void callShell
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103929
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java
---
@@ -247,6 +248,7 @@ public void
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103845
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -106,12 +106,12 @@ private void syncDelayOffset
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103933
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java
---
@@ -258,6 +260,7 @@ public void
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103499
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java ---
@@ -497,7 +497,7 @@ private void printMasterAndSlaveDiff
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/1
@shroman
Thanks for your PR, Could you paste some unit test for these question :-) .
please see our contributing checklist,
https://github.com/apache/incubator-rocketmq/blob/master
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/4
Could you abide our PR process(modify your PR subject and mention your jira
address in the description), please follow this PR.
https://github.com/apache/incubator-rocketmq/pull/5
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/2
@Jaskey Thanks for your PR, Could you paste some unit test for these
question :-) . please see our contributing checklist,
https://github.com/apache/incubator-rocketmq/blob/master
101 - 173 of 173 matches
Mail list logo
