[GitHub] incubator-rocketmq pull request #104: [ROCKETMQ-201]Remove spaces before and...

2017-06-16 Thread huangyiminghappy
Github user huangyiminghappy closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rocketmq issue #121: Remove the code that is not useful in the loo...

2017-06-16 Thread huangyiminghappy
Github user huangyiminghappy commented on the issue: https://github.com/apache/incubator-rocketmq/pull/121 https://issues.apache.org/jira/browse/ROCKETMQ-226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-rocketmq pull request #121: Remove the code that is not useful in ...

2017-06-16 Thread huangyiminghappy
GitHub user huangyiminghappy opened a pull request: https://github.com/apache/incubator-rocketmq/pull/121 Remove the code that is not useful in the loop[ROCKETMQ-226] Remove the code that is not useful in the loop You can merge this pull request into a Git repository by running

[GitHub] incubator-rocketmq pull request #104: Remove spaces before and after the pro...

2017-06-06 Thread huangyiminghappy
Github user huangyiminghappy commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/104#discussion_r120526362 --- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java --- @@ -279,7 +279,7 @@ public static String properties2String

[GitHub] incubator-rocketmq pull request #104: Remove spaces before and after the pro...

2017-06-06 Thread huangyiminghappy
Github user huangyiminghappy commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/104#discussion_r117210642 --- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java --- @@ -339,6 +339,8 @@ public static void properties2Object(final

[GitHub] incubator-rocketmq pull request #104: Remove spaces before and after the pro...

2017-05-17 Thread huangyiminghappy
Github user huangyiminghappy commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/104#discussion_r117149430 --- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java --- @@ -339,6 +339,8 @@ public static void properties2Object(final