[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 [](https://coveralls.io/builds/12633575) Coverage increased (+0.02%) to 38.744% when pulling **3cc04e2efd4005bb3ae26c9db6c3ebefb8787eba on lizhanhui:tls** into **118bdec96005ce695295bcf0d9082e0230e69bf7 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 [](https://coveralls.io/builds/12633575) Coverage increased (+0.02%) to 38.744% when pulling **3cc04e2efd4005bb3ae26c9db6c3ebefb8787eba on lizhanhui:tls** into **118bdec96005ce695295bcf0d9082e0230e69bf7 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.
Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 OK. IT tests have been added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 [](https://coveralls.io/builds/12590728) Coverage increased (+0.5%) to 39.174% when pulling **0f98b9e7ab63a362aca9ecd4d652269983a017d1 on lizhanhui:tls** into **118bdec96005ce695295bcf0d9082e0230e69bf7 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.
Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 @lindzh It seems lack IT tests for TLS. IMO, it needs two IT Test at least. one for old client which dose not support TLS, one for new. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 [](https://coveralls.io/builds/12231167) Coverage increased (+0.3%) to 38.725% when pulling **0ca60db50aec2abc3ad3c3ea4a92e838a7579734 on lizhanhui:tls** into **c4a3e0c1325e67aec76aa94e9ade3a6ea1b682d2 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 [](https://coveralls.io/builds/12165746) Coverage increased (+0.02%) to 38.461% when pulling **3b9780c1aa39452eebc511a6557e008d11febff8 on lizhanhui:tls** into **c4a3e0c1325e67aec76aa94e9ade3a6ea1b682d2 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 [](https://coveralls.io/builds/12165746) Coverage increased (+0.02%) to 38.461% when pulling **3b9780c1aa39452eebc511a6557e008d11febff8 on lizhanhui:tls** into **c4a3e0c1325e67aec76aa94e9ade3a6ea1b682d2 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 [](https://:/builds/12024484) Coverage increased (+0.7%) to 39.117% when pulling **cb20e1fed398f3e2f76ea8366b78e8a5b305f42a on lizhanhui:tls** into **c4a3e0c1325e67aec76aa94e9ade3a6ea1b682d2 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 [](https://:/builds/12024484) Coverage increased (+0.7%) to 39.117% when pulling **cb20e1fed398f3e2f76ea8366b78e8a5b305f42a on lizhanhui:tls** into **c4a3e0c1325e67aec76aa94e9ade3a6ea1b682d2 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 [](https://:/builds/12024484) Coverage increased (+0.7%) to 39.117% when pulling **cb20e1fed398f3e2f76ea8366b78e8a5b305f42a on lizhanhui:tls** into **c4a3e0c1325e67aec76aa94e9ade3a6ea1b682d2 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 [](https://:/builds/11982999) Coverage increased (+0.3%) to 38.702% when pulling **2df67e3c7d2fa8dba31d7f8cce8041a9a2fcbdab on lizhanhui:tls** into **c4a3e0c1325e67aec76aa94e9ade3a6ea1b682d2 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 [](https://:/builds/11982999) Coverage increased (+0.3%) to 38.702% when pulling **2df67e3c7d2fa8dba31d7f8cce8041a9a2fcbdab on lizhanhui:tls** into **c4a3e0c1325e67aec76aa94e9ade3a6ea1b682d2 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
