[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...
Github user Ritabrata-TW commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @vongosling We do not need a messaging queue in our Project as of yet. Will be advocating for RocketMQ if the scenario arises. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @Ritabrata-TW Thanks for your attention for rocketmq community, whats' your scenario when using apache rocketmq in your company :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...
Github user Ritabrata-TW commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @zhouxinyu Thanks a lot. Will look forward to working with you again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...
Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @Ritabrata-TW this PR has been merged into `develop` branch and will be released in next version, you can close it now safely. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...
Github user Ritabrata-TW commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @zhouxinyu Thanks. I will keep the suggested things in mind next time. Please let me know if you need anything to close the PR. I would also like to get more involved with the RocketMQ community and would be dropping a mentoring request in the mailing list. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @Ritabrata-TW I found so many code format in your PR, could you import our code style file as instruction, http://rocketmq.incubator.apache.org/docs/code-guidelines/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...
Github user Ritabrata-TW commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @vongosling @zhouxinyu Anything else that I need to do on this? Otherwise, can you please have a look and merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...
Github user Ritabrata-TW commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @zhouxinyu My pleasure. I have set the merge target to develop. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...
Github user vsair commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 Is there something wrong with your code style ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @Ritabrata-TW thanks, I will take a close look it later :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 [](https://coveralls.io/builds/12692862) Coverage decreased (-0.3%) to 38.78% when pulling **dc2ce20af7715e454bd20f3dae039c2d13bc41cf on Ritabrata-TW:master** into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 [](https://coveralls.io/builds/12692862) Coverage decreased (-0.3%) to 38.78% when pulling **dc2ce20af7715e454bd20f3dae039c2d13bc41cf on Ritabrata-TW:master** into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
