[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/38 @wu-sheng Thanks for your clean code actions. Why so many format operation, what had happend when you use our checkstyle, let me know. BTW, you know, UT is the best assistant of the refactoring :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...
Github user wu-sheng commented on the issue: https://github.com/apache/incubator-rocketmq/pull/38 @zhouxinyu , If your team member can provide these Mock-Classes, it will be easier to add test-cases for my changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...
Github user wu-sheng commented on the issue: https://github.com/apache/incubator-rocketmq/pull/38 @zhouxinyu , I have tried before. But there is a problem. In recent RocketMQ codes, there are no `ConsumeQueueMock` and `CommitLogMock`, I am not sure if I create the Mock-Classes, they are good enough. If you want me to do that, I can try it, but no guarantee. Any thoughts? @vongosling @WillemJiang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...
Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/38 Hi @wu-sheng ,Could you please add some unit tests for this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...
Github user wu-sheng commented on the issue: https://github.com/apache/incubator-rocketmq/pull/38 @zhouxinyu , just did it manually. It's crazy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...
Github user wu-sheng commented on the issue: https://github.com/apache/incubator-rocketmq/pull/38 Ok, I will sync this change to my pull requests. And check later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...
Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/38 @wu-sheng , sorry for my fault, I made some changes in intelliJ graph config page which doesn't reflect to the style file, anyway, I have updated the code style file, please check it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...
Github user wu-sheng commented on the issue: https://github.com/apache/incubator-rocketmq/pull/38 @zhouxinyu , All travis-ci passed. Why style is still not correct? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...
Github user wu-sheng commented on the issue: https://github.com/apache/incubator-rocketmq/pull/38 @zhouxinyu, seems your style cause this. My intelliJ config is like this: https://cloud.githubusercontent.com/assets/5441976/21923724/a13662ee-d9b0-11e6-938e-7628f637e7dc.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...
Github user wu-sheng commented on the issue: https://github.com/apache/incubator-rocketmq/pull/38 ref issue https://issues.apache.org/jira/browse/ROCKETMQ-44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
