[GitHub] incubator-rocketmq issue #55: [ROCKETMQ-89] WS_DOMAIN_NAME, SUBGROUP default...

2017-04-12 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/55 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] incubator-rocketmq issue #55: [ROCKETMQ-89] WS_DOMAIN_NAME, SUBGROUP default...

2017-04-12 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/55 > But I don't quite understand why it has to have so many levels -- why not to remove rmqAddressServerDomain and let the user use only rocketmq.namesrv.domain ... ? Yes, I am

[GitHub] incubator-rocketmq issue #55: [ROCKETMQ-89] WS_DOMAIN_NAME, SUBGROUP default...

2017-02-08 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/55 We need to disable reuse forks for the broker module as the newly added unit test requires a more isolated environment to run. --- If your project is set up for it, you can reply to

[GitHub] incubator-rocketmq issue #55: [ROCKETMQ-89] WS_DOMAIN_NAME, SUBGROUP default...

2017-02-08 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/55 [![Coverage Status](https://coveralls.io/builds/10055548/badge)](https://coveralls.io/builds/10055548) Coverage decreased (-0.09%) to 31.229% when pulling