Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
[](https://coveralls.io/builds/10784736)
Coverage decreased (-0.5%) to 31.043% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
[](https://coveralls.io/builds/10784736)
Coverage decreased (-0.5%) to 31.043% when pulling
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
@lizhanhui @Jaskey we'd better close after merge :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
Thank you @vongosling @lizhanhui @zhouxinyu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
@Jaskey I'll merge this PR soon. Please close this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
LGTM~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
@Jaskey You are right, I'll follow up and merge this PR ASAP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
Looks good, please @vongosling help review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
[](https://coveralls.io/builds/10190259)
Coverage increased (+0.02%) to 31.535% when pulling
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
@lizhanhui , please review the updated pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
Yes, #4 is not required as MQFaultStrategy#92 may also generate NPE.
Queue ID info is contained in the request header, minimal effort suffices.
---
If your project is set up for it,
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
@lizhanhui , # 4 is not the nessary conditions, since even it is not enble,
the tpInfo's method is still used.
try {
int index =
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
[](https://coveralls.io/builds/10175866)
Coverage increased (+0.09%) to 31.614% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
[](https://coveralls.io/builds/10175883)
Coverage increased (+0.03%) to 31.549% when pulling
15 matches
Mail list logo
