Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/65
Hi, @shroman this PR will be merged to `develop` branch firstly as our new
branching model: http://rocketmq.incubator.apache.org/docs/branching-model
---
If your project is set up for
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/65
@vongosling Thanks for reviewing!
Sure, unit tests can be completed after we improve this module.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/65
@zhouxinyu Thanks for checking it!
Well, `@Ignore` is there just for finer granularity -- we remove it one by
one when implementing each test. If you think we don't need it, I can
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/65
Hi @shroman ,
LGTM, but why do we add so many `@Ignore` annotations in this PR? All the
he unit tests of tools module have been skipped in `tools/pom.xml`. We may
forget to remove
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/65
[](https://coveralls.io/builds/10192313)
Coverage increased (+0.02%) to 31.538% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/65
[](https://coveralls.io/builds/10192313)
Coverage increased (+0.02%) to 31.538% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/65
[](https://coveralls.io/builds/10192313)
Coverage increased (+0.02%) to 31.538% when pulling
