[GitHub] incubator-rocketmq pull request #157: [Rocketmq-277] fix get localhost throw...

2017-08-29 Thread fuyou001
Github user fuyou001 closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-rocketmq pull request #157: [Rocketmq-277] fix get localhost throw...

2017-08-29 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/157#discussion_r135705543 --- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java --- @@ -407,12 +408,50 @@ private static String localhost() {

[GitHub] incubator-rocketmq pull request #157: [Rocketmq-277] fix get localhost throw...

2017-08-28 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/157#discussion_r135698929 --- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java --- @@ -407,12 +408,50 @@ private static String localhost() {

[GitHub] incubator-rocketmq pull request #157: [Rocketmq-277] fix get localhost throw...

2017-08-28 Thread dongeforever
Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/157#discussion_r135681743 --- Diff: common/src/test/java/org/apache/rocketmq/common/MixAllTest.java --- @@ -93,4 +90,12 @@ public void testString2File() throws

[GitHub] incubator-rocketmq pull request #157: [Rocketmq-277] fix get localhost throw...

2017-08-28 Thread zhouxinyu
Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/157#discussion_r135678680 --- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java --- @@ -407,12 +408,50 @@ private static String localhost() {