[GitHub] incubator-rocketmq pull request #3: [ROCKETMQ-6] Use logger for exceptions i...

2017-07-05 Thread shroman
Github user shroman closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-rocketmq pull request #3: [ROCKETMQ-6] Use logger for exceptions i...

2017-07-04 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/3#discussion_r93905062 --- Diff: rocketmq-remoting/src/main/java/com/alibaba/rocketmq/remoting/common/ServiceThread.java --- @@ -86,7 +86,7 @@ public void stop() {

[GitHub] incubator-rocketmq pull request #3: [ROCKETMQ-6] Use logger for exceptions i...

2017-07-04 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/3#discussion_r93905067 --- Diff: rocketmq-remoting/src/main/java/com/alibaba/rocketmq/remoting/common/ServiceThread.java --- @@ -101,7 +101,7 @@ public void