[GitHub] incubator-rocketmq pull request #85: [ROCKETMQ-158]Remove logback dependency...

2017-04-13 Thread Jaskey
Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/85#discussion_r111524822 --- Diff: common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-rocketmq pull request #85: [ROCKETMQ-158]Remove logback dependency...

2017-04-12 Thread Jaskey
Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/85#discussion_r111210164 --- Diff: common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-rocketmq pull request #85: [ROCKETMQ-158]Remove logback dependency...

2017-04-12 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/85#discussion_r67855 --- Diff: common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache

[GitHub] incubator-rocketmq pull request #85: [ROCKETMQ-158]Remove logback dependency...

2017-04-12 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/85#discussion_r67737 --- Diff: common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache

[GitHub] incubator-rocketmq pull request #85: [ROCKETMQ-158]Remove logback dependency...

2017-03-29 Thread Jaskey
Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/85#discussion_r108666872 --- Diff: tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java --- @@ -196,22 +196,11 @@ private static void initLog() {

[GitHub] incubator-rocketmq pull request #85: [ROCKETMQ-158]Remove logback dependency...

2017-03-29 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/85#discussion_r108616049 --- Diff: tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java --- @@ -196,22 +196,11 @@ private static void initLog() {

[GitHub] incubator-rocketmq pull request #85: [ROCKETMQ-158]Remove logback dependency...

2017-03-29 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/85#discussion_r108614905 --- Diff: tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java --- @@ -196,22 +196,11 @@ private static void initLog() {