Much appreciated, I typed up the JIRA for you. If you're tied up with
other projects, you can unassign yourself from it.
Regards,
Glen
On 07/19/2014 10:32 PM, Gaurav Saini wrote:
Hello Glen,
Yes, definately I will make this necessary change to the gaurav theme.
Thanks
Gaurav
On Jul 20, 201
Hi Dave, ROL-2039 is finished. The database changes I'm (now) aware of
that we may wish to get done before we release 5.1:
1.) rename the "website" table to "weblog" (as its POJO is already
named). This should be a trivial change, as we already have a macro for
table renaming that we know wo
Hello Glen,
Yes, definately I will make this necessary change to the gaurav theme.
Thanks
Gaurav
On Jul 20, 2014 3:36 AM, "Glen Mazza" wrote:
> Hi Gaurav, I noticed with your theme, by default we require the blog
> reader looking at the blog home page to need to hit the "Read More >"
> button
On 07/19/2014 10:21 AM, Glen Mazza wrote:
Do you still want to retain this functionality in 5.1, even if it
presently doesn't work? Otherwise, what I can do is have
WeblogTemplate.isNavBar() hardcoded to always return false, so it won't
break anyone's templates, it just will never render, a
Hi Gaurav, I noticed with your theme, by default we require the blog
reader looking at the blog home page to need to hit the "Read More >"
button for every blog article. So if he writes 10 articles, his blog
home page consists of 10 blog titles and 10 "Read More >" but no blog text.
Normally
I don't use these plugins, so I'm +1 for removing them.
On Fri, Jul 18, 2014 at 7:34 AM, Glen Mazza wrote:
> Hi team, we have four blog entry plugins that we deactivate by default in
> our roller.properties file, meaning not many even know about them. (Three
> we do keep active: smiley plugin,
On 07/19/2014 10:14 AM, Dave wrote:
On Sat, Jul 19, 2014 at 10:02 AM, Glen Mazza wrote:
Hi Dave, I don't understand the use case of "navbar", and it doesn't seem
to work today anyway. I took one of my templates, "_header", and marked it
navbar-able. So my navbar menu indeed changed from:
F
On Sat, Jul 19, 2014 at 10:02 AM, Glen Mazza wrote:
> Hi Dave, I don't understand the use case of "navbar", and it doesn't seem
> to work today anyway. I took one of my templates, "_header", and marked it
> navbar-able. So my navbar menu indeed changed from:
>
> Front Page
> Weblog
> Login
>
>
OK, Dave, so we're not working over each other, let me clean up my loose
ends today, and I'll be taking a break off Roller starting tomorrow (at
least DB stuff), handing it to you. I'll let you know as soon as I'm done.
Glen
On 07/19/2014 09:58 AM, Dave wrote:
Yes, outputType and contentType
Hi Dave, I don't understand the use case of "navbar", and it doesn't
seem to work today anyway. I took one of my templates, "_header", and
marked it navbar-able. So my navbar menu indeed changed from:
Front Page
Weblog
Login
to
Front Page
Weblog
_header
Login
Even without logging in, "_hea
Yes, outputType and contentType are the same thing.
- Dave
On Sat, Jul 19, 2014 at 9:52 AM, Glen Mazza wrote:
> I can move that element in our theme.xml in a heartbeat, but is this
> "contentType" field now the same as "outputType"? I.e., populate
> outputType with what that contentType says
I can move that element in our theme.xml in a heartbeat, but is this
"contentType" field now the same as "outputType"? I.e., populate
outputType with what that contentType says once it is moved to the
template-level?
Glen
On 07/19/2014 09:45 AM, Dave wrote:
Hmm... I think that is a bug. The
No more changes beyond ROL-2039. Give me another day, if I'm not
finished by tomorrow morning I'll punt it to you. I hate working on the
database, however necessary it is.
The 5.0.4 to 5.1.0 migrations won't work because the templates weren't
getting copied from webpage to custom_theme_rendi
Hmm... I think that is a bug. The contentType field should be at the page
(or in this case stylesheet) level and not nested inside templateCode.
- Dave
On Sat, Jul 19, 2014 at 9:30 AM, Glen Mazza wrote:
> OK, outputtype will be retained.
>
> But actually, the contentType is defined in the the
OK, outputtype will be retained.
But actually, the contentType is defined in the theme.xml's for the theme:
basic-custom.css
Stylesheet for Basic theme
basic-custom.css
velocity
text/html
basic-custom.css
standard
Also, I'd like to start doing migration testing on my site's database, and
the one from blogs.apache.org, but I don't want to do that until we freeze
the schema for the 5.1 release.
Are we ready to do that yet, or do you have more changes to suggest?
- Dave
On Sat, Jul 19, 2014 at 9:24 AM, Dav
At this point the UI allows a user to set the content type for a page
template and the PageServlet respects that choice. We do not have a way to
set the content type for each rendition of a page template, and I'm not
sure we really need that feature. So, for now I'd recommend removing
content type
Oh, I never noticed the advanced settings section before, now I see it.
Glen
On 07/19/2014 08:54 AM, Dave wrote:
isNavBar is used by the #showPageMenu() macro and to determine which page
templates to show in the page menu. Do not remove it or you will break lots
of themes, including mine. You c
But isn't that the contenttype value in custom_template_rendition?
Glen
On 07/19/2014 08:58 AM, Dave wrote:
Please do not remove outputtype either. Page templates can be used to
generate XML, JSON and other types of output and you need to be able to set
the content-type when you produce those
Please do not remove outputtype either. Page templates can be used to
generate XML, JSON and other types of output and you need to be able to set
the content-type when you produce those types.
- Dave
On Sat, Jul 19, 2014 at 8:54 AM, Dave wrote:
> isNavBar is used by the #showPageMenu() macro
isNavBar is used by the #showPageMenu() macro and to determine which page
templates to show in the page menu. Do not remove it or you will break lots
of themes, including mine. You can set the value in the advanced settings
part of the page template edit page.
- Dave
On Fri, Jul 18, 2014 at 6:5
21 matches
Mail list logo
