Build failed in Jenkins: royale-asjs_jsonly #760

2018-05-06 Thread apacheroyaleci
See -- [...truncated 1.77 MB...] [mxmlc] org.apache.royale.html.ButtonBar depends on org.apache.royale.html.List [mxmlc]

Build failed in Jenkins: royale-asjs_jsonly #759

2018-05-06 Thread apacheroyaleci
See -- [...truncated 1.80 MB...] [mxmlc] C:/Program Files

Build failed in Jenkins: royale-asjs_jsonly #758

2018-05-06 Thread apacheroyaleci
See Changes: [carlosrovira] return ItemRendererMouseController to Basic refactoring DataItemRenderer -- [...truncated 1.76 MB...]

Re: Container change

2018-05-06 Thread Carlos Rovira
Hi Harbs, just commited a change that return the controller to Basic to html package let me now if that fixes your problem thanks Carlos 2018-05-06 12:25 GMT+02:00 Carlos Rovira : > Just returned Container to Basic without problem. > > But seems to me that this

Build failed in Jenkins: royale-asjs_jsonly #757

2018-05-06 Thread apacheroyaleci
See Changes: [carlosrovira] remove import -- [...truncated 1.80 MB...] [mxmlc] C:/Program Files

Build failed in Jenkins: royale-asjs_jsonly #756

2018-05-06 Thread apacheroyaleci
See -- [...truncated 1.77 MB...] [mxmlc]

Build failed in Jenkins: royale-asjs_jsonly #755

2018-05-06 Thread apacheroyaleci
See Changes: [carlosrovira] upgrading jewel themes [carlosrovira] return Container to Basic [carlosrovira] More Container changes that was left

Re: Container change

2018-05-06 Thread Carlos Rovira
Just returned Container to Basic without problem. But seems to me that this change should not make any problem at all for anyone, since is in the same package (core) and all examples build without problem, so any other App should as well build without any change. 2018-05-06 12:00 GMT+02:00

Re: Container change

2018-05-06 Thread Carlos Rovira
Hi dealing with ItemRendererMouseController there's a dependency in DataItemRenderer, and that was needed to move to Core, since is core in itself. Thinking about it that controller seems to have a very core functionality, so IMHO is that is better to upgrade Apps changing "html" package to

Re: Container change

2018-05-06 Thread Carlos Rovira
Hi Piotr, I'm using HTML only for some headings, at the moment, but as Harbs said in the other thread about HTML, it was depending from Group and that wasn't needed, and that make HTML pull the complete Basic dependency when not required, and that's made lots of CSS be linked. So HTML for me was

Re: Container change

2018-05-06 Thread Carlos Rovira
Hi, sure, some of the classes can be in "html" instead of "core", but as the lib is "Core" I though it was the right choice. If it's only a matter of package change in applications like a did in all the examples affected, I think this means only a few changes. For Container I want to return in

Re: Container change

2018-05-06 Thread yishayw
Piotr Zarzycki wrote > If yes - what does that mean that such controller like > ItemRendererMouseController is in HTML? It's only there by name, the source is under Basic (which makes sense to me, I think controllers are part of the component set). I'm not sure why it can't be named

Re: Container change

2018-05-06 Thread Piotr Zarzycki
I'm a bit afraid to pull down changes. :) Let's think a bit more about that. Carlos wanted to totally separate each module. He didn't want to have dependency in Jewel from Basic. As I understand he was using HTML module which seems to be dependent on Basic as well. His changes are get rid off

Re: Container change

2018-05-06 Thread Harbs
Actually my whole app is broken now… :-( > On May 6, 2018, at 10:14 AM, Harbs wrote: > > org.apache.royale.html.beads.controllers.ItemRendererMouseController was > changed to the core package as well (which also broke my app) > > I did not notice discussion about this.

Re: Container change

2018-05-06 Thread Carlos Rovira
Hi Harbs, I'm seeing as well that Container can return to Basic, and ContainerBase be in Core. I think it was part of the hard fight I had to do to deal with the refactoring. ItemRendererMouseController not sure, maybe can be as well in Basic and a copy in Jewel... I'll be in my computer in an

Build failed in Jenkins: royale-asjs_jsonly #754

2018-05-06 Thread apacheroyaleci
See Changes: [harbs] Prevent renaming [carlosrovira] Fix alert layout -- [...truncated 1.76 MB...] [mxmlc]

Re: Container change

2018-05-06 Thread Harbs
org.apache.royale.html.beads.controllers.ItemRendererMouseController was changed to the core package as well (which also broke my app) I did not notice discussion about this. Why the package name change? How many more changes were there like this? Harbs > On May 6, 2018, at 10:07 AM, Harbs

Container change

2018-05-06 Thread Harbs
Why did Container become org.apache.royale.core.Container instead of org.apache.royale.html.Container? Why is Container Core at all? This change broke my app. While it’s not a big deal to fix it, I don’t understand why the change. Unless we decide on a wholesale change of components, this

Build failed in Jenkins: royale-asjs_jsonly #753

2018-05-06 Thread apacheroyaleci
See Changes: [carlosrovira] jewel basic layout and view, and fix part of alert layout [carlosrovira] update jewel examples -- [...truncated