RE: List Item renderer Click event finds a component in its way

2018-07-02 Thread Yishay Weiss
Hi Carlos, Can you post some example app so I can understand the problem? We’re using List in several places in our app, including label and icon renderers, and haven’t had this problem. From: carlos.rov...@gmail.com on behalf of Carlos Rovira Sent:

Re: List Item renderer Click event finds a component in its way

2018-07-02 Thread Alex Harui
If event.currentTarget is not working, we need to make it work. That is the recommended way to handle bubbling of events. The browsers and Flash work that way so folks will expect it to work. The List's change event is not a bubbling event. Only interaction events like Mouse and Keyboard

Re: List Item renderer Click event finds a component in its way

2018-07-02 Thread Piotr Zarzycki
Carlos, I was just curious how it behave in that case. :) Definitely I'm not suggesting that as a solution. Thanks, Piotr On Mon, Jul 2, 2018, 11:44 PM Carlos Rovira wrote: > Hi Yishay, > > thanks for let me know about it. I'm playing with it but I didn't get to > work. > The case is that

Re: List Item renderer Click event finds a component in its way

2018-07-02 Thread Carlos Rovira
Hi Yishay, thanks for let me know about it. I'm playing with it but I didn't get to work. The case is that maybe List component is not ready for this yet. * event.currentTarget seems not exists in ItemRenderers * I can use "itemClicked" event in a MXML List (I think is not set the metadata and

Re: List Item renderer Click event finds a component in its way

2018-07-02 Thread Carlos Rovira
Hi Piotr, I just tried to disable both components but components are still intercepting the click and calling the function so the error is generated. But I think although this could work, not seems to me like a final solution, since I don't think users should need to disable components in an item

RE: Royale compiler not handling Date.fullYear etc

2018-07-02 Thread Frost, Andrew
Ah - thank you! Will look at that later and create a pull request once everything is in there and testing itself properly.. cheers Andrew -Original Message- From: Alex Harui [mailto:aha...@adobe.com.INVALID] Sent: 02 July 2018 16:51 To: dev@royale.apache.org Subject: [EXTERNAL]

Re: Royale compiler not handling Date.fullYear etc

2018-07-02 Thread Alex Harui
Ah yes, the swfdumps... So when tests that produce a SWF run without the Flash playerglobal and standalone debugger, the test harness runs SWFDump and compares the output. The reference copies of the swfdumps are in compiler/src/test/resources/swfdumps and the files have a naming scheme I

RE: Royale compiler not handling Date.fullYear etc

2018-07-02 Thread Frost, Andrew
Latest on this: With the changes in the compiler per the below suggestion (externc-config.xml and ExternCConfiguration changes), we can generate the below code (as extracted from js.swc): public function get timezoneOffset():Number{ return (null); } And everything

Re: Royale compiler not handling Date.fullYear etc

2018-07-02 Thread Alex Harui
Hi Andrew, I agree with your conclusions. Upon further investigation, Google Closure just closed those bugs as duplicates and the original issue remains open. So adding some field to the ExternCConfig sounds like the easiest path for now. Thanks, -Alex On 7/2/18, 2:14 AM, "Frost, Andrew"

RE: List Item renderer Click event finds a component in its way

2018-07-02 Thread Yishay Weiss
Take a look at ItemRendererMouseController.handleMouseUp() in Basic. It uses currentTarget. From: carlos.rov...@gmail.com on behalf of Carlos Rovira Sent: Monday, July 2, 2018 5:27:08 PM To: dev@royale.apache.org Subject: List Item renderer Click event

Re: List Item renderer Click event finds a component in its way

2018-07-02 Thread Piotr Zarzycki
Hi Carlos, What has happened if children (in that case your icon and Label), are disabled ? Thanks, Piotr pon., 2 lip 2018 o 16:27 Carlos Rovira napisał(a): > Hi, > > what's the best way to handle a click event in a List when the Item > renderer has some components that can interfere in the

List Item renderer Click event finds a component in its way

2018-07-02 Thread Carlos Rovira
Hi, what's the best way to handle a click event in a List when the Item renderer has some components that can interfere in the click event? I have an icon and a Label in the item renderer and if I click on one of those "event.target" is logically set to this components. How to make

RE: Royale compiler not handling Date.fullYear etc

2018-07-02 Thread Frost, Andrew
Hi Even if we get the latest version, they still don't support a "readonly" annotation: https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/parsing/Annotation.java lists the ones that are supported. And I tried updating to the newest jar file, got some weird

Re: [MAVEN-BUILD] Royale-asjs - Build # 839 - Still Failing

2018-07-02 Thread Carlos Rovira
Thanks Piotr, right, the build fails for the latest commit, although I think this is really a bug since I removed all files from "assets" folder in JewelTheme since are not used and this caused the fail. But "assets" should not be mandatory. I'll fill an issue in compiler as I have some time