Re: Apache Royale Maven improvements, fixes and reproducible builds PR by Chris Dutz

2019-11-16 Thread Alex Harui
I'm pretty sure I added JGIT in order to do the release on the CI server. See change 1aa2b16 in royale-compiler on Feb 11, 2019. The reason the CI needs JGIT is because the regular Maven git support seemed to expect that you had a private key registered since most folks run the release plugin

Re: Apache Royale Maven improvements, fixes and reproducible builds PR by Chris Dutz

2019-11-16 Thread Carlos Rovira
Hi Piotr, thanks, I'll do my best to try to fix CI issues. I count with you and Alex. About things Alex comment: Chris removed JGit because he had to add that when initially setting up the Maven build (Sort of 4-5 years ago) , git support was very simple and broken. The release plugin has

Re: Apache Royale Maven improvements, fixes and reproducible builds PR by Chris Dutz

2019-11-16 Thread Piotr Zarzycki
Hi Carlos, In my opinion you should try to do whole release process without merging PRs. - as an exercise. Next having all knowledge merge PRs if they are touching release process and start exercising again. You did that too early. We will see how much more time will you have to spend on this,