Re: Different results for compilation Error in JS and SWF compilation

2018-02-07 Thread Alex Harui
On 2/7/18, 2:18 AM, "Andrew Wetmore" wrote: >Ooh, do I get to "+1"?? Everyone on this mailing list gets a vote. Only those on the Project Management Committee get "binding" votes that really matter, but the PMC is supposed to consider non-binding votes in their vote. If lots of non-binding v

Re: Different results for compilation Error in JS and SWF compilation

2018-02-07 Thread Andrew Wetmore
Ooh, do I get to "+1"?? Yes, pushing the documentation from the development branch is a good idea. On Wed, Feb 7, 2018 at 3:35 AM, Alex Harui wrote: > This should be fixed in the nightly builds. > > This is the last thing I wanted to get done before cutting this release. > When I start my day t

Re: Different results for compilation Error in JS and SWF compilation

2018-02-07 Thread Piotr Zarzycki
Let's move with release. Thanks for fixing it! 2018-02-07 8:35 GMT+01:00 Alex Harui : > This should be fixed in the nightly builds. > > This is the last thing I wanted to get done before cutting this release. > When I start my day tomorrow I will start the process. > > I would also like to push r

Re: Different results for compilation Error in JS and SWF compilation

2018-02-06 Thread Alex Harui
This should be fixed in the nightly builds. This is the last thing I wanted to get done before cutting this release. When I start my day tomorrow I will start the process. I would also like to push royale-docs to master so it gets published with this release. I think it is good enough (or will b

Re: Different results for compilation Error in JS and SWF compilation

2018-02-05 Thread Alex Harui
Hopefully, the compiler returns a different exit code if there are only warnings and Moonshine is checking exit codes. Thanks, -Alex On 2/5/18, 9:04 AM, "Piotr Zarzycki" wrote: >It would be great, because I have found that Moonshine's build of any >Royale app is failing if it contains Warnings

Re: Different results for compilation Error in JS and SWF compilation

2018-02-05 Thread Piotr Zarzycki
It would be great, because I have found that Moonshine's build of any Royale app is failing if it contains Warnings from the compiler. I could change the implementation a bit there, but I believe fix in the compiler is more appropriate. It would be consistent then with SWF build. Thanks! Piotr 2

Re: Different results for compilation Error in JS and SWF compilation

2018-02-05 Thread Alex Harui
Yep. I noticed that too. I have no idea how to fix it. Maybe I'll find time to dig into it before cutting the release. -Alex On 2/4/18, 12:38 AM, "Piotr Zarzycki" wrote: >Alex, > >The same thing goes with Warnings, not only errors. > >Piotr > >2018-01-25 18:59 GMT+01:00 Piotr Zarzycki : > >>

Re: Different results for compilation Error in JS and SWF compilation

2018-02-04 Thread Piotr Zarzycki
Alex, The same thing goes with Warnings, not only errors. Piotr 2018-01-25 18:59 GMT+01:00 Piotr Zarzycki : > I have raised issue -> https://github.com/apache/royale-compiler/issues/21 > > 2018-01-25 18:38 GMT+01:00 Alex Harui : > >> Hmm. Maybe MXMLJSC isn't able to pick up the ErrorFormat and

Re: Different results for compilation Error in JS and SWF compilation

2018-01-25 Thread Piotr Zarzycki
I have raised issue -> https://github.com/apache/royale-compiler/issues/21 2018-01-25 18:38 GMT+01:00 Alex Harui : > Hmm. Maybe MXMLJSC isn't able to pick up the ErrorFormat and just uses > %s. I've never looked into how the language resources work. > > HTH, > -Alex > > On 1/25/18, 9:24 AM, "Pi

Re: Different results for compilation Error in JS and SWF compilation

2018-01-25 Thread Alex Harui
Hmm. Maybe MXMLJSC isn't able to pick up the ErrorFormat and just uses %s. I've never looked into how the language resources work. HTH, -Alex On 1/25/18, 9:24 AM, "Piotr Zarzycki" wrote: >Alex, > >I looked into that and without debugging there is no option for me figure >out what has happened

Re: Different results for compilation Error in JS and SWF compilation

2018-01-25 Thread Piotr Zarzycki
Alex, I looked into that and without debugging there is no option for me figure out what has happened. Both classes are using the same formatter and printer to output errors. WorkspaceProblemFormatter and ProblemPrinter MXMLC is taking ErrorFormat=Error: %s from language resources. During the com

Re: Different results for compilation Error in JS and SWF compilation

2018-01-24 Thread Piotr Zarzycki
Ok now I understand! I will look into that :) 2018-01-24 21:40 GMT+01:00 Alex Harui : > I'm saying that if you want JSRoyale to have the same output as the SWF > target, I would look at the compiler source in those files and see if they > are doing something different. I could go fix it myself,

Re: Different results for compilation Error in JS and SWF compilation

2018-01-24 Thread Alex Harui
I'm saying that if you want JSRoyale to have the same output as the SWF target, I would look at the compiler source in those files and see if they are doing something different. I could go fix it myself, but I am trying to encourage other committers to get more familiar with the compiler source.

Re: Different results for compilation Error in JS and SWF compilation

2018-01-24 Thread Piotr Zarzycki
Not sure what do you mean ? That's how we use it I think so. 2018-01-24 21:28 GMT+01:00 Alex Harui : > Interesting. Hadn't noticed that. I guess you could compare the output > logic in the compilers. MXMLC.java should be used for SWF compiles and > MXMLJSC.java for JS compiles. > > -Alex > > O

Re: Different results for compilation Error in JS and SWF compilation

2018-01-24 Thread Alex Harui
Interesting. Hadn't noticed that. I guess you could compare the output logic in the compilers. MXMLC.java should be used for SWF compiles and MXMLJSC.java for JS compiles. -Alex On 1/24/18, 11:59 AM, "Piotr Zarzycki" wrote: >Once Again: > >JSRoyale: >col: 12 This attribute is unexpected. It

Re: Different results for compilation Error in JS and SWF compilation

2018-01-24 Thread Piotr Zarzycki
Once Again: JSRoyale: col: 12 This attribute is unexpected. It will be ignored. : : SWF: col: 12 Error: This attribute is unexpected. It will be ignored. : : 2018-01-24 20:47 GMT+01:00 Alex Harui : > Links are still broken. Paste.a.o might be having problems. Try just cut > and paste of a

Re: Different results for compilation Error in JS and SWF compilation

2018-01-24 Thread Alex Harui
Links are still broken. Paste.a.o might be having problems. Try just cut and paste of a section of the main differences. -Alex On 1/24/18, 10:19 AM, "Piotr Zarzycki" wrote: >Something happened with Apache paste. Posting once again. > >JSRoyale compilation error [1] >SWF compilation error [2]

Re: Different results for compilation Error in JS and SWF compilation

2018-01-24 Thread Piotr Zarzycki
Something happened with Apache paste. Posting once again. JSRoyale compilation error [1] SWF compilation error [2] [1] https://paste.apache.org/JdNf [2] https://paste.apache.org/QgUo 2018-01-24 18:22 GMT+01:00 Alex Harui : > The links do not work for me. > > -Alex > > On 1/24/18, 4:19 AM, "Pi

Re: Different results for compilation Error in JS and SWF compilation

2018-01-24 Thread Alex Harui
The links do not work for me. -Alex On 1/24/18, 4:19 AM, "Piotr Zarzycki" wrote: >Carlos, > >I know what causes the error :) I just wanted to know why the message >provided by compiler is different :) > >Piotr > >2018-01-24 13:18 GMT+01:00 Carlos Rovira : > >> there's a need for a final "h" her

Re: Different results for compilation Error in JS and SWF compilation

2018-01-24 Thread Piotr Zarzycki
Carlos, I know what causes the error :) I just wanted to know why the message provided by compiler is different :) Piotr 2018-01-24 13:18 GMT+01:00 Carlos Rovira : > there's a need for a final "h" here percentWidt > > so it seems something is wrong in the generation right? > > > 2018-01-24 13:0

Re: Different results for compilation Error in JS and SWF compilation

2018-01-24 Thread Carlos Rovira
there's a need for a final "h" here percentWidt so it seems something is wrong in the generation right? 2018-01-24 13:08 GMT+01:00 Piotr Zarzycki : > Hi, > > I have found that during SWF only compilation and JS only although I'm > getting the same errors they are reported a bit differently. > >

Different results for compilation Error in JS and SWF compilation

2018-01-24 Thread Piotr Zarzycki
Hi, I have found that during SWF only compilation and JS only although I'm getting the same errors they are reported a bit differently. In build: compiler.targets=JSRoyale I got [1] In build: compiler.targets=SWF I got [2] There is no word "Error" in case of JSRoyale - Is this a bug ? [1] https