Re: Github comments

Thanks. I filed a JIRA: https://issues.apache.org/jira/browse/INFRA-15664 > On Dec 13, 2017, at 10:26 AM, Justin Mclean wrote: > > Hi, > >> The PR was made against the wrong branch (master instead of develop) >> As a result, it is showing all

Re: Github comments

Hi, And that would also fix graphs here which are currently using master [1][2] Thanks, Justin 1. https://github.com/apache/royale-asjs/graphs/contributors 2. https://github.com/apache/royale-asjs/graphs/commit-activity

Re: Github comments

Hi, > The PR was made against the wrong branch (master instead of develop) > As a result, it is showing all the previous PRs and conversations that are > missing from master, that are in develop already. > > Looks like the PR was closed, so we should be good. Yep my mistake I made the PR against

Re: Github comments

On Tue, Dec 12, 2017 at 11:42 PM, Harbs wrote: > Does anyone know what’s going on with Github comments?[1] > > We have a ton of comments which appear to have nothing to do with the the > PR. > > [1]https://github.com/apache/royale-asjs/pull/96 < > https://github.com/ap

Re: Github comments

Hi Harbs, Maybe comments are mergin additionally. If you merge couple of revision into one pull request and those revision had something to do with the request. Just blind shot. Thanks, Piotr 2017-12-13 8:42 GMT+01:00 Harbs : > Does anyone know what’s going on with Github comments?[1] >

Github comments

Does anyone know what’s going on with Github comments?[1] We have a ton of comments which appear to have nothing to do with the the PR. [1]https://github.com/apache/royale-asjs/pull/96 <https://github.com/apache/royale-asjs/pull/96>