Re: empty class names

2020-01-16 Thread Carlos Rovira
For me is ok to change to have just one way. I think it will be beneficial too. Taking some code like the one I posted, what's the proposal to get the same? Some example code to showcase would be the best to understand El jue., 16 ene. 2020 a las 5:38, Alex Harui () escribió: > > > On 1/15/20, 2

Re: empty class names

2020-01-15 Thread Alex Harui
On 1/15/20, 2:20 PM, "Carlos Rovira" wrote: We're already using UIBase APIs in HTML elements. Example is used in all screens in Tour De Jewel check this link [1], for an example with Pre tag. I understand that's how it is currently coded. I believe we are discussing whether that is

Re: empty class names

2020-01-15 Thread Carlos Rovira
; On 1/15/20, 2:20 AM, "Harbs" wrote: > > > >Currently when an element is added to a parent, the following is > called: > > > >setClassName(computeFinalClassNames()); > > > >Because there’s no check there to determine if a class name wa

Re: empty class names

2020-01-15 Thread Alex Harui
se mode. >> >> Of course, I could be wrong... >> -Alex >> >> On 1/15/20, 2:20 AM, "Harbs" wrote: >> >> Currently when an element is added to a parent, the following is called: >> >> setClas

Re: empty class names

2020-01-15 Thread Harbs
ldn't >> be checking in release mode. >> >> Of course, I could be wrong... >> -Alex >> >> On 1/15/20, 2:20 AM, "Harbs" wrote: >> >> Currently when an element is added to a parent, the following is called: >> >> setCl

Re: empty class names

2020-01-15 Thread Alex Harui
e wrong... > -Alex > > On 1/15/20, 2:20 AM, "Harbs" wrote: > >Currently when an element is added to a parent, the following is called: > >setClassName(computeFinalClassNames()); > >Because there’s no check there

Re: empty class names

2020-01-15 Thread Harbs
Names()); > >Because there’s no check there to determine if a class name was actually > set, you can end up with elements with empty class names like so: class="">, . > >While this has no visual effect, it does clutter up the dom markup in the > browser (and m

Re: empty class names

2020-01-15 Thread Alex Harui
e to determine if a class name was actually set, you can end up with elements with empty class names like so: , . While this has no visual effect, it does clutter up the dom markup in the browser (and might have a non-zero effect on performance — although this is likely minuscule).

Re: empty class names

2020-01-15 Thread Carlos Rovira
urrently when an element is added to a parent, the following is called: > > setClassName(computeFinalClassNames()); > > Because there’s no check there to determine if a class name was actually > set, you can end up with elements with empty class names like so: class=""

empty class names

2020-01-15 Thread Harbs
Currently when an element is added to a parent, the following is called: setClassName(computeFinalClassNames()); Because there’s no check there to determine if a class name was actually set, you can end up with elements with empty class names like so: , . While this has no visual effect, it