Re: BinaryData and odd bytes

' If you have the time to resolve these remaining issues, that would be awesome.' Happy to commit to doing this by mid-July if that works. I do have downtime in July that I can use for Royale, but I also need to set up for Royale development again because I have changed machines. On Fri, Jun

Re: BinaryData and odd bytes

Cool. FYI there are still some issues to resolve: 1. readFloat and readDouble should have the same issues as the various int read methods. I did not fix that yet because calculating floats and doubles is harder than ints. I’m not sure of the best way to handle that. One way is to create a new

Re: BinaryData and odd bytes

Thanks Harbs - that short explanation makes it very clear. Thanks for fixing my broken implementation :). I am guilty of not covering 'real world' combinations in the tests, which was what I used to guide development when I was working on this originally. I am pretty sure I did have also have an

Re: MD5 [was: Re: BinaryData and odd bytes]

Hmm. So are you saying the original code works in SWF but not when transpiled to JS and run in the browser? We might need to understand why and change the compiler output and/or document how to write AS that can transpile correctly. FWIW, the Ant_On_AIR library has a custom MD5 algorithm that

Jenkins build is back to normal : royale-asjs_jsonly #1018

See

Re: BinaryData and odd bytes

I just added a unit test for this. The test will fail with a RTE using the old implementation. Explanation: After reading the first byte, the position is 1 which doesn’t align with a 16IntArray. Thanks, Harbs > On Jun 21, 2018, at 1:48 AM, Greg Dove wrote: > > I am not sure what the

MD5 [was: Re: BinaryData and odd bytes]

I forgot. The ported MD5 code did not work. I just replaced it with an MIT JS implementation… > On Jun 21, 2018, at 1:20 AM, Harbs wrote: > > FYI, the MD5 test there now fails. I have no idea why. Maybe I messed > something up with my BinaryData changes, but I can’t see what…