Re: [royale-compiler] branch develop updated: compiler-jx: added inline-constants compiler option for JS builds to optionally inline the values of primitive constants (like Number, String, Boolean, in

[Alex Harui]

Has anyone investigated the "rules" for Closure inlining constants?  I wonder 
if the fact we @export a lot of constants would affect it.

Just a thought,
-Alex

On 8/8/19, 10:10 PM, "Greg Dove"  wrote:

That sounds great for sure, Josh.
I suspect the 4KB savings comparison might be before the release javascript
is gzipped?
I tend to use 7zip (on Windows) to gzip the release build javascript from
the 2 variations and compare those, using gzip here to mirror what
difference it would make in usual real world conditions. It can sometimes
be a bit demoralizing when you see the smaller difference in absolute terms
when comparing gzipped variants, but if you look at the percentage
improvements it is probably still quite a good improvement.

fyi I just fixed an annotation directive that was not working correctly at
the class level (it was at individual member level previously). If
something is never needed for reflection and is only for static constants,
like your example, then marking it as @royalesuppressexport at the class
level might even do something with similar results in the release build -
for that specific class only. But of course it is not a simple
configuration setting for the whole build, like you are doing.




On Fri, Aug 9, 2019 at 3:06 AM Josh Tynjala 
wrote:

> My goal is to be able to completely omit classes from release builds when
> their only purpose is to define a bunch of constants. Usually, you only
> need a small number of the constants, so the rest of them bloat your app
> for no good reason.
>
> I made a test project with a class that defines 100 Number constants. When
> combined this inline-constants option with a hacky tweak to the compiler
> that omitted the constant definitions from the output, it made the release
> build 4KB smaller. I still need to figure out how to do that in a 
non-hacky
> way, but that kind of reduction is really promising.
>
> --
> Josh Tynjala
> Bowler Hat LLC 

>
>
> On Wed, Aug 7, 2019 at 2:47 PM Greg Dove  wrote:
>
> > Hey Josh, that sounds pretty cool. I'm not sure, but it might however be
> > duplicating some aspects of what GCC already does when it optimizes
> because
> > I expect it might do the same types of thing when it processes the 
@const
> > annotations in the debug code hints.
> > Also, for example, strings are only included once in the js-release 
build
> > if they are above a minimal length and then accessed by reference
> > irrespective of what inlining changes were made in the debug code 
output.
> > This ends up being similar conceptually to SWF's (and AMF) string tables
> I
> > think, although I did not check whether that changed since the ASC 2.0
> > inlining support.
> >
> > fyi I have a local compiler branch from FlexJS days where I have 
bindings
> > for (static) primitive constants being converted to initialization value
> > assignments with inline values instead of *actual bindings*, similar to
> > what I assume you are doing here, but as a way to avoid running binding
> > code for simple static constant bindings. I will revisit that at some
> point
> > soon, It might help improve startup speed for some people.
> >
> >
> >
> > On Thu, Aug 8, 2019 at 9:09 AM  wrote:
> >
> > > This is an automated email from the ASF dual-hosted git repository.
> > >
> > > joshtynjala pushed a commit to branch develop
> > > in repository 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.git&data=02%7C01%7Caharui%40adobe.com%7C86497e4582534ce3174c08d71c87e943%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637009242417501487&sdata=qELSE34oOG7xIHB9tvTybUt3%2FQPAjsHklXRmPR9%2F5%2B8%3D&reserved=0
> > >
> > >
> > > The following commit(s) were added to refs/heads/develop by this push:
> > >  new 61479f5  compiler-jx: added inline-constants compiler option
> for
> > > JS builds to optionally inline the values of primitive constants (like
> > > Number, String, Boolean, int, and uint) instead of referencing them.
> > > 61479f5 is described below
> > >
> > > commit 61479f5cce3c4ea582a1a6a859f1e74ef9256a9f
> > > Author: Josh Tynjala 
> > > AuthorDate: Wed Aug 7 13:52:59 2019 -0700
> > >
> > > compiler-jx: added inline-constants compiler option for JS builds
> to
> > > optionally inline the values of primitive constants (like Number,
> String,
> > > Boolean, int, an

Builds

[Greg Dove]

fyi, I am not sure what is causing the builds to fail, as they are working
fine for me locally.
 I see one was failing on
Express: DataBindingExample
prior to my recent commits and is continuing to fail at the same spot (it
does not do that for me locally)

js-only seems stuck on one of the new royaleunit tests I added which
appears attempting to run for swf.

I will be back in one hour to try to figure these out, sorry if there is
any inconvenience

Build failed in Jenkins: royale-asjs_jsonly #3360

[Apache Royale CI Server]

See 


Changes:

[greg.dove] Attempt to fix Reflection tests

--
[...truncated 1.49 MB...]
 [java] COMPCJSCRoyale
 [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx1g 
 [java] 4.6411008 seconds
 [copy] Copying 1 file to 


main:

copy-swc:

check-for-tests:

test:

main:

Storage:
 [echo] swc-date is 08/09/19 05:52 +

clean:
 [echo] swc-date is 08/09/19 05:52 +

check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:

compile-js:
 [echo] swc-date is 08/09/19 05:52 +
   [delete] Deleting: 


clean:
 [echo] swc-date is 08/09/19 05:52 +
   [delete] Deleting: 


check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:
 [echo] Cross-compiling StorageJS.swc
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=08/09/19 05:52 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.6
 [java] 
-output=
 [java] 
-load-config=
 [java] 
-load-config+=
 [java] target:SWF
 [java] target:JSRoyale
 [java] COMPC
 [java] Loading configuration: 

 [java] Loading configuration: 

 [java] 
 [java] 21109 bytes written to 
C:\jenkins\workspace\royale-asjs_jsonly\frameworks\js\projects\StorageJS\target\StorageJS.swc
 in 1.674 seconds
 [java] COMPCJSCRoyale
 [java] Found ignorable: window
 [java] 3.3827844 seconds
 [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx1g 
 [copy] Copying 1 file to 


main:

copy-swc:

check-for-tests:

test:

main:

XML:
 [echo] swc-date is 08/09/19 05:52 +

clean:
 [echo] swc-date is 08/09/19 05:52 +

check-for-tests:

clean-tests:

clean:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:

compile-js:
 [echo] swc-date is 08/09/19 05:52 +
   [delete] Deleting: 


clean:
 [echo] swc-date is 08/09/19 05:52 +
   [delete] Deleting: 


check-for-tests:

clean-tests:

clean:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:
 [echo] Cross-compiling XMLJS.swc
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.strict-xml=true
 [java] -warn-public-vars=false
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=08/09/19 05:52 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.6
 [java] 
-output=

Build failed in Jenkins: royale-asjs_jsonly #3359

[Apache Royale CI Server]

See 


Changes:

[greg.dove] Porting remnants of manualtests/UnitTests to RoyaleUnit-compatible

[greg.dove] Migrating most manualtests/UnitTests tests to RoyaleUnit. Added 
[Ignore]

[greg.dove] Updates following class level @royalesuppressexport directive now

--
[...truncated 1.49 MB...]
 [java] COMPCJSCRoyale
 [java] 4.6501012 seconds
 [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx1g 
 [copy] Copying 1 file to 


main:

copy-swc:

check-for-tests:

test:

main:

Storage:
 [echo] swc-date is 08/09/19 05:26 +

clean:
 [echo] swc-date is 08/09/19 05:26 +

check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:

compile-js:
 [echo] swc-date is 08/09/19 05:26 +
   [delete] Deleting: 


clean:
 [echo] swc-date is 08/09/19 05:26 +
   [delete] Deleting: 


check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:
 [echo] Cross-compiling StorageJS.swc
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=08/09/19 05:26 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.6
 [java] 
-output=
 [java] 
-load-config=
 [java] 
-load-config+=
 [java] target:SWF
 [java] target:JSRoyale
 [java] COMPC
 [java] Loading configuration: 

 [java] Loading configuration: 

 [java] 
 [java] 21109 bytes written to 
C:\jenkins\workspace\royale-asjs_jsonly\frameworks\js\projects\StorageJS\target\StorageJS.swc
 in 1.753 seconds
 [java] COMPCJSCRoyale
 [java] Found ignorable: window
 [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx1g 
 [java] 3.5256815 seconds
 [copy] Copying 1 file to 


main:

copy-swc:

check-for-tests:

test:

main:

XML:
 [echo] swc-date is 08/09/19 05:26 +

clean:
 [echo] swc-date is 08/09/19 05:26 +

check-for-tests:

clean-tests:

clean:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:

compile-js:
 [echo] swc-date is 08/09/19 05:26 +
   [delete] Deleting: 


clean:
 [echo] swc-date is 08/09/19 05:26 +
   [delete] Deleting: 


check-for-tests:

clean-tests:

clean:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:
 [echo] Cross-compiling XMLJS.swc
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.strict-xml=true
 [java] -warn-public-vars=false
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=08/09/19 05:26 +
 [ja

Re: [royale-compiler] branch develop updated: compiler-jx: added inline-constants compiler option for JS builds to optionally inline the values of primitive constants (like Number, String, Boolean, in

[Greg Dove]

That sounds great for sure, Josh.
I suspect the 4KB savings comparison might be before the release javascript
is gzipped?
I tend to use 7zip (on Windows) to gzip the release build javascript from
the 2 variations and compare those, using gzip here to mirror what
difference it would make in usual real world conditions. It can sometimes
be a bit demoralizing when you see the smaller difference in absolute terms
when comparing gzipped variants, but if you look at the percentage
improvements it is probably still quite a good improvement.

fyi I just fixed an annotation directive that was not working correctly at
the class level (it was at individual member level previously). If
something is never needed for reflection and is only for static constants,
like your example, then marking it as @royalesuppressexport at the class
level might even do something with similar results in the release build -
for that specific class only. But of course it is not a simple
configuration setting for the whole build, like you are doing.




On Fri, Aug 9, 2019 at 3:06 AM Josh Tynjala 
wrote:

> My goal is to be able to completely omit classes from release builds when
> their only purpose is to define a bunch of constants. Usually, you only
> need a small number of the constants, so the rest of them bloat your app
> for no good reason.
>
> I made a test project with a class that defines 100 Number constants. When
> combined this inline-constants option with a hacky tweak to the compiler
> that omitted the constant definitions from the output, it made the release
> build 4KB smaller. I still need to figure out how to do that in a non-hacky
> way, but that kind of reduction is really promising.
>
> --
> Josh Tynjala
> Bowler Hat LLC 
>
>
> On Wed, Aug 7, 2019 at 2:47 PM Greg Dove  wrote:
>
> > Hey Josh, that sounds pretty cool. I'm not sure, but it might however be
> > duplicating some aspects of what GCC already does when it optimizes
> because
> > I expect it might do the same types of thing when it processes the @const
> > annotations in the debug code hints.
> > Also, for example, strings are only included once in the js-release build
> > if they are above a minimal length and then accessed by reference
> > irrespective of what inlining changes were made in the debug code output.
> > This ends up being similar conceptually to SWF's (and AMF) string tables
> I
> > think, although I did not check whether that changed since the ASC 2.0
> > inlining support.
> >
> > fyi I have a local compiler branch from FlexJS days where I have bindings
> > for (static) primitive constants being converted to initialization value
> > assignments with inline values instead of *actual bindings*, similar to
> > what I assume you are doing here, but as a way to avoid running binding
> > code for simple static constant bindings. I will revisit that at some
> point
> > soon, It might help improve startup speed for some people.
> >
> >
> >
> > On Thu, Aug 8, 2019 at 9:09 AM  wrote:
> >
> > > This is an automated email from the ASF dual-hosted git repository.
> > >
> > > joshtynjala pushed a commit to branch develop
> > > in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
> > >
> > >
> > > The following commit(s) were added to refs/heads/develop by this push:
> > >  new 61479f5  compiler-jx: added inline-constants compiler option
> for
> > > JS builds to optionally inline the values of primitive constants (like
> > > Number, String, Boolean, int, and uint) instead of referencing them.
> > > 61479f5 is described below
> > >
> > > commit 61479f5cce3c4ea582a1a6a859f1e74ef9256a9f
> > > Author: Josh Tynjala 
> > > AuthorDate: Wed Aug 7 13:52:59 2019 -0700
> > >
> > > compiler-jx: added inline-constants compiler option for JS builds
> to
> > > optionally inline the values of primitive constants (like Number,
> String,
> > > Boolean, int, and uint) instead of referencing them.
> > >
> > > Defaults to false. It may make sense to switch this to true in the
> > > future, but it's not stable yet.
> > >
> > > Does not yet skip unnecessary goog.require() calls, even though the
> > > classes may no longer be referenced. Figuring out how to do this should
> > > reduce the size of release builds.
> > > ---
> > >  .../internal/codegen/js/jx/IdentifierEmitter.java  | 37
> > > +-
> > >  .../driver/js/goog/JSGoogConfiguration.java| 19 +++
> > >  2 files changed, 55 insertions(+), 1 deletion(-)
> > >
> > > diff --git
> > >
> >
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/IdentifierEmitter.java
> > >
> >
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/IdentifierEmitter.java
> > > index 4d42069..f6363ea 100644
> > > ---
> > >
> >
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/IdentifierEmitter.java
> > > +++
> > >
> >
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/cod

Build failed in Jenkins: royale-asjs #2568

[Apache Royale CI Server]

See 


Changes:

[greg.dove] Porting remnants of manualtests/UnitTests to RoyaleUnit-compatible

[greg.dove] Migrating most manualtests/UnitTests tests to RoyaleUnit. Added 
[Ignore]

[greg.dove] Updates following class level @royalesuppressexport directive now

--
[...truncated 1.89 MB...]
[royaleunit]headless: [false]
[royaleunit]display: [99]
[royaleunit]localTrusted: [true]
[royaleunit]player: [html]
[royaleunit]command: [C:\Program Files 
(x86)\Google\Chrome\Application\chrome.exe]
[royaleunit]port: [1024]
[royaleunit]swf: 
[
[royaleunit]timeout: [9ms]
[royaleunit]toDir: 
[
[royaleunit] Setting up server process ...
[royaleunit] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
[royaleunit] SLF4J: Defaulting to no-operation (NOP) logger implementation
[royaleunit] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for 
further details.
[royaleunit] Entry 
[
 already available in local trust file at 
[C:\Users\apacheroyale\AppData\Roaming\Macromedia\Flash 
Player\#Security\FlashPlayerTrust\royaleUnit.cfg].
[royaleunit] Executing 'C:\Program Files 
(x86)\Google\Chrome\Application\chrome.exe' with arguments:
[royaleunit] 
'
[royaleunit] 
[royaleunit] The ' characters around the executable and arguments are
[royaleunit] not part of the command.
[royaleunit] 
[royaleunit] Starting server ...
[royaleunit] Waiting for client connection ...
[royaleunit] Client connected.
[royaleunit] Receiving data ...
[royaleunit] Sending acknowledgement to player to start sending test data ...
[royaleunit] 
[royaleunit] 
[royaleunit] Stopping server ...
[royaleunit] End of test data reached, sending acknowledgement to player ...
[royaleunit] Analyzing reports ...
[royaleunit] 
[royaleunit] Suite: flexUnitTests.DataGridColumnTest
[royaleunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.123 sec
[royaleunit] 
[royaleunit] Results :
[royaleunit] 
[royaleunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.123 sec
[royaleunit] 
[junitreport] Processing 

 to C:\Users\APACHE~1\AppData\Local\Temp\2\null2082556073
[junitreport] Loading stylesheet 
jar:file:/C:/apache/apache-ant-1.9.9/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 84ms
[junitreport] Deleting: C:\Users\APACHE~1\AppData\Local\Temp\2\null2082556073

main:

ReflectionTest:
 [echo] swc-date is 08/09/19 05:09 +

check-for-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

test:

clean:

compile:
 [echo] Compiling FlexUnitRoyaleApplication.swf
 [echo] ROYALE_HOME: 

 [echo] ROYALE_SWF_COMPILER_HOME: 

 [echo] playerglobal.version: 11.7
Trying to override old definition of task compc
Trying to override old definition of task mxmlc
[mxmlc] MXMLJSC
[mxmlc] -debug
[mxmlc] -compiler.targets=SWF
[mxmlc] +playerglobal.version=11.7
[mxmlc] +env.PLAYERGLOBAL_HOME=C:\adobe\flash
[mxmlc] 
+royalelib=
[mxmlc] 
-output=
[mxmlc] --
[mxmlc] 

[mxmlc] Loading configuration: 

[mxmlc] Loading configuration: 

[mxmlc] 
[mxmlc] scanning for overrides: IFlexInfo
[mxmlc] scanning for overrides: ApplicationBase
[mxmlc] scanning for overrides: IEventDispatcher
[mxmlc] scanning for o

Re: State of 0.9.6 release

[Carlos Rovira]

Ok Piotr, many thanks for summarizing all. Now all is more clear :)

El jue., 8 ago. 2019 a las 11:30, Piotr Zarzycki ()
escribió:

> Hi Carlos,
>
> I went trough 10 out of 15 steps without too much of a problem and I had to
> drop that stuff for other more urgent tasks. It is the matter of right now
> starting from scratch with latest changes from develop, cause it looks like
> process is quite easy to go trough. I have two issues on me right now more
> urgent than Royale release, once I get rid of them I will be able to get
> back with releasing Royale.
> One of the issue is minification problem which I have posted about.
>
> Thanks,
> Piotr
>
> czw., 8 sie 2019 o 11:26 Carlos Rovira 
> napisał(a):
>
> > Hi Piotr,
> >
> > I'm curious about what happen with your try to make the new release. I
> > thought you got it working successfully and was about to create the
> release
> > thread right? Or maybe you found some problem in the process?
> >
> > thanks
> >
> > --
> > Carlos Rovira
> > http://about.me/carlosrovira
> >
>
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> *
>


-- 
Carlos Rovira
http://about.me/carlosrovira

Re: [royale-compiler] branch develop updated: compiler-jx: added inline-constants compiler option for JS builds to optionally inline the values of primitive constants (like Number, String, Boolean, in

[Josh Tynjala]

My goal is to be able to completely omit classes from release builds when
their only purpose is to define a bunch of constants. Usually, you only
need a small number of the constants, so the rest of them bloat your app
for no good reason.

I made a test project with a class that defines 100 Number constants. When
combined this inline-constants option with a hacky tweak to the compiler
that omitted the constant definitions from the output, it made the release
build 4KB smaller. I still need to figure out how to do that in a non-hacky
way, but that kind of reduction is really promising.

--
Josh Tynjala
Bowler Hat LLC 


On Wed, Aug 7, 2019 at 2:47 PM Greg Dove  wrote:

> Hey Josh, that sounds pretty cool. I'm not sure, but it might however be
> duplicating some aspects of what GCC already does when it optimizes because
> I expect it might do the same types of thing when it processes the @const
> annotations in the debug code hints.
> Also, for example, strings are only included once in the js-release build
> if they are above a minimal length and then accessed by reference
> irrespective of what inlining changes were made in the debug code output.
> This ends up being similar conceptually to SWF's (and AMF) string tables I
> think, although I did not check whether that changed since the ASC 2.0
> inlining support.
>
> fyi I have a local compiler branch from FlexJS days where I have bindings
> for (static) primitive constants being converted to initialization value
> assignments with inline values instead of *actual bindings*, similar to
> what I assume you are doing here, but as a way to avoid running binding
> code for simple static constant bindings. I will revisit that at some point
> soon, It might help improve startup speed for some people.
>
>
>
> On Thu, Aug 8, 2019 at 9:09 AM  wrote:
>
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > joshtynjala pushed a commit to branch develop
> > in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
> >
> >
> > The following commit(s) were added to refs/heads/develop by this push:
> >  new 61479f5  compiler-jx: added inline-constants compiler option for
> > JS builds to optionally inline the values of primitive constants (like
> > Number, String, Boolean, int, and uint) instead of referencing them.
> > 61479f5 is described below
> >
> > commit 61479f5cce3c4ea582a1a6a859f1e74ef9256a9f
> > Author: Josh Tynjala 
> > AuthorDate: Wed Aug 7 13:52:59 2019 -0700
> >
> > compiler-jx: added inline-constants compiler option for JS builds to
> > optionally inline the values of primitive constants (like Number, String,
> > Boolean, int, and uint) instead of referencing them.
> >
> > Defaults to false. It may make sense to switch this to true in the
> > future, but it's not stable yet.
> >
> > Does not yet skip unnecessary goog.require() calls, even though the
> > classes may no longer be referenced. Figuring out how to do this should
> > reduce the size of release builds.
> > ---
> >  .../internal/codegen/js/jx/IdentifierEmitter.java  | 37
> > +-
> >  .../driver/js/goog/JSGoogConfiguration.java| 19 +++
> >  2 files changed, 55 insertions(+), 1 deletion(-)
> >
> > diff --git
> >
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/IdentifierEmitter.java
> >
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/IdentifierEmitter.java
> > index 4d42069..f6363ea 100644
> > ---
> >
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/IdentifierEmitter.java
> > +++
> >
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/IdentifierEmitter.java
> > @@ -19,9 +19,12 @@
> >
> >  package org.apache.royale.compiler.internal.codegen.js.jx;
> >
> > +import org.apache.royale.abc.ABCConstants;
> >  import org.apache.royale.abc.semantics.Namespace;
> >  import org.apache.royale.compiler.codegen.ISubEmitter;
> >  import org.apache.royale.compiler.codegen.js.IJSEmitter;
> > +import org.apache.royale.compiler.constants.IASLanguageConstants;
> > +import org.apache.royale.compiler.definitions.IConstantDefinition;
> >  import org.apache.royale.compiler.definitions.IDefinition;
> >  import org.apache.royale.compiler.definitions.IFunctionDefinition;
> >  import
> >
> org.apache.royale.compiler.definitions.IFunctionDefinition.FunctionClassification;
> > @@ -37,6 +40,7 @@ import
> > org.apache.royale.compiler.internal.codegen.js.goog.JSGoogEmitterTokens;
> >  import
> >
> org.apache.royale.compiler.internal.codegen.js.royale.JSRoyaleEmitterTokens;
> >  import
> org.apache.royale.compiler.internal.codegen.js.utils.EmitterUtils;
> >  import org.apache.royale.compiler.internal.definitions.*;
> > +import org.apache.royale.compiler.internal.projects.RoyaleJSProject;
> >  import org.apache.royale.compiler.internal.tree.as
> > .BinaryOperatorAssignmentNode;
> >  import org.apache.roya

Jenkins build is back to normal : royale-asjs_MXTests #1028

[Apache Royale CI Server]

See 

Re: Minification problem with latest build

[Piotr Zarzycki]

Hi Harbs,

If I build my code with: -js-dynamic-access-unknown-members=false I'm
getting in that line following code [1] - look into place around: a.
parentNode&&a.parentNode.royale_wrapper.

Having -js-dynamic-access-unknown-members=false - making an application
work.

By unminified do you mean to provide debug version of code ?

[1] https://paste.apache.org/rnmxg

Thanks,
Piotr

czw., 8 sie 2019 o 12:03 Harbs  napisał(a):

> N('org.apache.royale.events.getTargetWrapper',tP.If)
>
> tP.If is an alias to the package level function getTargetWrapper. My guess
> is that package level functions have an issue.
>
> Presumable, tP is org.apache.royale.events, which only makes sense if
> org.apache.royale.events would have been a class.
>
> What’s the un-minified output?
>
> > On Aug 8, 2019, at 12:20 PM, Piotr Zarzycki 
> wrote:
> >
> > Hi Guys,
> >
> > Yesterday for some reason our application started to failing in release
> > build. I have spend many hours to figure out where is the point of
> breakage
> > but I'm still not sure and what is the code in our app that it causes.
> > Here is the minified line of code [1]. Exception is saying:
> >
> > "TypeError: Cannot set property 'If' of undefined"
> >
> > So there is a variable "tP." which is undefined. Anyone understand for
> > example why there upper case "If" word?
> >
> > I'm using build [2]
> >
> > [1] https://paste.apache.org/l7iez
> > [2]
> >
> http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/3355/
> >
> > Thanks,
> > --
> >
> > Piotr Zarzycki
> >
> > Patreon: *https://www.patreon.com/piotrzarzycki
> > *
>
>

-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*

Re: Minification problem with latest build

[Greg Dove]

I suggest you double check that your google closure js lib is correctly
unzipped and is not missing parts or has empty folders for some parts. I
had an issue yesterday where I needed to do that manually, but I thought it
was 'just me'
fwiw I think your tP.If might simply be remapped version of:
org.apache.royale.events.getTargetWrapper

...in which case org.apache.royale.events could correspond to tP and is
maybe undefined when it should not be. Not sure... good luck, I will try to
investigate tomorrow local time if you still see issues.


On Thu, 8 Aug 2019, 21:20 Piotr Zarzycki,  wrote:

> Hi Guys,
>
> Yesterday for some reason our application started to failing in release
> build. I have spend many hours to figure out where is the point of breakage
> but I'm still not sure and what is the code in our app that it causes.
> Here is the minified line of code [1]. Exception is saying:
>
> "TypeError: Cannot set property 'If' of undefined"
>
> So there is a variable "tP." which is undefined. Anyone understand for
> example why there upper case "If" word?
>
> I'm using build [2]
>
> [1] https://paste.apache.org/l7iez
> [2]
>
> http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/3355/
>
> Thanks,
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> *
>

Re: Minification problem with latest build

[Harbs]

N('org.apache.royale.events.getTargetWrapper',tP.If)

tP.If is an alias to the package level function getTargetWrapper. My guess is 
that package level functions have an issue.

Presumable, tP is org.apache.royale.events, which only makes sense if 
org.apache.royale.events would have been a class.

What’s the un-minified output?

> On Aug 8, 2019, at 12:20 PM, Piotr Zarzycki  wrote:
> 
> Hi Guys,
> 
> Yesterday for some reason our application started to failing in release
> build. I have spend many hours to figure out where is the point of breakage
> but I'm still not sure and what is the code in our app that it causes.
> Here is the minified line of code [1]. Exception is saying:
> 
> "TypeError: Cannot set property 'If' of undefined"
> 
> So there is a variable "tP." which is undefined. Anyone understand for
> example why there upper case "If" word?
> 
> I'm using build [2]
> 
> [1] https://paste.apache.org/l7iez
> [2]
> http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/3355/
> 
> Thanks,
> -- 
> 
> Piotr Zarzycki
> 
> Patreon: *https://www.patreon.com/piotrzarzycki
> *

Re: State of 0.9.6 release

[Piotr Zarzycki]

Hi Carlos,

I went trough 10 out of 15 steps without too much of a problem and I had to
drop that stuff for other more urgent tasks. It is the matter of right now
starting from scratch with latest changes from develop, cause it looks like
process is quite easy to go trough. I have two issues on me right now more
urgent than Royale release, once I get rid of them I will be able to get
back with releasing Royale.
One of the issue is minification problem which I have posted about.

Thanks,
Piotr

czw., 8 sie 2019 o 11:26 Carlos Rovira  napisał(a):

> Hi Piotr,
>
> I'm curious about what happen with your try to make the new release. I
> thought you got it working successfully and was about to create the release
> thread right? Or maybe you found some problem in the process?
>
> thanks
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>


-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*

State of 0.9.6 release

[Carlos Rovira]

Hi Piotr,

I'm curious about what happen with your try to make the new release. I
thought you got it working successfully and was about to create the release
thread right? Or maybe you found some problem in the process?

thanks

-- 
Carlos Rovira
http://about.me/carlosrovira

Minification problem with latest build

[Piotr Zarzycki]

Hi Guys,

Yesterday for some reason our application started to failing in release
build. I have spend many hours to figure out where is the point of breakage
but I'm still not sure and what is the code in our app that it causes.
Here is the minified line of code [1]. Exception is saying:

"TypeError: Cannot set property 'If' of undefined"

So there is a variable "tP." which is undefined. Anyone understand for
example why there upper case "If" word?

I'm using build [2]

[1] https://paste.apache.org/l7iez
[2]
http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/3355/

Thanks,
-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*

Re: Royale Commercial Support Page (was: Fwd: AIR and Royale)

[Carlos Rovira]

Hi,

BowlerHat / Josh Tynjala entry was added to the list too :)

Best

Carlos

El mié., 7 ago. 2019 a las 21:43, Andrew Wetmore ()
escribió:

> That looks very good, with the list of providers above the qualifications
> for getting added to the list.
>
> On Wed, Aug 7, 2019 at 2:18 PM Yishay Weiss 
> wrote:
>
> > Good to hear Carlos, thanks.
> >
> >
> >
> > 
> > From: Carlos Rovira 
> > Sent: Wednesday, August 7, 2019 7:57:58 PM
> > To: dev@royale.apache.org 
> > Subject: Re: Royale Commercial Support Page (was: Fwd: AIR and Royale)
> >
> > Hi Piotr, Yshay,
> >
> > entry is now added and published :)
> >
> > https://royale.apache.org/royale-commercial-support/
> >
> >
> >
> > El mié., 7 ago. 2019 a las 8:07, Piotr Zarzycki (<
> > piotrzarzyck...@gmail.com>)
> > escribió:
> >
> > > Hi Carlos,
> > >
> > > Yishay send you logo off the list. Is it ok ?
> > >
> > > Thanks,
> > > Piotr
> > >
> > > pon., 5 sie 2019 o 11:32 Piotr Zarzycki 
> > > napisał(a):
> > >
> > > > Yes! I'm ok!
> > > >
> > > > Thanks for asking.
> > > >
> > > > pon., 5 sie 2019 o 11:13 Yishay Weiss 
> > > napisał(a):
> > > >
> > > >> Actually, please add a + before the phone number so it links to
> Skype.
> > > >>
> > > >>
> > > >>
> > > >> Piotr, are u ok with being added?
> > > >>
> > > >>
> > > >>
> > > >> 
> > > >> From: Yishay Weiss 
> > > >> Sent: Monday, August 5, 2019 12:09:40 PM
> > > >> To: dev@royale.apache.org 
> > > >> Subject: RE: Royale Commercial Support Page (was: Fwd: AIR and
> Royale)
> > > >>
> > > >> Looks good to me. Thanks.
> > > >>
> > > >>
> > > >>
> > > >> 
> > > >> From: Carlos Rovira 
> > > >> Sent: Monday, August 5, 2019 12:00:08 PM
> > > >> To: dev@royale.apache.org 
> > > >> Subject: Re: Royale Commercial Support Page (was: Fwd: AIR and
> Royale)
> > > >>
> > > >> Yeah! sorry :)
> > > >>
> > > >> https://royale.codeoscopic.com/royale-commercial-support/
> > > >>
> > > >> El lun., 5 ago. 2019 a las 10:49, Yishay Weiss (<
> > yishayj...@hotmail.com
> > > >)
> > > >> escribió:
> > > >>
> > > >> >
> > > >> > >ok, you can check here the addition before publish.
> > > >> >
> > > >> > Was there supposed to be a link?
> > > >> >
> > > >> >
> > > >> >
> > > >> >
> > > >> > El lun., 5 ago. 2019 a las 10:10, Yishay Weiss (<
> > > yishayj...@hotmail.com
> > > >> >)
> > > >> > escribió:
> > > >> >
> > > >> > > I’ll try to find one. Thanks!
> > > >> > >
> > > >> > >
> > > >> > >
> > > >> > > 
> > > >> > > From: Carlos Rovira 
> > > >> > > Sent: Monday, August 5, 2019 10:59:51 AM
> > > >> > > To: dev@royale.apache.org 
> > > >> > > Subject: Re: Royale Commercial Support Page (was: Fwd: AIR and
> > > Royale)
> > > >> > >
> > > >> > > Hi Yishay,
> > > >> > >
> > > >> > > I'm adding it. Could you provide a better logo?
> > > >> > > (LOGO (if applies) (PNG, background transparent, good resolution
> > (at
> > > >> > least
> > > >> > > above 800px))
> > > >> > > thanks
> > > >> > >
> > > >> > > El lun., 5 ago. 2019 a las 9:23, Yishay Weiss (<
> > > >> yishayj...@hotmail.com>)
> > > >> > > escribió:
> > > >> > >
> > > >> > > > Apache Royale contributor(s): Piotr Zarzycki (committer and
> PMC
> > > >> > member),
> > > >> > > > Yishay Weiss (committer and PMC member).
> > > >> > > >
> > > >> > > > 
> > > >> > > > From: Yishay Weiss
> > > >> > > > Sent: Monday, August 5, 2019 10:17:52 AM
> > > >> > > > To: dev@royale.apache.org 
> > > >> > > > Subject: RE: Royale Commercial Support Page (was: Fwd: AIR and
> > > >> Royale)
> > > >> > > >
> > > >> > > >
> > > >> > > > Carlos, please add Prominic as well. Thanks.
> > > >> > > >
> > > >> > > >
> > > >> > > >
> > > >> > > > Name: Prominic.NET
> > > >> > > >
> > > >> > > >
> > > >> > > >
> > > >> > > > Short Description: Prominic.NET is a home-grown, US-based
> > hosting
> > > >> > > services
> > > >> > > > provider, providing services and support to businesses all
> over
> > > the
> > > >> > > world.
> > > >> > > > Among its products is the Moonshine IDE which is targeted
> > > >> specifically
> > > >> > at
> > > >> > > > Apache Flex and Apache Royale. Our team includes Royale
> > > specialists
> > > >> > with
> > > >> > > > experience in porting Apache Flex applications to Apache
> Royale.
> > > >> > > >
> > > >> > > >
> > > >> > > >
> > > >> > > > Logo: https://1drv.ms/u/s!AgH-0pVQ5zPPxAevfQfnGMANlj0b
> > > >> > > >
> > > >> > > >
> > > >> > > >
> > > >> > > > Website URL: https://prominic.net/
> > > >> > > >
> > > >> > > >
> > > >> > > >
> > > >> > > > Contact Person: Yishay Weiss
> > > >> > > >
> > > >> > > >
> > > >> > > >
> > > >> > > > Contact Email: yishayj...@hotmail.com > > yishayj...@hotmail.com
> > > >> >
> > > >> > > >
> > > >> > > >
> > > >> > > >
> > > >> > > > Contact Phone: 972524512113
> > > >> > > >
> > > >> > > >
> > > >> > > >
> > > >> > > > 
> > > >> > > > From: Andrew Wetmore 
>