Re: Testing the npm install error fixes

2019-09-09 Thread Alex Harui
I tried to remove node and npm and re-install it without sudo via homebrew.

I think I got the same results as Carlos.  FWIW, there is no @apache_royale 
folder in node_modules.

~$ npm i @apache-royale/royale-js-swf@0.9.6-beta0 -g
/usr/local/bin/asjscompc -> 
/usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asjscompcnpm
/usr/local/bin/mxmlc -> 
/usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/mxmlcnpm
/usr/local/bin/asjsc -> 
/usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asjscnpm
/usr/local/bin/compc -> 
/usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/compcnpm
/usr/local/bin/asnodec -> 
/usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asnodecnpm
/usr/local/bin/externc -> 
/usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/externcnpm

> @apache-royale/royale-js-swf@0.9.6-beta0 postinstall 
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf
> node dependencies/download_dependencies.js

internal/modules/cjs/loader.js:775
throw err;
^

Error: Cannot find module 
'/usr/local/lib/node_modules/@apache-royale/royale-js-swf/dependencies/download_dependencies.js'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:772:15)
at Function.Module._load (internal/modules/cjs/loader.js:677:27)
at Function.Module.runMain (internal/modules/cjs/loader.js:999:10)
at internal/main/run_main_module.js:17:11 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @apache-royale/royale-js-swf@0.9.6-beta0 postinstall: `node 
dependencies/download_dependencies.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @apache-royale/royale-js-swf@0.9.6-beta0 postinstall 
script.
npm ERR! This is probably not a problem with npm. There is likely additional 
logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! /Users/aharui/.npm/_logs/2019-09-10T05_01_13_653Z-debug.log



On 9/5/19, 9:32 AM, "OmPrakash Muppirala"  wrote:

If you have to use sudo that usually means that your node/npm is not setup
correctly.

Some more info here :

https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmedium.com%2F%40ExplosionPills%2Fdont-use-sudo-with-npm-still-66e609f5f92data=02%7C01%7Caharui%40adobe.com%7C94ba7a787a2d4765ca3e08d7321eae85%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637032979678297877sdata=shG6aUIsl96Nv7fKvoHPds6OdzlEoWTzVzxaKlwtesY%3Dreserved=0


https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstackoverflow.com%2Fa%2F18296178data=02%7C01%7Caharui%40adobe.com%7C94ba7a787a2d4765ca3e08d7321eae85%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637032979678297877sdata=o4KtwJ5zaQcsNmxqLb%2Bj%2FJ5phxS9F5UhqMrnVOvw%2Bt0%3Dreserved=0

That said, this issue is not related to sudo or otherwise.

But it is a good idea to not sudo anything related to npm.  For instance,
our installation scripts downloads and does a bunch of things during the
installation.  Imagine allowing a random script sudo access to your
computer.

Thanks,
Om

On Thu, Sep 5, 2019, 9:00 AM Alex Harui  wrote:

> Pretty sure if you use -g on MacOS you need sudo.  However, I don't think
> that's the issue here.
> I think Carlos should post his:
> - dependencies/download_dependencies.js`
> - /Users/carlosrovira/.npm/_logs/2019-09-05T09_39_50_359Z-debug.log
>
> HTH,
> -Alex
>
> On 9/5/19, 7:28 AM, "OmPrakash Muppirala"  wrote:
>
> And oh, what is your node version?
>
> On Thu, Sep 5, 2019, 7:27 AM OmPrakash Muppirala  >
> wrote:
>
> > We should never have to install any npm package with sudo.
> >
> > I will dig deeper into this and see what I can do.
> >
> > Thanks for testing!
> >
> > Om
> >
> >
> > On Thu, Sep 5, 2019, 2:41 AM Carlos Rovira 
> > wrote:
> >
> >> Thanks Harbs,
> >> that seems not to fix the problem:
> >>
> >> macbookpro:~ carlosrovira$ sudo npm i
> >> @apache-royale/royale-js-swf@0.9.6-beta0 -g
> >>
> >> Password:
> >>
> >> /usr/local/bin/asjsc ->
> >>
> >>
> 
/usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asjscnpm
> >>
> >> /usr/local/bin/asjscompc ->
> >>
> >>
> 
/usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asjscompcnpm
> >>
> >> /usr/local/bin/mxmlc ->
> >>
> >>
> 
/usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/mxmlcnpm
> >>
> >> /usr/local/bin/asnodec ->
> >>
> >>
> 

Re: Discuss of release steps preparation

2019-09-09 Thread Piotr Zarzycki
Ok I see [1] - I will try follow this and I will try add instruction what
actually to do next, cause removing tag is probably not enough we need to
perform some steps.

[1]
https://github.com/apache/royale-asjs/wiki/Release-Manager-Notes#fixing-an-rc

wt., 10 wrz 2019 o 07:16 Piotr Zarzycki 
napisał(a):

> What I understand now is that since I have updated release branches I need
> to perform maven artifacts builds, but not only - tag for RC1 should be
> changed as well. Probably I need to start perform for each repository step
> which creates for me tag, but before this is happening I need to remove
> existing one. Am I right?
>
> wt., 10 wrz 2019 o 07:00 Piotr Zarzycki 
> napisał(a):
>
>> Hi Alex,
>>
>> Ok I have updated each branches with newest changes from develop by
>> cherry pickup. What actually now ? Should I perform without reverting
>> anything ? [1] - I will try that today - it shouldn't break anything.
>>
>> [1]
>> https://github.com/apache/royale-asjs/wiki/Release-Steps-Jobs-On-Jenkins#fail-and-revert
>>
>>
>> Thanks,
>> Piotr
>>
>> sob., 7 wrz 2019 o 17:51 Alex Harui 
>> napisał(a):
>>
>>> Hi Piotr,
>>>
>>> Sure, time limitations may affect how much "development" you can do, but
>>> consider that if everyone ends up taking the same approach, then every
>>> future RM is going to spend time running into these issues, or make
>>> mistakes manually uploading the artifacts and cause people to spend time
>>> examining more than one release candidate.  This is the key difference that
>>> I am pointing out.  I've definitely seen you work through tough problems,
>>> but most coding issues don't have as much impact on the others on the team.
>>>
>>> There is no one right answer to how much sacrifice you should make for
>>> the project, but I asked several times for console output and never got
>>> it.  It might have been nice for you to report how long these steps took on
>>> your Windows computer so future RM's could plan ahead or we could
>>> investigate optimizations or breaking steps into other pieces.  Now the
>>> next RM will have the responsibility for experiencing these long builds and
>>> sharing that information.
>>>
>>> Regarding the current RC, I will try it later today, but I agree with
>>> Andrew Wetmore that we need to have current RELEASE_NOTES, so this RC
>>> should not be the one released, but I will run other checks on it to see if
>>> there are other issues.  Andrew's proposal for the release notes sounds
>>> good to me so he or you should commit it to the release branch along with
>>> the link I used in prior release notes that point to our wiki.  That way we
>>> can note other things later.
>>>
>>> For sure, thank you for the time and effort to get this far.
>>>
>>> -Alex
>>>
>>> On 9/7/19, 12:28 AM, "Piotr Zarzycki" 
>>> wrote:
>>>
>>> Hi Alex,
>>>
>>> That is only partially true what you are saying. Cause I'm
>>> definitely not
>>> the person, developer who when reaching some wall do not try to
>>> resolve it
>>> on it's own - Not that is not me.
>>>
>>> However in case of Royale release it's partially true, but let me
>>> explain
>>> why I asked first rather fix and ask:
>>>
>>> Building Royale framework on Windows is extremely long - and this is
>>> not
>>> limitation of my PC - I'm not the only one who experiencing such
>>> issue. You
>>> can definitely imagine that adding one line of echo and rebuild
>>> framework
>>> using releasesteps.xml can be challenge. - waiting 50 minutes. -
>>> Yeah I can
>>> do other stuff during that time, but it is not always possible.
>>>
>>> When I switched to Mac - all those problems simply gone. No hang on
>>> some
>>> files, building is two times faster, uploading working. - No problem
>>> at
>>> all.
>>>
>>> I simply wanted to count on people who are here, without hesitation
>>> ask for
>>> help even if I'm in a user mode - I'm doing that very rare.
>>>
>>> To all of you who are seeing now VOTE thread - please take some time
>>> and
>>> start voting, cause we finally have what we are trying to achieve
>>> for so
>>> many months.
>>>
>>> Thanks,
>>> Piotr
>>>
>>> sob., 7 wrz 2019 o 01:14 Alex Harui 
>>> napisał(a):
>>>
>>> > Those of you in favor of debugging the automation later must
>>> volunteer to
>>> > be the next RMs and do the debugging.
>>> >
>>> > Piotr, I'm sorry this effort took longer than expected, but IMO,
>>> that's
>>> > because I apparently could not convince you to take a developer
>>> instead of
>>> > user mindset.  By guessing at solutions and not providing console
>>> output
>>> > for others to help with or adding diagnostic output to the
>>> scripts, several
>>> > of your attempts failed which took a lot of your time.  I'm pretty
>>> sure I
>>> > said earlier that the release process is not a product developed
>>> and
>>> > maintained by me.  We need other people to be able to maintain and

Re: Discuss of release steps preparation

2019-09-09 Thread Piotr Zarzycki
What I understand now is that since I have updated release branches I need
to perform maven artifacts builds, but not only - tag for RC1 should be
changed as well. Probably I need to start perform for each repository step
which creates for me tag, but before this is happening I need to remove
existing one. Am I right?

wt., 10 wrz 2019 o 07:00 Piotr Zarzycki 
napisał(a):

> Hi Alex,
>
> Ok I have updated each branches with newest changes from develop by cherry
> pickup. What actually now ? Should I perform without reverting anything ?
> [1] - I will try that today - it shouldn't break anything.
>
> [1]
> https://github.com/apache/royale-asjs/wiki/Release-Steps-Jobs-On-Jenkins#fail-and-revert
>
>
> Thanks,
> Piotr
>
> sob., 7 wrz 2019 o 17:51 Alex Harui  napisał(a):
>
>> Hi Piotr,
>>
>> Sure, time limitations may affect how much "development" you can do, but
>> consider that if everyone ends up taking the same approach, then every
>> future RM is going to spend time running into these issues, or make
>> mistakes manually uploading the artifacts and cause people to spend time
>> examining more than one release candidate.  This is the key difference that
>> I am pointing out.  I've definitely seen you work through tough problems,
>> but most coding issues don't have as much impact on the others on the team.
>>
>> There is no one right answer to how much sacrifice you should make for
>> the project, but I asked several times for console output and never got
>> it.  It might have been nice for you to report how long these steps took on
>> your Windows computer so future RM's could plan ahead or we could
>> investigate optimizations or breaking steps into other pieces.  Now the
>> next RM will have the responsibility for experiencing these long builds and
>> sharing that information.
>>
>> Regarding the current RC, I will try it later today, but I agree with
>> Andrew Wetmore that we need to have current RELEASE_NOTES, so this RC
>> should not be the one released, but I will run other checks on it to see if
>> there are other issues.  Andrew's proposal for the release notes sounds
>> good to me so he or you should commit it to the release branch along with
>> the link I used in prior release notes that point to our wiki.  That way we
>> can note other things later.
>>
>> For sure, thank you for the time and effort to get this far.
>>
>> -Alex
>>
>> On 9/7/19, 12:28 AM, "Piotr Zarzycki"  wrote:
>>
>> Hi Alex,
>>
>> That is only partially true what you are saying. Cause I'm definitely
>> not
>> the person, developer who when reaching some wall do not try to
>> resolve it
>> on it's own - Not that is not me.
>>
>> However in case of Royale release it's partially true, but let me
>> explain
>> why I asked first rather fix and ask:
>>
>> Building Royale framework on Windows is extremely long - and this is
>> not
>> limitation of my PC - I'm not the only one who experiencing such
>> issue. You
>> can definitely imagine that adding one line of echo and rebuild
>> framework
>> using releasesteps.xml can be challenge. - waiting 50 minutes. - Yeah
>> I can
>> do other stuff during that time, but it is not always possible.
>>
>> When I switched to Mac - all those problems simply gone. No hang on
>> some
>> files, building is two times faster, uploading working. - No problem
>> at
>> all.
>>
>> I simply wanted to count on people who are here, without hesitation
>> ask for
>> help even if I'm in a user mode - I'm doing that very rare.
>>
>> To all of you who are seeing now VOTE thread - please take some time
>> and
>> start voting, cause we finally have what we are trying to achieve for
>> so
>> many months.
>>
>> Thanks,
>> Piotr
>>
>> sob., 7 wrz 2019 o 01:14 Alex Harui 
>> napisał(a):
>>
>> > Those of you in favor of debugging the automation later must
>> volunteer to
>> > be the next RMs and do the debugging.
>> >
>> > Piotr, I'm sorry this effort took longer than expected, but IMO,
>> that's
>> > because I apparently could not convince you to take a developer
>> instead of
>> > user mindset.  By guessing at solutions and not providing console
>> output
>> > for others to help with or adding diagnostic output to the scripts,
>> several
>> > of your attempts failed which took a lot of your time.  I'm pretty
>> sure I
>> > said earlier that the release process is not a product developed and
>> > maintained by me.  We need other people to be able to maintain and
>> debug
>> > Maven and Ant scripts.
>> >
>> > Similarly, I have not, nor has anyone else, tried a bunch of
>> different
>> > runtime configurations.  I don't know what would happen if you use a
>> > different console window for each step.  I don't think the previous
>> step
>> > leaves environment variables for the next step, but I can't be sure
>> of
>> > that.  But the steps do set up files and folders to be 

Discuss of release steps preparation

2019-09-09 Thread Piotr Zarzycki
Hi Alex,

Ok I have updated each branches with newest changes from develop by cherry
pickup. What actually now ? Should I perform without reverting anything ?
[1] - I will try that today - it shouldn't break anything.

[1]
https://github.com/apache/royale-asjs/wiki/Release-Steps-Jobs-On-Jenkins#fail-and-revert


Thanks,
Piotr

sob., 7 wrz 2019 o 17:51 Alex Harui  napisał(a):

> Hi Piotr,
>
> Sure, time limitations may affect how much "development" you can do, but
> consider that if everyone ends up taking the same approach, then every
> future RM is going to spend time running into these issues, or make
> mistakes manually uploading the artifacts and cause people to spend time
> examining more than one release candidate.  This is the key difference that
> I am pointing out.  I've definitely seen you work through tough problems,
> but most coding issues don't have as much impact on the others on the team.
>
> There is no one right answer to how much sacrifice you should make for the
> project, but I asked several times for console output and never got it.  It
> might have been nice for you to report how long these steps took on your
> Windows computer so future RM's could plan ahead or we could investigate
> optimizations or breaking steps into other pieces.  Now the next RM will
> have the responsibility for experiencing these long builds and sharing that
> information.
>
> Regarding the current RC, I will try it later today, but I agree with
> Andrew Wetmore that we need to have current RELEASE_NOTES, so this RC
> should not be the one released, but I will run other checks on it to see if
> there are other issues.  Andrew's proposal for the release notes sounds
> good to me so he or you should commit it to the release branch along with
> the link I used in prior release notes that point to our wiki.  That way we
> can note other things later.
>
> For sure, thank you for the time and effort to get this far.
>
> -Alex
>
> On 9/7/19, 12:28 AM, "Piotr Zarzycki"  wrote:
>
> Hi Alex,
>
> That is only partially true what you are saying. Cause I'm definitely
> not
> the person, developer who when reaching some wall do not try to
> resolve it
> on it's own - Not that is not me.
>
> However in case of Royale release it's partially true, but let me
> explain
> why I asked first rather fix and ask:
>
> Building Royale framework on Windows is extremely long - and this is
> not
> limitation of my PC - I'm not the only one who experiencing such
> issue. You
> can definitely imagine that adding one line of echo and rebuild
> framework
> using releasesteps.xml can be challenge. - waiting 50 minutes. - Yeah
> I can
> do other stuff during that time, but it is not always possible.
>
> When I switched to Mac - all those problems simply gone. No hang on
> some
> files, building is two times faster, uploading working. - No problem at
> all.
>
> I simply wanted to count on people who are here, without hesitation
> ask for
> help even if I'm in a user mode - I'm doing that very rare.
>
> To all of you who are seeing now VOTE thread - please take some time
> and
> start voting, cause we finally have what we are trying to achieve for
> so
> many months.
>
> Thanks,
> Piotr
>
> sob., 7 wrz 2019 o 01:14 Alex Harui 
> napisał(a):
>
> > Those of you in favor of debugging the automation later must
> volunteer to
> > be the next RMs and do the debugging.
> >
> > Piotr, I'm sorry this effort took longer than expected, but IMO,
> that's
> > because I apparently could not convince you to take a developer
> instead of
> > user mindset.  By guessing at solutions and not providing console
> output
> > for others to help with or adding diagnostic output to the scripts,
> several
> > of your attempts failed which took a lot of your time.  I'm pretty
> sure I
> > said earlier that the release process is not a product developed and
> > maintained by me.  We need other people to be able to maintain and
> debug
> > Maven and Ant scripts.
> >
> > Similarly, I have not, nor has anyone else, tried a bunch of
> different
> > runtime configurations.  I don't know what would happen if you use a
> > different console window for each step.  I don't think the previous
> step
> > leaves environment variables for the next step, but I can't be sure
> of
> > that.  But the steps do set up files and folders to be used by the
> next
> > steps.  So if a working copy is not found at the folder specified,
> the
> > earlier step that tried to establish that working copy needs to be
> examined.
> >
> > Should this release get the votes to go out, the releasecandidate.xml
> > scripts have steps that merge branches and bump version numbers for
> Ant
> > (Maven should already be bumped).  Personally, I think we need to
> have some
> > sort of updated RELEASE_NOTES file.
> >
> > 

Build failed in Jenkins: royale-asjs_jsonly #3523

2019-09-09 Thread Apache Royale CI Server
See 


--
[...truncated 1.70 MB...]
 [java] ^
 [java] 
 [java] 3.9635748 seconds
 [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx1g 
 [java] Java Result: 2

main:

basictests-compile-java:
   [delete] Deleting directory 

[mkdir] Created dir: 

[javac] 
:1303:
 warning: 'includeantruntime' was not set, defaulting to 
build.sysclasspath=last; set to false for repeatable builds
[javac] Compiling 12 source files to 

[javac] Note: 

 uses or overrides a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.

basictests:

basictests-mustella:

basictests-compile-js:
 [echo] ROYALE_HOME: 

 [echo] ROYALE_COMPILER_HOME: 

 [echo] GOOG_HOME: 

[mxmlc] MXMLJSC
[mxmlc] 
-sdk-js-lib=
[mxmlc] -compiler.debug=true
[mxmlc] 
+royalelib=
[mxmlc] 
-closure-lib=
[mxmlc] -compiler.targets=JSRoyale
[mxmlc] 
-compiler.library-path=
[mxmlc] 
-compiler.js-external-library-path=
[mxmlc] 
-compiler.js-library-path=
[mxmlc] 
-compiler.js-library-path+=
[mxmlc] --
[mxmlc] 

[mxmlc] 

 Warning: The definition goog.events.BrowserEvent depended on by 
org.apache.royale.events.BrowserEvent in the SWC 

 could not be found
[mxmlc] 
[mxmlc] 
[mxmlc] 

 Warning: The definition goog.events.Event depended on by 
org.apache.royale.events.Event in the SWC 

 could not be found
[mxmlc] 
[mxmlc] 
[mxmlc] 

 Warning: The definition goog.bind depended on by 
org.apache.royale.utils.MXMLDataInterpreter in the SWC 

 could not be found
[mxmlc] 
[mxmlc] 
[mxmlc] 

 Warning: The definition goog.events.BrowserEvent depended on by 
org.apache.royale.events.IBrowserEvent in the SWC 

 could not be found
[mxmlc] 
[mxmlc] 
[mxmlc] 

 Warning: The definition goog.events depended on by 
org.apache.royale.events.EventDispatcher in the SWC 

 could not be found
[mxmlc] 
[mxmlc] 
[mxmlc] 

 

Build failed in Jenkins: royale-asjs_MXTests #1137

2019-09-09 Thread Apache Royale CI Server
See 


--
[...truncated 966.98 KB...]
[mxmlc] scanning for overrides: ObjectUtil
[mxmlc] scanning for overrides: SolidBorderUtil
[mxmlc] scanning for overrides: StringTrimmer
[mxmlc] scanning for overrides: StringUtil
[mxmlc] scanning for overrides: Timer
[mxmlc] scanning for overrides: UIUtils
[mxmlc] scanning for overrides: Effect
[mxmlc] scanning for overrides: Transition
[mxmlc] scanning for overrides: IFill
[mxmlc] scanning for overrides: SolidColor
[mxmlc] scanning for overrides: IExternalizable
[mxmlc] scanning for overrides: Proxy
[mxmlc] scanning for overrides: CursorBookmark
[mxmlc] scanning for overrides: ICollectionView
[mxmlc] scanning for overrides: IList
[mxmlc] scanning for overrides: IViewCursor
[mxmlc] scanning for overrides: ListCollectionView
[mxmlc] scanning for overrides: ListCollectionViewCursor
[mxmlc] scanning for overrides: ListCollectionViewBookmark
[mxmlc] scanning for overrides: ArrayCollection
[mxmlc] scanning for overrides: ArrayList
[mxmlc] scanning for overrides: XMLListCollection
[mxmlc] scanning for overrides: CanvasLayout
[mxmlc] scanning for overrides: Flex
[mxmlc] scanning for overrides: BoxDirection
[mxmlc] scanning for overrides: HBox
[mxmlc] scanning for overrides: PanelTitleBar
[mxmlc] scanning for overrides: DataGridColumn
[mxmlc] scanning for overrides: Button
[mxmlc] scanning for overrides: ISelectable
[mxmlc] scanning for overrides: CheckBox
[mxmlc] scanning for overrides: IFocusManagerComponent
[mxmlc] scanning for overrides: ComboBase
[mxmlc] scanning for overrides: ComboBox
[mxmlc] scanning for overrides: ScrollControlBase
[mxmlc] scanning for overrides: ListBase
[mxmlc] scanning for overrides: DataGrid
[mxmlc] scanning for overrides: DateField
[mxmlc] scanning for overrides: Label
[mxmlc] scanning for overrides: List
[mxmlc] scanning for overrides: MenuBar
[mxmlc] scanning for overrides: NumericStepper
[mxmlc] scanning for overrides: RadioButton
[mxmlc] scanning for overrides: RadioButtonGroup
[mxmlc] scanning for overrides: TextArea
[mxmlc] scanning for overrides: ITextInput
[mxmlc] scanning for overrides: TextInput
[mxmlc] scanning for overrides: ITextFieldFactory
[mxmlc] scanning for overrides: Singleton
[mxmlc] scanning for overrides: ItemClickEvent
[mxmlc] scanning for overrides: ListEvent
[mxmlc] scanning for overrides: MenuEvent
[mxmlc] scanning for overrides: MouseEvent
[mxmlc] scanning for overrides: PropertyChangeEventKind
[mxmlc] scanning for overrides: Matrix
[mxmlc] scanning for overrides: Matrix
[mxmlc] scanning for overrides: IFocusManagerComplexComponent
[mxmlc] scanning for overrides: IFocusManagerGroup
[mxmlc] scanning for overrides: IResourceBundle
[mxmlc] scanning for overrides: ResourceManagerImpl
[mxmlc] scanning for overrides: ResourceModuleInfo
[mxmlc] scanning for overrides: ResourceEventDispatcher
[mxmlc] scanning for overrides: ResourceBundleProxy
[mxmlc] scanning for overrides: GroupBase
[mxmlc] scanning for overrides: SkinnableComponent
[mxmlc] scanning for overrides: ButtonBase
[mxmlc] scanning for overrides: Button
[mxmlc] scanning for overrides: ErrorArray
[mxmlc] scanning for overrides: RunCodeEvent
[mxmlc] scanning for overrides: PasswordInputBead
[mxmlc] scanning for overrides: ITileLayout
[mxmlc] scanning for overrides: TileLayout
[mxmlc] scanning for overrides: LocaleUtils
[mxmlc] scanning for overrides: StringPadder
[mxmlc] scanning for overrides: UIDUtil
[mxmlc] scanning for overrides: IStroke
[mxmlc] scanning for overrides: CursorError
[mxmlc] scanning for overrides: SortError
[mxmlc] scanning for overrides: ISort
[mxmlc] scanning for overrides: Sort
[mxmlc] scanning for overrides: IXMLNotifiable
[mxmlc] scanning for overrides: XMLListAdapter
[mxmlc] scanning for overrides: FlexChildInfo
[mxmlc] scanning for overrides: BaseListData
[mxmlc] scanning for overrides: IFactory
[mxmlc] scanning for overrides: IUITextField
[mxmlc] scanning for overrides: UITextField
[mxmlc] scanning for overrides: CollectionEvent
[mxmlc] scanning for overrides: CollectionEventKind
[mxmlc] scanning for overrides: LocaleSorter
[mxmlc] scanning for overrides: LocaleID
[mxmlc] scanning for overrides: LocaleRegistry
[mxmlc] scanning for overrides: ResourceBundle
[mxmlc] scanning for overrides: ArrayUtil
[mxmlc] scanning for overrides: StringUtil
[mxmlc] scanning for overrides: UIDUtil
[mxmlc] scanning for overrides: DataGroup
[mxmlc] scanning for overrides: LayoutBase
[mxmlc] scanning for overrides: BasicLayout

Re: [royale-compiler] branch develop updated: MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true

2019-09-09 Thread Alex Harui
I could be wrong, but I think for Eclipse and maybe some other IDEs, some files 
are necessary to get a project up and running and others are generated by use 
of the IDE.

For example, I don't think I've seen a .factorypath class before, but the 
.project (and maybe the .classpath) files are required for importing a project 
into an Eclipse workspace.  I believe that we don't want to remove files 
required for importing, especially if we can format those files for universal 
use so they don't contain some committer's file/folder structure.  But I think 
we can still add those files to .gitignore so changes are not accidentally 
commited.  But to add a new one, there are some git options to force them to be 
committed.  So we could adopt that strategy if we want to.  Either way there is 
some manual steps to keep certain files as templates for importing.

Of course, I could be wrong...
-Alex

On 9/9/19, 10:03 AM, "Carlos Rovira"  wrote:

Hi,

I notice all that files too from Eclips, can we remove all that files and
add all config files to .gitignore.
In doing that you ensure that your config files are the ones you use and
you don't get any other one from our repo.
I think we removed all other IDE files (VScode), specially the ones that
are tied to user paths.
Moonshine are as well in, but don't know right now if are tied to user
paths or not.



El lun., 9 sept. 2019 a las 18:04, Josh Tynjala 
()
escribió:

> Maybe. It's worth mentioning that VSCode's Java support is based on
> Eclipse, so it uses the same project file formats as Eclipse. We have
> .classpath and .project files committed in the repo, presumably to make it
> easy to import the compiler projects into Eclipse. However, they're
> constantly in a modified state in my local copy because VSCode overwrites
> them. I think that VSCode re-configures the project based on the Maven
> pom.xml file, but the repo's versions don't know about Maven.
>
> Even if we add .factorypath to .gitignore, both .classpath and .project 
are
> at risk of being accidentally committed too. It wouldn't really make a 
huge
> difference for me to ignore this file because I will still need to take
> extra care before committing. It just happened to slip through this time.
>
> --
> Josh Tynjala
> Bowler Hat LLC 

>
>
> On Mon, Sep 9, 2019 at 8:27 AM Alex Harui 
> wrote:
>
> > Should it be added to .gitignore so it doesn't get committed?
> >
> > On 9/9/19, 6:58 AM, "Josh Tynjala"  wrote:
> >
> > I removed this file. Should be gone on both develop and release/
> 0.9.6.
> >
> > - Josh
> >
> >
> > On Mon, Sep 9, 2019 at 6:39 AM Josh Tynjala <
> joshtynj...@bowlerhat.dev
> > >
> > wrote:
> >
> > > It's a project file created by VSCode. I didn't realize that I
> > > accidentally added it. It can be removed from the repo.
> > >
> > > - Josh
> > >
> > > On Saturday, September 7, 2019, Alex Harui
>  > >
> > > wrote:
> > > > Josh,
> > > >
> > > > What is the .factorypath file?  It is in the release package.
> > Should it
> > > even be in the repo?
> > > >
> > > > -Alex
> > > >
> > > > On 8/12/19, 11:12 AM, "joshtynj...@apache.org" <
> > joshtynj...@apache.org>
> > > wrote:
> > > >
> > > > This is an automated email from the ASF dual-hosted git
> > repository.
> > > >
> > > > joshtynjala pushed a commit to branch develop
> > > > in repository
> > >
> >
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.gitdata=02%7C01%7Caharui%40adobe.com%7C1466ad2654ad4c34bf6108d73547b02f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637036454346349810sdata=klHqmmUArzXIr0Mzn8MmBNqYuSmFNT9I4amLSYJXoYo%3Dreserved=0
> > > >
> > > >
> > > > The following commit(s) were added to refs/heads/develop by
> > this
> > > push:
> > > >  new f4f9898  MemberAccessEmitter: fixed issue where
> > > fully-qualified names were emitted as dynamic access with
> > > -js-dynamic-access-unknown-members=true
> > > > f4f9898 is described below
> > > >
> > > > commit f4f9898ad6f94c903615db5bfae691bfaac4a5f3
> > > > Author: Josh Tynjala 
> > > > AuthorDate: Mon Aug 12 11:12:34 2019 -0700
> > > >
> > > > 

Re: [DISCUSS] Release Apache Royale 0.9.6 RC1

2019-09-09 Thread Alex Harui
I pushed some changes that should prevent packaging the output in the src/test 
folders, and changes to the compiler repo to package royaleunit-ant-tasks.

I also fixed a bunch of issues running a build in js-only mode.

I also pushed Andrew's suggested release_notes changes.

HTH,
-Alex

On 9/8/19, 12:47 AM, "Alex Harui"  wrote:

I ran the ApproveRoyale script.  It is a good idea for the RM to run it 
before sending out the vote emails.  The script found:

Generated output is in the binary package in these folders and shouldn't 
be, IMO.  Some clean step is missing somewhere.
BasicJS/src/test
CoreJS/src/test
NetworkJS/src/test
ReflectionJS/src/test
RoyaleUnitJS/src/test
XMLJS/src/test

This file was found by rat.  I don't think it should be in the packages or 
our repo.
.factorypath

I pushed to the release branch some changes to the README URLs for 
playerglobal
The README still says to use sudo on Mac for NPM.  I didn't have time to 
confirm.  Om, if you really think it shouldn't be in there go remove it.

I also pushed changes to the NOTICE file copyright years

The build failed because at least this one folder is missing from the 
package.  The packaging scripts may need to be changed to pick up new folders.
royale-compiler/royaleunit-ant-tasks

And then there is the RELEASE_NOTES files.  Andrew can you edit both the 
top-level RELEASE_NOTES.md and releasemgr/RELEASE_NOTES in royale-asjs?

There might be more if I get past the royaleunit-ant-tasks failure, but I'm 
out of time for another 15 hours or so.

HTH,
-Alex

On 9/6/19, 9:54 AM, "Andrew Wetmore"  wrote:

I have only looked at the top-level release notes and readme files. 
Should
I wait a day or so before digging down to look at the similar files in
folders?

On Fri, Sep 6, 2019 at 1:45 PM Josh Tynjala 
wrote:

> I just updated the royale-compiler and royale-asjs release notes with 
the
> things that I worked on. They're in the develop branch for now.
>
> --
> Josh Tynjala
> Bowler Hat LLC 

>
>
> On Fri, Sep 6, 2019 at 9:37 AM Piotr Zarzycki 

> wrote:
>
> > I was thinking about that in a very brave way at the beginning ! I 
was
> > going to go trough commits from our last 0.9.4 release and prepare 
nice
> > list for CHANGELOG, but since everything took double time then I 
assume.
> -
> > It's not going to happen from my sight.
> >
> > On Fri, Sep 6, 2019, 5:13 PM Andrew Wetmore  
wrote:
> >
> > > The release notes file doesn't seem to have a section about 
what's in
> > > 0.9.6, the current release.
> > >
> > > a
> > >
> > > On Fri, Sep 6, 2019 at 11:29 AM Piotr Zarzycki <
> > piotrzarzyck...@gmail.com>
> > > wrote:
> > >
> > > > Hi Carlos,
> > > >
> > > > IT depends on what commit MX is failing. I did branch for this 
RC
> > couple
> > > of
> > > > days ago. In that time I was seeing some commits to develop 
related
> to
> > > MX.
> > > >
> > > > Thanks,
> > > > Piotr
> > > >
> > > > On Fri, Sep 6, 2019, 4:02 PM Carlos Rovira 

> > > > wrote:
> > > >
> > > > > Hi Piotr,
> > > > >
> > > > > thanks. One question I have is: I think MX Test was failing, 
does
> it
> > > > > affects the release or are not crucial to get the bits out?
> > > > >
> > > > > Thanks
> > > > >
> > > > > El vie., 6 sept. 2019 a las 13:10, Piotr Zarzycki (<
> > > > > piotrzarzyck...@gmail.com>) escribió:
> > > > >
> > > > > > Hi Guys,
> > > > > >
> > > > > > I have upload manually ant artifacts. Please start reviewing
> stuff.
> > > > What
> > > > > if
> > > > > > vote passes - Should we merge 0.9.6 tag to develop ?
> > > > > >
> > > > > > Thanks,
> > > > > > Piotr
> > > > > >
> > > > > > pt., 6 wrz 2019 o 13:09 Apache Royale CI Server <
> > > > > apacheroyal...@gmail.com>
> > > > > > napisał(a):
> > > > > >
> > > > > > > This is the discussion thread.
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Piotr Zarzycki
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > >
> > > > > > Piotr Zarzycki

Re: Editing files delayed

2019-09-09 Thread Alex Harui
Andrew,

I hope you and others are safe and the area recovers soon.

I pushed your list of changes except the one about Modules since modules were 
in 0.9.4.

You might be able to see the changes on commits@ or at these links:

https://github.com/apache/royale-asjs/blob/release/0.9.6/RELEASE_NOTES.md
https://github.com/apache/royale-asjs/blob/release/0.9.6/releasemgr/RELEASE_NOTES

Thanks,
-Alex

On 9/9/19, 2:49 PM, "Andrew Wetmore"  wrote:

Power will not be restored here until Friday, so I am offline until then




Editing files delayed

2019-09-09 Thread Andrew Wetmore
Power will not be restored here until Friday, so I am offline until then


Re: Testing the npm install error fixes

2019-09-09 Thread OmPrakash Muppirala
Carlos,

Sorry, I was not clear.

We run the dependencies.js script after the installation as a `postInstall`
script.  It assumes that the @apache-royale/royale-js-swf directory is
created inside your global npm node_module directories.
You can verify if the package installed correctly in the first place by
running:

ls $(npm prefix -g)/lib/node_modules

Can you please run it and see if @apache-royale is listed there?

Thanks,
Om

On Mon, Sep 9, 2019 at 9:59 AM Carlos Rovira 
wrote:

> Hi Om,
>
> this is just a path you asked me for "dependencies.js" file, not the
> command line. The command line is already in the error log above this
> thread. There's something like this:
>
> macbookpro:~ carlosrovira$ npm i @apache-royale/royale-js-swf@0.9.6-beta0
> -g
>
> best
>
> C.
>
>
> El lun., 9 sept. 2019 a las 17:43, OmPrakash Muppirala ( >)
> escribió:
>
> > Huh?  Did you use the - g switch?  Your path indicates that you probably
> > did not..
> >
> > On Mon, Sep 9, 2019, 7:10 AM Carlos Rovira 
> > wrote:
> >
> > > Hi Om,
> > >
> > > the path is: "*/npm/js-swf/dependencies/*"
> > >
> > > HTH
> > > Carlos
> > >
> > > El vie., 6 sept. 2019 a las 19:41, OmPrakash Muppirala (<
> > > bigosma...@gmail.com>) escribió:
> > >
> > > > Thanks Carlos, this is useful!
> > > >
> > > > Can you send the path for the dependencies.js file you have shown
> here?
> > > >
> > > > Regards,
> > > > Om
> > > >
> > > > On Fri, Sep 6, 2019 at 12:42 AM Carlos Rovira <
> carlosrov...@apache.org
> > >
> > > > wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > I'll try to see Om links as I have time. In the mean while here is
> > the
> > > > log:
> > > > >
> > > > > https://paste.apache.org/p/pomzf
> > > > >
> > > > > and dependencies.js
> > > > >
> > > > > https://paste.apache.org/p/6nu70
> > > > >
> > > > >
> > > > > HTH
> > > > >
> > > > > Carlos
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > El jue., 5 sept. 2019 a las 18:32, OmPrakash Muppirala (<
> > > > > bigosma...@apache.org>) escribió:
> > > > >
> > > > > > If you have to use sudo that usually means that your node/npm is
> > not
> > > > > setup
> > > > > > correctly.
> > > > > >
> > > > > > Some more info here :
> > > > > >
> > > > >
> > > >
> > >
> >
> https://medium.com/@ExplosionPills/dont-use-sudo-with-npm-still-66e609f5f92
> > > > > >
> > > > > > https://stackoverflow.com/a/18296178
> > > > > >
> > > > > > That said, this issue is not related to sudo or otherwise.
> > > > > >
> > > > > > But it is a good idea to not sudo anything related to npm.  For
> > > > instance,
> > > > > > our installation scripts downloads and does a bunch of things
> > during
> > > > the
> > > > > > installation.  Imagine allowing a random script sudo access to
> your
> > > > > > computer.
> > > > > >
> > > > > > Thanks,
> > > > > > Om
> > > > > >
> > > > > > On Thu, Sep 5, 2019, 9:00 AM Alex Harui  >
> > > > > wrote:
> > > > > >
> > > > > > > Pretty sure if you use -g on MacOS you need sudo.  However, I
> > don't
> > > > > think
> > > > > > > that's the issue here.
> > > > > > > I think Carlos should post his:
> > > > > > > - dependencies/download_dependencies.js`
> > > > > > > -
> > /Users/carlosrovira/.npm/_logs/2019-09-05T09_39_50_359Z-debug.log
> > > > > > >
> > > > > > > HTH,
> > > > > > > -Alex
> > > > > > >
> > > > > > > On 9/5/19, 7:28 AM, "OmPrakash Muppirala" <
> bigosma...@gmail.com
> > >
> > > > > wrote:
> > > > > > >
> > > > > > > And oh, what is your node version?
> > > > > > >
> > > > > > > On Thu, Sep 5, 2019, 7:27 AM OmPrakash Muppirala <
> > > > > > bigosma...@gmail.com
> > > > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > > > We should never have to install any npm package with
> sudo.
> > > > > > > >
> > > > > > > > I will dig deeper into this and see what I can do.
> > > > > > > >
> > > > > > > > Thanks for testing!
> > > > > > > >
> > > > > > > > Om
> > > > > > > >
> > > > > > > >
> > > > > > > > On Thu, Sep 5, 2019, 2:41 AM Carlos Rovira <
> > > > > > carlosrov...@apache.org>
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > >> Thanks Harbs,
> > > > > > > >> that seems not to fix the problem:
> > > > > > > >>
> > > > > > > >> macbookpro:~ carlosrovira$ sudo npm i
> > > > > > > >> @apache-royale/royale-js-swf@0.9.6-beta0 -g
> > > > > > > >>
> > > > > > > >> Password:
> > > > > > > >>
> > > > > > > >> /usr/local/bin/asjsc ->
> > > > > > > >>
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asjscnpm
> > > > > > > >>
> > > > > > > >> /usr/local/bin/asjscompc ->
> > > > > > > >>
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asjscompcnpm
> > > > > > > >>
> > > > > > > >> /usr/local/bin/mxmlc ->
> > > > > > > >>
> > > > > 

Re: [royale-compiler] branch develop updated: MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true

2019-09-09 Thread Carlos Rovira
Hi,

I notice all that files too from Eclips, can we remove all that files and
add all config files to .gitignore.
In doing that you ensure that your config files are the ones you use and
you don't get any other one from our repo.
I think we removed all other IDE files (VScode), specially the ones that
are tied to user paths.
Moonshine are as well in, but don't know right now if are tied to user
paths or not.



El lun., 9 sept. 2019 a las 18:04, Josh Tynjala ()
escribió:

> Maybe. It's worth mentioning that VSCode's Java support is based on
> Eclipse, so it uses the same project file formats as Eclipse. We have
> .classpath and .project files committed in the repo, presumably to make it
> easy to import the compiler projects into Eclipse. However, they're
> constantly in a modified state in my local copy because VSCode overwrites
> them. I think that VSCode re-configures the project based on the Maven
> pom.xml file, but the repo's versions don't know about Maven.
>
> Even if we add .factorypath to .gitignore, both .classpath and .project are
> at risk of being accidentally committed too. It wouldn't really make a huge
> difference for me to ignore this file because I will still need to take
> extra care before committing. It just happened to slip through this time.
>
> --
> Josh Tynjala
> Bowler Hat LLC 
>
>
> On Mon, Sep 9, 2019 at 8:27 AM Alex Harui 
> wrote:
>
> > Should it be added to .gitignore so it doesn't get committed?
> >
> > On 9/9/19, 6:58 AM, "Josh Tynjala"  wrote:
> >
> > I removed this file. Should be gone on both develop and release/
> 0.9.6.
> >
> > - Josh
> >
> >
> > On Mon, Sep 9, 2019 at 6:39 AM Josh Tynjala <
> joshtynj...@bowlerhat.dev
> > >
> > wrote:
> >
> > > It's a project file created by VSCode. I didn't realize that I
> > > accidentally added it. It can be removed from the repo.
> > >
> > > - Josh
> > >
> > > On Saturday, September 7, 2019, Alex Harui
>  > >
> > > wrote:
> > > > Josh,
> > > >
> > > > What is the .factorypath file?  It is in the release package.
> > Should it
> > > even be in the repo?
> > > >
> > > > -Alex
> > > >
> > > > On 8/12/19, 11:12 AM, "joshtynj...@apache.org" <
> > joshtynj...@apache.org>
> > > wrote:
> > > >
> > > > This is an automated email from the ASF dual-hosted git
> > repository.
> > > >
> > > > joshtynjala pushed a commit to branch develop
> > > > in repository
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.gitdata=02%7C01%7Caharui%40adobe.com%7C9d9cda8acf534faa637c08d7352db98f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637036342817927726sdata=jLY5fG0O7mT1CeV%2B14Hzpzob4oAMW%2FclxdJB71Cfpl0%3Dreserved=0
> > > >
> > > >
> > > > The following commit(s) were added to refs/heads/develop by
> > this
> > > push:
> > > >  new f4f9898  MemberAccessEmitter: fixed issue where
> > > fully-qualified names were emitted as dynamic access with
> > > -js-dynamic-access-unknown-members=true
> > > > f4f9898 is described below
> > > >
> > > > commit f4f9898ad6f94c903615db5bfae691bfaac4a5f3
> > > > Author: Josh Tynjala 
> > > > AuthorDate: Mon Aug 12 11:12:34 2019 -0700
> > > >
> > > > MemberAccessEmitter: fixed issue where fully-qualified
> > names
> > > were emitted as dynamic access with
> > -js-dynamic-access-unknown-members=true
> > > >
> > > > Now, if a definition is resolved, and its parent
> > definition is a
> > > package, just outputs the fully-qualified name instead of walking
> > the full
> > > chain of member access
> > > > ---
> > > >  .../codegen/js/jx/MemberAccessEmitter.java |  13 ++-
> > > >  debugger/.factorypath  | 102
> > > +
> > > >  2 files changed, 111 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git
> > >
> >
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > >
> >
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > > index 741affb..cc0a892 100644
> > > > ---
> > >
> >
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > > +++
> > >
> >
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > > @@ -23,6 +23,7 @@ import
> > > org.apache.royale.compiler.codegen.ISubEmitter;
> > > >  import org.apache.royale.compiler.codegen.js.IJSEmitter;
> > > >  import
> > org.apache.royale.compiler.constants.IASLanguageConstants;
> > > >  import org.apache.royale.compiler.definitions.IDefinition;
> > > 

Re: Testing the npm install error fixes

2019-09-09 Thread Carlos Rovira
Hi Om,

this is just a path you asked me for "dependencies.js" file, not the
command line. The command line is already in the error log above this
thread. There's something like this:

macbookpro:~ carlosrovira$ npm i @apache-royale/royale-js-swf@0.9.6-beta0 -g

best

C.


El lun., 9 sept. 2019 a las 17:43, OmPrakash Muppirala ()
escribió:

> Huh?  Did you use the - g switch?  Your path indicates that you probably
> did not..
>
> On Mon, Sep 9, 2019, 7:10 AM Carlos Rovira 
> wrote:
>
> > Hi Om,
> >
> > the path is: "*/npm/js-swf/dependencies/*"
> >
> > HTH
> > Carlos
> >
> > El vie., 6 sept. 2019 a las 19:41, OmPrakash Muppirala (<
> > bigosma...@gmail.com>) escribió:
> >
> > > Thanks Carlos, this is useful!
> > >
> > > Can you send the path for the dependencies.js file you have shown here?
> > >
> > > Regards,
> > > Om
> > >
> > > On Fri, Sep 6, 2019 at 12:42 AM Carlos Rovira  >
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > I'll try to see Om links as I have time. In the mean while here is
> the
> > > log:
> > > >
> > > > https://paste.apache.org/p/pomzf
> > > >
> > > > and dependencies.js
> > > >
> > > > https://paste.apache.org/p/6nu70
> > > >
> > > >
> > > > HTH
> > > >
> > > > Carlos
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > El jue., 5 sept. 2019 a las 18:32, OmPrakash Muppirala (<
> > > > bigosma...@apache.org>) escribió:
> > > >
> > > > > If you have to use sudo that usually means that your node/npm is
> not
> > > > setup
> > > > > correctly.
> > > > >
> > > > > Some more info here :
> > > > >
> > > >
> > >
> >
> https://medium.com/@ExplosionPills/dont-use-sudo-with-npm-still-66e609f5f92
> > > > >
> > > > > https://stackoverflow.com/a/18296178
> > > > >
> > > > > That said, this issue is not related to sudo or otherwise.
> > > > >
> > > > > But it is a good idea to not sudo anything related to npm.  For
> > > instance,
> > > > > our installation scripts downloads and does a bunch of things
> during
> > > the
> > > > > installation.  Imagine allowing a random script sudo access to your
> > > > > computer.
> > > > >
> > > > > Thanks,
> > > > > Om
> > > > >
> > > > > On Thu, Sep 5, 2019, 9:00 AM Alex Harui 
> > > > wrote:
> > > > >
> > > > > > Pretty sure if you use -g on MacOS you need sudo.  However, I
> don't
> > > > think
> > > > > > that's the issue here.
> > > > > > I think Carlos should post his:
> > > > > > - dependencies/download_dependencies.js`
> > > > > > -
> /Users/carlosrovira/.npm/_logs/2019-09-05T09_39_50_359Z-debug.log
> > > > > >
> > > > > > HTH,
> > > > > > -Alex
> > > > > >
> > > > > > On 9/5/19, 7:28 AM, "OmPrakash Muppirala"  >
> > > > wrote:
> > > > > >
> > > > > > And oh, what is your node version?
> > > > > >
> > > > > > On Thu, Sep 5, 2019, 7:27 AM OmPrakash Muppirala <
> > > > > bigosma...@gmail.com
> > > > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > We should never have to install any npm package with sudo.
> > > > > > >
> > > > > > > I will dig deeper into this and see what I can do.
> > > > > > >
> > > > > > > Thanks for testing!
> > > > > > >
> > > > > > > Om
> > > > > > >
> > > > > > >
> > > > > > > On Thu, Sep 5, 2019, 2:41 AM Carlos Rovira <
> > > > > carlosrov...@apache.org>
> > > > > > > wrote:
> > > > > > >
> > > > > > >> Thanks Harbs,
> > > > > > >> that seems not to fix the problem:
> > > > > > >>
> > > > > > >> macbookpro:~ carlosrovira$ sudo npm i
> > > > > > >> @apache-royale/royale-js-swf@0.9.6-beta0 -g
> > > > > > >>
> > > > > > >> Password:
> > > > > > >>
> > > > > > >> /usr/local/bin/asjsc ->
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asjscnpm
> > > > > > >>
> > > > > > >> /usr/local/bin/asjscompc ->
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asjscompcnpm
> > > > > > >>
> > > > > > >> /usr/local/bin/mxmlc ->
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/mxmlcnpm
> > > > > > >>
> > > > > > >> /usr/local/bin/asnodec ->
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asnodecnpm
> > > > > > >>
> > > > > > >> /usr/local/bin/compc ->
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/compcnpm
> > > > > > >>
> > > > > > >> /usr/local/bin/externc ->
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/externcnpm
> > > > > > >>
> > > > > > >>
> > > > > > >> 

Build failed in Jenkins: royale-asjs_MXTests #1136

2019-09-09 Thread Apache Royale CI Server
See 


--
[...truncated 967.82 KB...]
[mxmlc] scanning for overrides: ObjectUtil
[mxmlc] scanning for overrides: SolidBorderUtil
[mxmlc] scanning for overrides: StringTrimmer
[mxmlc] scanning for overrides: StringUtil
[mxmlc] scanning for overrides: Timer
[mxmlc] scanning for overrides: UIUtils
[mxmlc] scanning for overrides: Effect
[mxmlc] scanning for overrides: Transition
[mxmlc] scanning for overrides: IFill
[mxmlc] scanning for overrides: SolidColor
[mxmlc] scanning for overrides: IExternalizable
[mxmlc] scanning for overrides: Proxy
[mxmlc] scanning for overrides: CursorBookmark
[mxmlc] scanning for overrides: ICollectionView
[mxmlc] scanning for overrides: IList
[mxmlc] scanning for overrides: IViewCursor
[mxmlc] scanning for overrides: ListCollectionView
[mxmlc] scanning for overrides: ListCollectionViewCursor
[mxmlc] scanning for overrides: ListCollectionViewBookmark
[mxmlc] scanning for overrides: ArrayCollection
[mxmlc] scanning for overrides: ArrayList
[mxmlc] scanning for overrides: XMLListCollection
[mxmlc] scanning for overrides: CanvasLayout
[mxmlc] scanning for overrides: Flex
[mxmlc] scanning for overrides: BoxDirection
[mxmlc] scanning for overrides: HBox
[mxmlc] scanning for overrides: PanelTitleBar
[mxmlc] scanning for overrides: DataGridColumn
[mxmlc] scanning for overrides: Button
[mxmlc] scanning for overrides: ISelectable
[mxmlc] scanning for overrides: CheckBox
[mxmlc] scanning for overrides: IFocusManagerComponent
[mxmlc] scanning for overrides: ComboBase
[mxmlc] scanning for overrides: ComboBox
[mxmlc] scanning for overrides: ScrollControlBase
[mxmlc] scanning for overrides: ListBase
[mxmlc] scanning for overrides: DataGrid
[mxmlc] scanning for overrides: DateField
[mxmlc] scanning for overrides: Label
[mxmlc] scanning for overrides: List
[mxmlc] scanning for overrides: MenuBar
[mxmlc] scanning for overrides: NumericStepper
[mxmlc] scanning for overrides: RadioButton
[mxmlc] scanning for overrides: RadioButtonGroup
[mxmlc] scanning for overrides: TextArea
[mxmlc] scanning for overrides: ITextInput
[mxmlc] scanning for overrides: TextInput
[mxmlc] scanning for overrides: ITextFieldFactory
[mxmlc] scanning for overrides: Singleton
[mxmlc] scanning for overrides: ItemClickEvent
[mxmlc] scanning for overrides: ListEvent
[mxmlc] scanning for overrides: MenuEvent
[mxmlc] scanning for overrides: MouseEvent
[mxmlc] scanning for overrides: PropertyChangeEventKind
[mxmlc] scanning for overrides: Matrix
[mxmlc] scanning for overrides: Matrix
[mxmlc] scanning for overrides: IFocusManagerComplexComponent
[mxmlc] scanning for overrides: IFocusManagerGroup
[mxmlc] scanning for overrides: IResourceBundle
[mxmlc] scanning for overrides: ResourceManagerImpl
[mxmlc] scanning for overrides: ResourceModuleInfo
[mxmlc] scanning for overrides: ResourceEventDispatcher
[mxmlc] scanning for overrides: ResourceBundleProxy
[mxmlc] scanning for overrides: GroupBase
[mxmlc] scanning for overrides: SkinnableComponent
[mxmlc] scanning for overrides: ButtonBase
[mxmlc] scanning for overrides: Button
[mxmlc] scanning for overrides: ErrorArray
[mxmlc] scanning for overrides: RunCodeEvent
[mxmlc] scanning for overrides: PasswordInputBead
[mxmlc] scanning for overrides: ITileLayout
[mxmlc] scanning for overrides: TileLayout
[mxmlc] scanning for overrides: LocaleUtils
[mxmlc] scanning for overrides: StringPadder
[mxmlc] scanning for overrides: UIDUtil
[mxmlc] scanning for overrides: IStroke
[mxmlc] scanning for overrides: CursorError
[mxmlc] scanning for overrides: SortError
[mxmlc] scanning for overrides: ISort
[mxmlc] scanning for overrides: Sort
[mxmlc] scanning for overrides: IXMLNotifiable
[mxmlc] scanning for overrides: XMLListAdapter
[mxmlc] scanning for overrides: FlexChildInfo
[mxmlc] scanning for overrides: BaseListData
[mxmlc] scanning for overrides: IFactory
[mxmlc] scanning for overrides: IUITextField
[mxmlc] scanning for overrides: UITextField
[mxmlc] scanning for overrides: CollectionEvent
[mxmlc] scanning for overrides: CollectionEventKind
[mxmlc] scanning for overrides: LocaleSorter
[mxmlc] scanning for overrides: LocaleID
[mxmlc] scanning for overrides: LocaleRegistry
[mxmlc] scanning for overrides: ResourceBundle
[mxmlc] scanning for overrides: ArrayUtil
[mxmlc] scanning for overrides: StringUtil
[mxmlc] scanning for overrides: UIDUtil
[mxmlc] scanning for overrides: DataGroup
[mxmlc] scanning for overrides: LayoutBase
[mxmlc] scanning for overrides: BasicLayout

Re: [royale-compiler] branch develop updated: MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true

2019-09-09 Thread Josh Tynjala
Maybe. It's worth mentioning that VSCode's Java support is based on
Eclipse, so it uses the same project file formats as Eclipse. We have
.classpath and .project files committed in the repo, presumably to make it
easy to import the compiler projects into Eclipse. However, they're
constantly in a modified state in my local copy because VSCode overwrites
them. I think that VSCode re-configures the project based on the Maven
pom.xml file, but the repo's versions don't know about Maven.

Even if we add .factorypath to .gitignore, both .classpath and .project are
at risk of being accidentally committed too. It wouldn't really make a huge
difference for me to ignore this file because I will still need to take
extra care before committing. It just happened to slip through this time.

--
Josh Tynjala
Bowler Hat LLC 


On Mon, Sep 9, 2019 at 8:27 AM Alex Harui  wrote:

> Should it be added to .gitignore so it doesn't get committed?
>
> On 9/9/19, 6:58 AM, "Josh Tynjala"  wrote:
>
> I removed this file. Should be gone on both develop and release/0.9.6.
>
> - Josh
>
>
> On Mon, Sep 9, 2019 at 6:39 AM Josh Tynjala  >
> wrote:
>
> > It's a project file created by VSCode. I didn't realize that I
> > accidentally added it. It can be removed from the repo.
> >
> > - Josh
> >
> > On Saturday, September 7, 2019, Alex Harui  >
> > wrote:
> > > Josh,
> > >
> > > What is the .factorypath file?  It is in the release package.
> Should it
> > even be in the repo?
> > >
> > > -Alex
> > >
> > > On 8/12/19, 11:12 AM, "joshtynj...@apache.org" <
> joshtynj...@apache.org>
> > wrote:
> > >
> > > This is an automated email from the ASF dual-hosted git
> repository.
> > >
> > > joshtynjala pushed a commit to branch develop
> > > in repository
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.gitdata=02%7C01%7Caharui%40adobe.com%7C9d9cda8acf534faa637c08d7352db98f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637036342817927726sdata=jLY5fG0O7mT1CeV%2B14Hzpzob4oAMW%2FclxdJB71Cfpl0%3Dreserved=0
> > >
> > >
> > > The following commit(s) were added to refs/heads/develop by
> this
> > push:
> > >  new f4f9898  MemberAccessEmitter: fixed issue where
> > fully-qualified names were emitted as dynamic access with
> > -js-dynamic-access-unknown-members=true
> > > f4f9898 is described below
> > >
> > > commit f4f9898ad6f94c903615db5bfae691bfaac4a5f3
> > > Author: Josh Tynjala 
> > > AuthorDate: Mon Aug 12 11:12:34 2019 -0700
> > >
> > > MemberAccessEmitter: fixed issue where fully-qualified
> names
> > were emitted as dynamic access with
> -js-dynamic-access-unknown-members=true
> > >
> > > Now, if a definition is resolved, and its parent
> definition is a
> > package, just outputs the fully-qualified name instead of walking
> the full
> > chain of member access
> > > ---
> > >  .../codegen/js/jx/MemberAccessEmitter.java |  13 ++-
> > >  debugger/.factorypath  | 102
> > +
> > >  2 files changed, 111 insertions(+), 4 deletions(-)
> > >
> > > diff --git
> >
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> >
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > index 741affb..cc0a892 100644
> > > ---
> >
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > +++
> >
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > @@ -23,6 +23,7 @@ import
> > org.apache.royale.compiler.codegen.ISubEmitter;
> > >  import org.apache.royale.compiler.codegen.js.IJSEmitter;
> > >  import
> org.apache.royale.compiler.constants.IASLanguageConstants;
> > >  import org.apache.royale.compiler.definitions.IDefinition;
> > > +import
> org.apache.royale.compiler.definitions.IPackageDefinition;
> > >  import
> > org.apache.royale.compiler.internal.codegen.as.ASEmitterTokens;
> > >  import
> > org.apache.royale.compiler.internal.codegen.js.JSEmitterTokens;
> > >  import
> org.apache.royale.compiler.internal.codegen.js.JSSubEmitter;
> > > @@ -32,7 +33,6 @@ import
> >
> org.apache.royale.compiler.internal.codegen.js.royale.JSRoyaleEmitterToke
> > >  import
> >
> org.apache.royale.compiler.internal.codegen.js.goog.JSGoogEmitterTokens;
> > >  import
> >
> org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter.DatePropertiesGetters;
> > >  import
> > 

Re: Testing the npm install error fixes

2019-09-09 Thread OmPrakash Muppirala
Huh?  Did you use the - g switch?  Your path indicates that you probably
did not..

On Mon, Sep 9, 2019, 7:10 AM Carlos Rovira  wrote:

> Hi Om,
>
> the path is: "*/npm/js-swf/dependencies/*"
>
> HTH
> Carlos
>
> El vie., 6 sept. 2019 a las 19:41, OmPrakash Muppirala (<
> bigosma...@gmail.com>) escribió:
>
> > Thanks Carlos, this is useful!
> >
> > Can you send the path for the dependencies.js file you have shown here?
> >
> > Regards,
> > Om
> >
> > On Fri, Sep 6, 2019 at 12:42 AM Carlos Rovira 
> > wrote:
> >
> > > Hi,
> > >
> > > I'll try to see Om links as I have time. In the mean while here is the
> > log:
> > >
> > > https://paste.apache.org/p/pomzf
> > >
> > > and dependencies.js
> > >
> > > https://paste.apache.org/p/6nu70
> > >
> > >
> > > HTH
> > >
> > > Carlos
> > >
> > >
> > >
> > >
> > >
> > >
> > > El jue., 5 sept. 2019 a las 18:32, OmPrakash Muppirala (<
> > > bigosma...@apache.org>) escribió:
> > >
> > > > If you have to use sudo that usually means that your node/npm is not
> > > setup
> > > > correctly.
> > > >
> > > > Some more info here :
> > > >
> > >
> >
> https://medium.com/@ExplosionPills/dont-use-sudo-with-npm-still-66e609f5f92
> > > >
> > > > https://stackoverflow.com/a/18296178
> > > >
> > > > That said, this issue is not related to sudo or otherwise.
> > > >
> > > > But it is a good idea to not sudo anything related to npm.  For
> > instance,
> > > > our installation scripts downloads and does a bunch of things during
> > the
> > > > installation.  Imagine allowing a random script sudo access to your
> > > > computer.
> > > >
> > > > Thanks,
> > > > Om
> > > >
> > > > On Thu, Sep 5, 2019, 9:00 AM Alex Harui 
> > > wrote:
> > > >
> > > > > Pretty sure if you use -g on MacOS you need sudo.  However, I don't
> > > think
> > > > > that's the issue here.
> > > > > I think Carlos should post his:
> > > > > - dependencies/download_dependencies.js`
> > > > > - /Users/carlosrovira/.npm/_logs/2019-09-05T09_39_50_359Z-debug.log
> > > > >
> > > > > HTH,
> > > > > -Alex
> > > > >
> > > > > On 9/5/19, 7:28 AM, "OmPrakash Muppirala" 
> > > wrote:
> > > > >
> > > > > And oh, what is your node version?
> > > > >
> > > > > On Thu, Sep 5, 2019, 7:27 AM OmPrakash Muppirala <
> > > > bigosma...@gmail.com
> > > > > >
> > > > > wrote:
> > > > >
> > > > > > We should never have to install any npm package with sudo.
> > > > > >
> > > > > > I will dig deeper into this and see what I can do.
> > > > > >
> > > > > > Thanks for testing!
> > > > > >
> > > > > > Om
> > > > > >
> > > > > >
> > > > > > On Thu, Sep 5, 2019, 2:41 AM Carlos Rovira <
> > > > carlosrov...@apache.org>
> > > > > > wrote:
> > > > > >
> > > > > >> Thanks Harbs,
> > > > > >> that seems not to fix the problem:
> > > > > >>
> > > > > >> macbookpro:~ carlosrovira$ sudo npm i
> > > > > >> @apache-royale/royale-js-swf@0.9.6-beta0 -g
> > > > > >>
> > > > > >> Password:
> > > > > >>
> > > > > >> /usr/local/bin/asjsc ->
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asjscnpm
> > > > > >>
> > > > > >> /usr/local/bin/asjscompc ->
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asjscompcnpm
> > > > > >>
> > > > > >> /usr/local/bin/mxmlc ->
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/mxmlcnpm
> > > > > >>
> > > > > >> /usr/local/bin/asnodec ->
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asnodecnpm
> > > > > >>
> > > > > >> /usr/local/bin/compc ->
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/compcnpm
> > > > > >>
> > > > > >> /usr/local/bin/externc ->
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/externcnpm
> > > > > >>
> > > > > >>
> > > > > >> > @apache-royale/royale-js-swf@0.9.6-beta0 postinstall
> > > > > >> /usr/local/lib/node_modules/@apache-royale/royale-js-swf
> > > > > >>
> > > > > >> > node dependencies/download_dependencies.js
> > > > > >>
> > > > > >>
> > > > > >> internal/modules/cjs/loader.js:582
> > > > > >>
> > > > > >> throw err;
> > > > > >>
> > > > > >> ^
> > > > > >>
> > > > > >>
> > > > > >> Error: Cannot find module
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> '/usr/local/lib/node_modules/@apache-royale/royale-js-swf/dependencies/download_dependencies.js'
> > > > > >>
> > > > > >> at Function.Module._resolveFilename
> > > > > >> 

Re: [royale-compiler] branch develop updated: MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true

2019-09-09 Thread Alex Harui
Should it be added to .gitignore so it doesn't get committed?

On 9/9/19, 6:58 AM, "Josh Tynjala"  wrote:

I removed this file. Should be gone on both develop and release/0.9.6.

- Josh


On Mon, Sep 9, 2019 at 6:39 AM Josh Tynjala 
wrote:

> It's a project file created by VSCode. I didn't realize that I
> accidentally added it. It can be removed from the repo.
>
> - Josh
>
> On Saturday, September 7, 2019, Alex Harui 
> wrote:
> > Josh,
> >
> > What is the .factorypath file?  It is in the release package.  Should it
> even be in the repo?
> >
> > -Alex
> >
> > On 8/12/19, 11:12 AM, "joshtynj...@apache.org" 
> wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > joshtynjala pushed a commit to branch develop
> > in repository
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.gitdata=02%7C01%7Caharui%40adobe.com%7C9d9cda8acf534faa637c08d7352db98f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637036342817927726sdata=jLY5fG0O7mT1CeV%2B14Hzpzob4oAMW%2FclxdJB71Cfpl0%3Dreserved=0
> >
> >
> > The following commit(s) were added to refs/heads/develop by this
> push:
> >  new f4f9898  MemberAccessEmitter: fixed issue where
> fully-qualified names were emitted as dynamic access with
> -js-dynamic-access-unknown-members=true
> > f4f9898 is described below
> >
> > commit f4f9898ad6f94c903615db5bfae691bfaac4a5f3
> > Author: Josh Tynjala 
> > AuthorDate: Mon Aug 12 11:12:34 2019 -0700
> >
> > MemberAccessEmitter: fixed issue where fully-qualified names
> were emitted as dynamic access with 
-js-dynamic-access-unknown-members=true
> >
> > Now, if a definition is resolved, and its parent definition is a
> package, just outputs the fully-qualified name instead of walking the full
> chain of member access
> > ---
> >  .../codegen/js/jx/MemberAccessEmitter.java |  13 ++-
> >  debugger/.factorypath  | 102
> +
> >  2 files changed, 111 insertions(+), 4 deletions(-)
> >
> > diff --git
> 
a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> 
b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > index 741affb..cc0a892 100644
> > ---
> 
a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > +++
> 
b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > @@ -23,6 +23,7 @@ import
> org.apache.royale.compiler.codegen.ISubEmitter;
> >  import org.apache.royale.compiler.codegen.js.IJSEmitter;
> >  import org.apache.royale.compiler.constants.IASLanguageConstants;
> >  import org.apache.royale.compiler.definitions.IDefinition;
> > +import org.apache.royale.compiler.definitions.IPackageDefinition;
> >  import
> org.apache.royale.compiler.internal.codegen.as.ASEmitterTokens;
> >  import
> org.apache.royale.compiler.internal.codegen.js.JSEmitterTokens;
> >  import org.apache.royale.compiler.internal.codegen.js.JSSubEmitter;
> > @@ -32,7 +33,6 @@ import
> org.apache.royale.compiler.internal.codegen.js.royale.JSRoyaleEmitterToke
> >  import
> org.apache.royale.compiler.internal.codegen.js.goog.JSGoogEmitterTokens;
> >  import
> 
org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter.DatePropertiesGetters;
> >  import
> org.apache.royale.compiler.internal.definitions.AccessorDefinition;
> > -import
> org.apache.royale.compiler.internal.definitions.AppliedVectorDefinition;
> >  import
> org.apache.royale.compiler.internal.definitions.FunctionDefinition;
> >  import 
org.apache.royale.compiler.internal.projects.RoyaleJSProject;
> >  import org.apache.royale.compiler.internal.tree.as.*;
> > @@ -42,8 +42,6 @@ import org.apache.royale.compiler.tree.as.*;
> >  import
> org.apache.royale.compiler.tree.as.IOperatorNode.OperatorType;
> >  import org.apache.royale.compiler.utils.ASNodeUtils;
> >
> > -import javax.sound.midi.SysexMessage;
> > -
> >  public class MemberAccessEmitter extends JSSubEmitter implements
> >  ISubEmitter
> >  {
> > @@ -177,6 +175,13 @@ public class MemberAccessEmitter extends
> JSSubEmitter implements
> > return;
> > }
> >  }
> > +   else if(def.getParent() instanceof IPackageDefinition)

Re: ${body} in index template

2019-09-09 Thread Carlos Rovira
Hi,

I'm ok with new changes, maybe the problem is breaking all current apps,
since it implies to change all our examples and people out there take
notice of this change, since all apps will be failing.

I think the best way should be support the current vars, while introducing
new ones. Additionally, we could signal a deprecation so people can update
their codes and remove older method sometime in the future.

just my 2...


El sáb., 7 sept. 2019 a las 1:25, Alex Harui ()
escribió:

> FWIW, the current implementation was just a quick hack to get something
> working.  No serious thought went into it so feel free to change it.
>
> I think there are "projectName" and "mainClassQName" variables in the
> compiler.  IIRC, projectName maps to the output file name and
> mainClassQName maps to the name of the file that subclasses some
> Application that becomes the source file passed into the compiler.  Most of
> our examples have them as the same, but Carlos likes to build examples
> where the main class is App.mxml.
>
> IIRC, Flex always named the SystemManager subclass after the
> mainClassQName.  In Royale, any framework can use [FactoryClass] to setup
> some sort of SystemManager-like thing that loads the Application, so in my
> mind, there is an "EntryPointClass" or "StartupClass" and the main
> Application subclass.  Sometimes they are the same (for Basic and probably
> Jewel).
>
> I'm not concerned about breaking existing templates by not injection the
>  tags around the entry point code.  But that's just me.
>
> My 2 cents,
> -Alex
>
> On 9/6/19, 2:20 PM, "Greg Dove"  wrote:
>
> Hi Carlos,
>
> Based on the variation that happens, I'm not sure ${application} is
> useful
> in its current form, although at first glance it appeared to be when I
> used
> it.
>
> Probably we just need
> ${applicationclass}
>
> The code that handles this is here:
>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-compiler%2Fblob%2Fa9fcf4f1f1b71508c7f9bf984975a27fbb13b8d5%2Fcompiler-jx%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Froyale%2Fcompiler%2Finternal%2Fcodegen%2Fmxml%2Froyale%2FMXMLRoyalePublisher.java%23L832&data=02%7C01%7Caharui%40adobe.com%7C4eaa963c03ce49e1239808d733101497%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637034016499897671&sdata=cG%2FSBE05253%2BIduhPc8gbkyX0kStLLeHjizbKoHsXy8%3D&reserved=0
>
> And based on what it seems to be doing I think the ${applicationclass}
> token would just need to be substituted with the same value that is
> passed
> as the argument to getTemplateBody call here:
>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-compiler%2Fblob%2Fa9fcf4f1f1b71508c7f9bf984975a27fbb13b8d5%2Fcompiler-jx%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Froyale%2Fcompiler%2Finternal%2Fcodegen%2Fmxml%2Froyale%2FMXMLRoyalePublisher.java%23L879&data=02%7C01%7Caharui%40adobe.com%7C4eaa963c03ce49e1239808d733101497%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637034016499897671&sdata=OemmdJGiY6f9Nj1iLLgPUIee0E1GTZyQSr7Jvp4xNwE%3D&reserved=0
>
> so I'm guessing all it needs is:
> if (type.equals("release")) {
> result = input.replaceAll("\\$\\{applicationclass\\}",
> projectName );
> } else {
> result = input.replaceAll("\\$\\{applicationclass\\}",
> mainClassName );
> }
>
> But I did not check the variation between projectName and mainClassName
> between release and debug for that, so I don't fully understand that
> part
> yet. Maybe @aharui can confirm.
>
>
>
>
> On Fri, Sep 6, 2019 at 7:36 PM Carlos Rovira 
> wrote:
>
> > Hi Greg,
> >
> > so the proposal is to end with:
> >
> > -body
> > -application (used for standard Royale apps)
> > -AppClassName (for 

Re: Testing the npm install error fixes

2019-09-09 Thread Carlos Rovira
Hi Om,

the path is: "*/npm/js-swf/dependencies/*"

HTH
Carlos

El vie., 6 sept. 2019 a las 19:41, OmPrakash Muppirala (<
bigosma...@gmail.com>) escribió:

> Thanks Carlos, this is useful!
>
> Can you send the path for the dependencies.js file you have shown here?
>
> Regards,
> Om
>
> On Fri, Sep 6, 2019 at 12:42 AM Carlos Rovira 
> wrote:
>
> > Hi,
> >
> > I'll try to see Om links as I have time. In the mean while here is the
> log:
> >
> > https://paste.apache.org/p/pomzf
> >
> > and dependencies.js
> >
> > https://paste.apache.org/p/6nu70
> >
> >
> > HTH
> >
> > Carlos
> >
> >
> >
> >
> >
> >
> > El jue., 5 sept. 2019 a las 18:32, OmPrakash Muppirala (<
> > bigosma...@apache.org>) escribió:
> >
> > > If you have to use sudo that usually means that your node/npm is not
> > setup
> > > correctly.
> > >
> > > Some more info here :
> > >
> >
> https://medium.com/@ExplosionPills/dont-use-sudo-with-npm-still-66e609f5f92
> > >
> > > https://stackoverflow.com/a/18296178
> > >
> > > That said, this issue is not related to sudo or otherwise.
> > >
> > > But it is a good idea to not sudo anything related to npm.  For
> instance,
> > > our installation scripts downloads and does a bunch of things during
> the
> > > installation.  Imagine allowing a random script sudo access to your
> > > computer.
> > >
> > > Thanks,
> > > Om
> > >
> > > On Thu, Sep 5, 2019, 9:00 AM Alex Harui 
> > wrote:
> > >
> > > > Pretty sure if you use -g on MacOS you need sudo.  However, I don't
> > think
> > > > that's the issue here.
> > > > I think Carlos should post his:
> > > > - dependencies/download_dependencies.js`
> > > > - /Users/carlosrovira/.npm/_logs/2019-09-05T09_39_50_359Z-debug.log
> > > >
> > > > HTH,
> > > > -Alex
> > > >
> > > > On 9/5/19, 7:28 AM, "OmPrakash Muppirala" 
> > wrote:
> > > >
> > > > And oh, what is your node version?
> > > >
> > > > On Thu, Sep 5, 2019, 7:27 AM OmPrakash Muppirala <
> > > bigosma...@gmail.com
> > > > >
> > > > wrote:
> > > >
> > > > > We should never have to install any npm package with sudo.
> > > > >
> > > > > I will dig deeper into this and see what I can do.
> > > > >
> > > > > Thanks for testing!
> > > > >
> > > > > Om
> > > > >
> > > > >
> > > > > On Thu, Sep 5, 2019, 2:41 AM Carlos Rovira <
> > > carlosrov...@apache.org>
> > > > > wrote:
> > > > >
> > > > >> Thanks Harbs,
> > > > >> that seems not to fix the problem:
> > > > >>
> > > > >> macbookpro:~ carlosrovira$ sudo npm i
> > > > >> @apache-royale/royale-js-swf@0.9.6-beta0 -g
> > > > >>
> > > > >> Password:
> > > > >>
> > > > >> /usr/local/bin/asjsc ->
> > > > >>
> > > > >>
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asjscnpm
> > > > >>
> > > > >> /usr/local/bin/asjscompc ->
> > > > >>
> > > > >>
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asjscompcnpm
> > > > >>
> > > > >> /usr/local/bin/mxmlc ->
> > > > >>
> > > > >>
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/mxmlcnpm
> > > > >>
> > > > >> /usr/local/bin/asnodec ->
> > > > >>
> > > > >>
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/asnodecnpm
> > > > >>
> > > > >> /usr/local/bin/compc ->
> > > > >>
> > > > >>
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/compcnpm
> > > > >>
> > > > >> /usr/local/bin/externc ->
> > > > >>
> > > > >>
> > > >
> > >
> >
> /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/externcnpm
> > > > >>
> > > > >>
> > > > >> > @apache-royale/royale-js-swf@0.9.6-beta0 postinstall
> > > > >> /usr/local/lib/node_modules/@apache-royale/royale-js-swf
> > > > >>
> > > > >> > node dependencies/download_dependencies.js
> > > > >>
> > > > >>
> > > > >> internal/modules/cjs/loader.js:582
> > > > >>
> > > > >> throw err;
> > > > >>
> > > > >> ^
> > > > >>
> > > > >>
> > > > >> Error: Cannot find module
> > > > >>
> > > > >>
> > > >
> > >
> >
> '/usr/local/lib/node_modules/@apache-royale/royale-js-swf/dependencies/download_dependencies.js'
> > > > >>
> > > > >> at Function.Module._resolveFilename
> > > > >> (internal/modules/cjs/loader.js:580:15)
> > > > >>
> > > > >> at Function.Module._load
> > > (internal/modules/cjs/loader.js:506:25)
> > > > >>
> > > > >> at Function.Module.runMain
> > > > (internal/modules/cjs/loader.js:741:12)
> > > > >>
> > > > >> at startup (internal/bootstrap/node.js:285:19)
> > > > >>
> > > > >> at bootstrapNodeJSCore (internal/bootstrap/node.js:739:3)
> > > > >>
> > > > >> npm ERR! code ELIFECYCLE
> > > > >>
> > > > >> npm 

Build failed in Jenkins: royale-asjs_MXTests #1135

2019-09-09 Thread Apache Royale CI Server
See 


--
[...truncated 967.84 KB...]
[mxmlc] scanning for overrides: ObjectUtil
[mxmlc] scanning for overrides: SolidBorderUtil
[mxmlc] scanning for overrides: StringTrimmer
[mxmlc] scanning for overrides: StringUtil
[mxmlc] scanning for overrides: Timer
[mxmlc] scanning for overrides: UIUtils
[mxmlc] scanning for overrides: Effect
[mxmlc] scanning for overrides: Transition
[mxmlc] scanning for overrides: IFill
[mxmlc] scanning for overrides: SolidColor
[mxmlc] scanning for overrides: IExternalizable
[mxmlc] scanning for overrides: Proxy
[mxmlc] scanning for overrides: CursorBookmark
[mxmlc] scanning for overrides: ICollectionView
[mxmlc] scanning for overrides: IList
[mxmlc] scanning for overrides: IViewCursor
[mxmlc] scanning for overrides: ListCollectionView
[mxmlc] scanning for overrides: ListCollectionViewCursor
[mxmlc] scanning for overrides: ListCollectionViewBookmark
[mxmlc] scanning for overrides: ArrayCollection
[mxmlc] scanning for overrides: ArrayList
[mxmlc] scanning for overrides: XMLListCollection
[mxmlc] scanning for overrides: CanvasLayout
[mxmlc] scanning for overrides: Flex
[mxmlc] scanning for overrides: BoxDirection
[mxmlc] scanning for overrides: HBox
[mxmlc] scanning for overrides: PanelTitleBar
[mxmlc] scanning for overrides: DataGridColumn
[mxmlc] scanning for overrides: Button
[mxmlc] scanning for overrides: ISelectable
[mxmlc] scanning for overrides: CheckBox
[mxmlc] scanning for overrides: IFocusManagerComponent
[mxmlc] scanning for overrides: ComboBase
[mxmlc] scanning for overrides: ComboBox
[mxmlc] scanning for overrides: ScrollControlBase
[mxmlc] scanning for overrides: ListBase
[mxmlc] scanning for overrides: DataGrid
[mxmlc] scanning for overrides: DateField
[mxmlc] scanning for overrides: Label
[mxmlc] scanning for overrides: List
[mxmlc] scanning for overrides: MenuBar
[mxmlc] scanning for overrides: NumericStepper
[mxmlc] scanning for overrides: RadioButton
[mxmlc] scanning for overrides: RadioButtonGroup
[mxmlc] scanning for overrides: TextArea
[mxmlc] scanning for overrides: ITextInput
[mxmlc] scanning for overrides: TextInput
[mxmlc] scanning for overrides: ITextFieldFactory
[mxmlc] scanning for overrides: Singleton
[mxmlc] scanning for overrides: ItemClickEvent
[mxmlc] scanning for overrides: ListEvent
[mxmlc] scanning for overrides: MenuEvent
[mxmlc] scanning for overrides: MouseEvent
[mxmlc] scanning for overrides: PropertyChangeEventKind
[mxmlc] scanning for overrides: Matrix
[mxmlc] scanning for overrides: Matrix
[mxmlc] scanning for overrides: IFocusManagerComplexComponent
[mxmlc] scanning for overrides: IFocusManagerGroup
[mxmlc] scanning for overrides: IResourceBundle
[mxmlc] scanning for overrides: ResourceManagerImpl
[mxmlc] scanning for overrides: ResourceModuleInfo
[mxmlc] scanning for overrides: ResourceEventDispatcher
[mxmlc] scanning for overrides: ResourceBundleProxy
[mxmlc] scanning for overrides: GroupBase
[mxmlc] scanning for overrides: SkinnableComponent
[mxmlc] scanning for overrides: ButtonBase
[mxmlc] scanning for overrides: Button
[mxmlc] scanning for overrides: ErrorArray
[mxmlc] scanning for overrides: RunCodeEvent
[mxmlc] scanning for overrides: PasswordInputBead
[mxmlc] scanning for overrides: ITileLayout
[mxmlc] scanning for overrides: TileLayout
[mxmlc] scanning for overrides: LocaleUtils
[mxmlc] scanning for overrides: StringPadder
[mxmlc] scanning for overrides: UIDUtil
[mxmlc] scanning for overrides: IStroke
[mxmlc] scanning for overrides: CursorError
[mxmlc] scanning for overrides: SortError
[mxmlc] scanning for overrides: ISort
[mxmlc] scanning for overrides: Sort
[mxmlc] scanning for overrides: IXMLNotifiable
[mxmlc] scanning for overrides: XMLListAdapter
[mxmlc] scanning for overrides: FlexChildInfo
[mxmlc] scanning for overrides: BaseListData
[mxmlc] scanning for overrides: IFactory
[mxmlc] scanning for overrides: IUITextField
[mxmlc] scanning for overrides: UITextField
[mxmlc] scanning for overrides: CollectionEvent
[mxmlc] scanning for overrides: CollectionEventKind
[mxmlc] scanning for overrides: LocaleSorter
[mxmlc] scanning for overrides: LocaleID
[mxmlc] scanning for overrides: LocaleRegistry
[mxmlc] scanning for overrides: ResourceBundle
[mxmlc] scanning for overrides: ArrayUtil
[mxmlc] scanning for overrides: StringUtil
[mxmlc] scanning for overrides: UIDUtil
[mxmlc] scanning for overrides: DataGroup
[mxmlc] scanning for overrides: LayoutBase
[mxmlc] scanning for overrides: BasicLayout

Re: [DISCUSS] Release Apache Royale 0.9.6 RC1

2019-09-09 Thread Carlos Rovira
Hi Piotr,
I think MX test are failing for some months now, so don't think that the
fail is related to your changes.
I can't say so much since I don't know so much about that concrete part.
thanks

El vie., 6 sept. 2019 a las 16:29, Piotr Zarzycki (<
piotrzarzyck...@gmail.com>) escribió:

> Hi Carlos,
>
> IT depends on what commit MX is failing. I did branch for this RC couple of
> days ago. In that time I was seeing some commits to develop related to MX.
>
> Thanks,
> Piotr
>
> On Fri, Sep 6, 2019, 4:02 PM Carlos Rovira 
> wrote:
>
> > Hi Piotr,
> >
> > thanks. One question I have is: I think MX Test was failing, does it
> > affects the release or are not crucial to get the bits out?
> >
> > Thanks
> >
> > El vie., 6 sept. 2019 a las 13:10, Piotr Zarzycki (<
> > piotrzarzyck...@gmail.com>) escribió:
> >
> > > Hi Guys,
> > >
> > > I have upload manually ant artifacts. Please start reviewing stuff.
> What
> > if
> > > vote passes - Should we merge 0.9.6 tag to develop ?
> > >
> > > Thanks,
> > > Piotr
> > >
> > > pt., 6 wrz 2019 o 13:09 Apache Royale CI Server <
> > apacheroyal...@gmail.com>
> > > napisał(a):
> > >
> > > > This is the discussion thread.
> > > >
> > > > Thanks,
> > > > Piotr Zarzycki
> > >
> > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> > > Patreon: *https://www.patreon.com/piotrzarzycki
> > > *
> > >
> >
> >
> > --
> > Carlos Rovira
> > http://about.me/carlosrovira
> >
>


-- 
Carlos Rovira
http://about.me/carlosrovira


Re: [royale-compiler] branch develop updated: MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true

2019-09-09 Thread Josh Tynjala
I removed this file. Should be gone on both develop and release/0.9.6.

- Josh


On Mon, Sep 9, 2019 at 6:39 AM Josh Tynjala 
wrote:

> It's a project file created by VSCode. I didn't realize that I
> accidentally added it. It can be removed from the repo.
>
> - Josh
>
> On Saturday, September 7, 2019, Alex Harui 
> wrote:
> > Josh,
> >
> > What is the .factorypath file?  It is in the release package.  Should it
> even be in the repo?
> >
> > -Alex
> >
> > On 8/12/19, 11:12 AM, "joshtynj...@apache.org" 
> wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > joshtynjala pushed a commit to branch develop
> > in repository
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.gitdata=02%7C01%7Caharui%40adobe.com%7C8f2fb400e5d54f73082808d71f50a99b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637012303647260983sdata=W79nBsynNmvLQKY1tdcHgbR6K09oo%2FA%2F3z%2BRBb1Iq8E%3Dreserved=0
> >
> >
> > The following commit(s) were added to refs/heads/develop by this
> push:
> >  new f4f9898  MemberAccessEmitter: fixed issue where
> fully-qualified names were emitted as dynamic access with
> -js-dynamic-access-unknown-members=true
> > f4f9898 is described below
> >
> > commit f4f9898ad6f94c903615db5bfae691bfaac4a5f3
> > Author: Josh Tynjala 
> > AuthorDate: Mon Aug 12 11:12:34 2019 -0700
> >
> > MemberAccessEmitter: fixed issue where fully-qualified names
> were emitted as dynamic access with -js-dynamic-access-unknown-members=true
> >
> > Now, if a definition is resolved, and its parent definition is a
> package, just outputs the fully-qualified name instead of walking the full
> chain of member access
> > ---
> >  .../codegen/js/jx/MemberAccessEmitter.java |  13 ++-
> >  debugger/.factorypath  | 102
> +
> >  2 files changed, 111 insertions(+), 4 deletions(-)
> >
> > diff --git
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > index 741affb..cc0a892 100644
> > ---
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > +++
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > @@ -23,6 +23,7 @@ import
> org.apache.royale.compiler.codegen.ISubEmitter;
> >  import org.apache.royale.compiler.codegen.js.IJSEmitter;
> >  import org.apache.royale.compiler.constants.IASLanguageConstants;
> >  import org.apache.royale.compiler.definitions.IDefinition;
> > +import org.apache.royale.compiler.definitions.IPackageDefinition;
> >  import
> org.apache.royale.compiler.internal.codegen.as.ASEmitterTokens;
> >  import
> org.apache.royale.compiler.internal.codegen.js.JSEmitterTokens;
> >  import org.apache.royale.compiler.internal.codegen.js.JSSubEmitter;
> > @@ -32,7 +33,6 @@ import
> org.apache.royale.compiler.internal.codegen.js.royale.JSRoyaleEmitterToke
> >  import
> org.apache.royale.compiler.internal.codegen.js.goog.JSGoogEmitterTokens;
> >  import
> org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter.DatePropertiesGetters;
> >  import
> org.apache.royale.compiler.internal.definitions.AccessorDefinition;
> > -import
> org.apache.royale.compiler.internal.definitions.AppliedVectorDefinition;
> >  import
> org.apache.royale.compiler.internal.definitions.FunctionDefinition;
> >  import org.apache.royale.compiler.internal.projects.RoyaleJSProject;
> >  import org.apache.royale.compiler.internal.tree.as.*;
> > @@ -42,8 +42,6 @@ import org.apache.royale.compiler.tree.as.*;
> >  import
> org.apache.royale.compiler.tree.as.IOperatorNode.OperatorType;
> >  import org.apache.royale.compiler.utils.ASNodeUtils;
> >
> > -import javax.sound.midi.SysexMessage;
> > -
> >  public class MemberAccessEmitter extends JSSubEmitter implements
> >  ISubEmitter
> >  {
> > @@ -177,6 +175,13 @@ public class MemberAccessEmitter extends
> JSSubEmitter implements
> > return;
> > }
> >  }
> > +   else if(def.getParent() instanceof IPackageDefinition)
> > +   {
> > +   //this is a fully qualified name, and we should
> output it directly
> > +   //because we don't want it to be treated as
> dynamic access
> > +
>  write(fjs.formatQualifiedName(def.getQualifiedName()));
> > +   return;
> > +   }
> >  else if (def.getParent() != null &&
> >
> def.getParent().getQualifiedName().equals("Array"))
> >  {
> > @@ -260,7 +265,7 @@ public class MemberAccessEmitter 

Re: [royale-compiler] branch develop updated: MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true

2019-09-09 Thread Josh Tynjala
It's a project file created by VSCode. I didn't realize that I accidentally
added it. It can be removed from the repo.

- Josh

On Saturday, September 7, 2019, Alex Harui  wrote:
> Josh,
>
> What is the .factorypath file?  It is in the release package.  Should it
even be in the repo?
>
> -Alex
>
> On 8/12/19, 11:12 AM, "joshtynj...@apache.org" 
wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> joshtynjala pushed a commit to branch develop
> in repository
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.gitdata=02%7C01%7Caharui%40adobe.com%7C8f2fb400e5d54f73082808d71f50a99b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637012303647260983sdata=W79nBsynNmvLQKY1tdcHgbR6K09oo%2FA%2F3z%2BRBb1Iq8E%3Dreserved=0
>
>
> The following commit(s) were added to refs/heads/develop by this push:
>  new f4f9898  MemberAccessEmitter: fixed issue where
fully-qualified names were emitted as dynamic access with
-js-dynamic-access-unknown-members=true
> f4f9898 is described below
>
> commit f4f9898ad6f94c903615db5bfae691bfaac4a5f3
> Author: Josh Tynjala 
> AuthorDate: Mon Aug 12 11:12:34 2019 -0700
>
> MemberAccessEmitter: fixed issue where fully-qualified names were
emitted as dynamic access with -js-dynamic-access-unknown-members=true
>
> Now, if a definition is resolved, and its parent definition is a
package, just outputs the fully-qualified name instead of walking the full
chain of member access
> ---
>  .../codegen/js/jx/MemberAccessEmitter.java |  13 ++-
>  debugger/.factorypath  | 102
+
>  2 files changed, 111 insertions(+), 4 deletions(-)
>
> diff --git
a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> index 741affb..cc0a892 100644
> ---
a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> +++
b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> @@ -23,6 +23,7 @@ import
org.apache.royale.compiler.codegen.ISubEmitter;
>  import org.apache.royale.compiler.codegen.js.IJSEmitter;
>  import org.apache.royale.compiler.constants.IASLanguageConstants;
>  import org.apache.royale.compiler.definitions.IDefinition;
> +import org.apache.royale.compiler.definitions.IPackageDefinition;
>  import
org.apache.royale.compiler.internal.codegen.as.ASEmitterTokens;
>  import
org.apache.royale.compiler.internal.codegen.js.JSEmitterTokens;
>  import org.apache.royale.compiler.internal.codegen.js.JSSubEmitter;
> @@ -32,7 +33,6 @@ import
org.apache.royale.compiler.internal.codegen.js.royale.JSRoyaleEmitterToke
>  import
org.apache.royale.compiler.internal.codegen.js.goog.JSGoogEmitterTokens;
>  import
org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter.DatePropertiesGetters;
>  import
org.apache.royale.compiler.internal.definitions.AccessorDefinition;
> -import
org.apache.royale.compiler.internal.definitions.AppliedVectorDefinition;
>  import
org.apache.royale.compiler.internal.definitions.FunctionDefinition;
>  import org.apache.royale.compiler.internal.projects.RoyaleJSProject;
>  import org.apache.royale.compiler.internal.tree.as.*;
> @@ -42,8 +42,6 @@ import org.apache.royale.compiler.tree.as.*;
>  import org.apache.royale.compiler.tree.as.IOperatorNode.OperatorType;
>  import org.apache.royale.compiler.utils.ASNodeUtils;
>
> -import javax.sound.midi.SysexMessage;
> -
>  public class MemberAccessEmitter extends JSSubEmitter implements
>  ISubEmitter
>  {
> @@ -177,6 +175,13 @@ public class MemberAccessEmitter extends
JSSubEmitter implements
> return;
> }
>  }
> +   else if(def.getParent() instanceof IPackageDefinition)
> +   {
> +   //this is a fully qualified name, and we should
output it directly
> +   //because we don't want it to be treated as
dynamic access
> +
 write(fjs.formatQualifiedName(def.getQualifiedName()));
> +   return;
> +   }
>  else if (def.getParent() != null &&
>
def.getParent().getQualifiedName().equals("Array"))
>  {
> @@ -260,7 +265,7 @@ public class MemberAccessEmitter extends
JSSubEmitter implements
> getEmitter().emitClosureEnd(leftNode,
def);
> }
> return;
> -   }
> +   }
>  boolean isCustomNamespace = false;
>  if (def instanceof FunctionDefinition && node.getOperator()
== 

Build failed in Jenkins: royale-asjs_MXTests #1134

2019-09-09 Thread Apache Royale CI Server
See 


--
[...truncated 968.04 KB...]
[mxmlc] scanning for overrides: ObjectUtil
[mxmlc] scanning for overrides: SolidBorderUtil
[mxmlc] scanning for overrides: StringTrimmer
[mxmlc] scanning for overrides: StringUtil
[mxmlc] scanning for overrides: Timer
[mxmlc] scanning for overrides: UIUtils
[mxmlc] scanning for overrides: Effect
[mxmlc] scanning for overrides: Transition
[mxmlc] scanning for overrides: IFill
[mxmlc] scanning for overrides: SolidColor
[mxmlc] scanning for overrides: IExternalizable
[mxmlc] scanning for overrides: Proxy
[mxmlc] scanning for overrides: CursorBookmark
[mxmlc] scanning for overrides: ICollectionView
[mxmlc] scanning for overrides: IList
[mxmlc] scanning for overrides: IViewCursor
[mxmlc] scanning for overrides: ListCollectionView
[mxmlc] scanning for overrides: ListCollectionViewCursor
[mxmlc] scanning for overrides: ListCollectionViewBookmark
[mxmlc] scanning for overrides: ArrayCollection
[mxmlc] scanning for overrides: ArrayList
[mxmlc] scanning for overrides: XMLListCollection
[mxmlc] scanning for overrides: CanvasLayout
[mxmlc] scanning for overrides: Flex
[mxmlc] scanning for overrides: BoxDirection
[mxmlc] scanning for overrides: HBox
[mxmlc] scanning for overrides: PanelTitleBar
[mxmlc] scanning for overrides: DataGridColumn
[mxmlc] scanning for overrides: Button
[mxmlc] scanning for overrides: ISelectable
[mxmlc] scanning for overrides: CheckBox
[mxmlc] scanning for overrides: IFocusManagerComponent
[mxmlc] scanning for overrides: ComboBase
[mxmlc] scanning for overrides: ComboBox
[mxmlc] scanning for overrides: ScrollControlBase
[mxmlc] scanning for overrides: ListBase
[mxmlc] scanning for overrides: DataGrid
[mxmlc] scanning for overrides: DateField
[mxmlc] scanning for overrides: Label
[mxmlc] scanning for overrides: List
[mxmlc] scanning for overrides: MenuBar
[mxmlc] scanning for overrides: NumericStepper
[mxmlc] scanning for overrides: RadioButton
[mxmlc] scanning for overrides: RadioButtonGroup
[mxmlc] scanning for overrides: TextArea
[mxmlc] scanning for overrides: ITextInput
[mxmlc] scanning for overrides: TextInput
[mxmlc] scanning for overrides: ITextFieldFactory
[mxmlc] scanning for overrides: Singleton
[mxmlc] scanning for overrides: ItemClickEvent
[mxmlc] scanning for overrides: ListEvent
[mxmlc] scanning for overrides: MenuEvent
[mxmlc] scanning for overrides: MouseEvent
[mxmlc] scanning for overrides: PropertyChangeEventKind
[mxmlc] scanning for overrides: Matrix
[mxmlc] scanning for overrides: Matrix
[mxmlc] scanning for overrides: IFocusManagerComplexComponent
[mxmlc] scanning for overrides: IFocusManagerGroup
[mxmlc] scanning for overrides: IResourceBundle
[mxmlc] scanning for overrides: ResourceManagerImpl
[mxmlc] scanning for overrides: ResourceModuleInfo
[mxmlc] scanning for overrides: ResourceEventDispatcher
[mxmlc] scanning for overrides: ResourceBundleProxy
[mxmlc] scanning for overrides: GroupBase
[mxmlc] scanning for overrides: SkinnableComponent
[mxmlc] scanning for overrides: ButtonBase
[mxmlc] scanning for overrides: Button
[mxmlc] scanning for overrides: ErrorArray
[mxmlc] scanning for overrides: RunCodeEvent
[mxmlc] scanning for overrides: PasswordInputBead
[mxmlc] scanning for overrides: ITileLayout
[mxmlc] scanning for overrides: TileLayout
[mxmlc] scanning for overrides: LocaleUtils
[mxmlc] scanning for overrides: StringPadder
[mxmlc] scanning for overrides: UIDUtil
[mxmlc] scanning for overrides: IStroke
[mxmlc] scanning for overrides: CursorError
[mxmlc] scanning for overrides: SortError
[mxmlc] scanning for overrides: ISort
[mxmlc] scanning for overrides: Sort
[mxmlc] scanning for overrides: IXMLNotifiable
[mxmlc] scanning for overrides: XMLListAdapter
[mxmlc] scanning for overrides: FlexChildInfo
[mxmlc] scanning for overrides: BaseListData
[mxmlc] scanning for overrides: IFactory
[mxmlc] scanning for overrides: IUITextField
[mxmlc] scanning for overrides: UITextField
[mxmlc] scanning for overrides: CollectionEvent
[mxmlc] scanning for overrides: CollectionEventKind
[mxmlc] scanning for overrides: LocaleSorter
[mxmlc] scanning for overrides: LocaleID
[mxmlc] scanning for overrides: LocaleRegistry
[mxmlc] scanning for overrides: ResourceBundle
[mxmlc] scanning for overrides: ArrayUtil
[mxmlc] scanning for overrides: StringUtil
[mxmlc] scanning for overrides: UIDUtil
[mxmlc] scanning for overrides: DataGroup
[mxmlc] scanning for overrides: LayoutBase
[mxmlc] scanning for overrides: BasicLayout