Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Gabe Harbs
Question for (I think) Alex: How does this target work? What sets the ROYALE_DOWNLOAD_CACHE and what saves the files there? > On Feb 13, 2018, at 11:41 PM, Gabe Harbs wrote: > > I’m not sure I’m going to get to this tonight. If not, I’ll try to fix

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Gabe Harbs
I’m not sure I’m going to get to this tonight. If not, I’ll try to fix the builds first thing in the morning. I’m going to put back the unzipping of the externs and I’m replacing the specific ones which need editing. I should be able to fix both the ant and maven builds. Harbs > On Feb 13,

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Piotr Zarzycki
Where is the conclusion, cause I lost a bit track with that. What are you going to do next Harbs ? Should I still spent some time on Maven ? 2018-02-13 19:45 GMT+01:00 Gabe Harbs : > Ultimately, using those files is probably the way to go, but I’ll go back > to overwriting

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Gabe Harbs
Ultimately, using those files is probably the way to go, but I’ll go back to overwriting individual files for now… I’ll work on this a bit later. Harbs > On Feb 13, 2018, at 8:04 PM, Alex Harui wrote: > > I think we are working against an older closure-compiler.

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Alex Harui
I think we are working against an older closure-compiler. Volunteers are welcome to move us to the latest. I think we only patch a dozen files or so, so yes, even if you coned the originals to royale-extras, I thought you would just cherry pick the few files we need. IMO, you can do that and

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Gabe Harbs
BTW, when I switched to the newer extern files that turned upon some more bugs with them. I’m not sure at what point the newer externs are/will be included in the closure-compiler download, but more files will become an issue at whatever point they do. > On Feb 13, 2018, at 7:40 PM, Gabe

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Gabe Harbs
You mean just download the specific files we need? I figured we might as well just get all the files from the same repo. > On Feb 13, 2018, at 7:28 PM, Alex Harui wrote: > > I don't understand what is wrong with the way it worked. Isn't the idea > that you are

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Alex Harui
I don't understand what is wrong with the way it worked. Isn't the idea that you are overlaying files from royale-extras? Why can't the current build expand the externs from closure-compiler and then your stuff can overlay it? Thoughts? -Alex On 2/13/18, 5:26 AM, "Gabe Harbs"

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Gabe Harbs
Maybe. I didn’t realize changing the typedefs was going to end up being so complicated. I just changed the ant build to use git instead of svn. It takes about a minute the first time the repo is needed to be downloaded, but it’s pretty quick afterwards. I’m not sure which method is best for

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Piotr Zarzycki
Btw. Maybe you should move your changes to separate branch. We will have emails with fails for a long time now. Unless someone else look into the Maven. 2018-02-13 13:03 GMT+01:00 Gabe Harbs : > FWIW, here’s some other options for downloading a specific folder from >

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Gabe Harbs
FWIW, here’s some other options for downloading a specific folder from Github: https://stackoverflow.com/a/18194523 > On Feb 13, 2018, at 1:57 PM, Gabe Harbs wrote: > > If you use Git, you need to download the entire repo which includes all the > bits for the actual

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Gabe Harbs
If you use Git, you need to download the entire repo which includes all the bits for the actual compiler. Github supports svn checkouts as well which allows you to checkout a specific folder within a repo.[1] The following command will get the extern files we need from Github: svn checkout

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Piotr Zarzycki
Actually why are you talking about svn ? You mean GIT actually ? 2018-02-13 12:47 GMT+01:00 Gabe Harbs : > BTW, there’s a mojo for svn checkout: > https://maven.apache.org/scm/maven-scm-plugin/checkout-mojo.html < >

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Piotr Zarzycki
I will see what Maven offer in that matter. Can you raise Issue for me, cause I'm not sure if I will be able to do this today/tomorrow. Thanks, Piotr 2018-02-13 12:41 GMT+01:00 Gabe Harbs : > We need to download all the files from here: https://github.com/royale- >

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Gabe Harbs
BTW, there’s a mojo for svn checkout: https://maven.apache.org/scm/maven-scm-plugin/checkout-mojo.html Maybe you can use that. Harbs > On Feb 13, 2018, at 1:41 PM, Gabe Harbs wrote: > > We need to

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Piotr Zarzycki
Can we avoid using svn ? Or it was used before ? I'm not familiar with that logic. 2018-02-13 12:37 GMT+01:00 Harbs : > We need to add svn checkout of the externs like I did in the ant script. > > > On Feb 13, 2018, at 1:36 PM, Apache Jenkins Server < >

Re: [MAVEN-BUILD] Royale-typedefs - Build # 34 - Failure

2018-02-13 Thread Harbs
We need to add svn checkout of the externs like I did in the ant script. > On Feb 13, 2018, at 1:36 PM, Apache Jenkins Server > wrote: > > The Apache Jenkins build system has built Royale-typedefs (build #34) > > Status: Failure > > Check console output at