Re: [royale-asjs] 01/06: RoyaleArrayLike support (IArrayList and BinaryData)

2019-10-15 Thread Josh Tynjala
Thanks, Greg!

--
Josh Tynjala
Bowler Hat LLC 


On Mon, Oct 14, 2019 at 5:08 PM Greg Dove  wrote:

> Thanks for bringing that to my attention, Josh. it should be fixed now (I
> tested with your example, thanks for that).
>
> On Tue, Oct 15, 2019 at 10:31 AM Greg Dove  wrote:
>
> >
> > Hi Josh, thanks, I will look into that today.
> >
> >
> > On Tue, Oct 15, 2019 at 10:30 AM Josh Tynjala 
> > wrote:
> >
> >> Hey Greg,
> >>
> >> Starting with the commit, there are times when compilation gets stuck in
> >> an infinite loop. It should be possible to reproduce using the following
> >> code:
> >>
> >> for each(var key:Object in Fake.hello)
> >> {
> >> }
> >>
> >> "Fake" is a class that does not exist. It should result in an error, but
> >> the compiler seems to get stuck trying to resolve it over and over
> again.
> >>
> >> - Josh
> >>
> >> On 2019/10/02 08:39:35, gregd...@apache.org wrote:
> >> > This is an automated email from the ASF dual-hosted git repository.
> >> >
> >> > gregdove pushed a commit to branch develop
> >> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >> >
> >> > commit e52954b22a4599c75ba242955273627867e00e4d
> >> > Author: greg-dove 
> >> > AuthorDate: Sun Sep 29 15:16:21 2019 +1300
> >> >
> >> > RoyaleArrayLike support (IArrayList and BinaryData)
> >> > ---
> >> >  frameworks/projects/Collections/pom.xml|  14 ++
> >> >  .../src/main/config/compile-swf-config.xml |   1 +
> >> >  .../src/main/royale/CollectionsClasses.as  |   2 +
> >> >  .../org/apache/royale/collections/ArrayList.as |   2 +-
> >> >  .../org/apache/royale/collections/IArrayList.as|  13 +-
> >> >  frameworks/projects/Core/pom.xml   |  19 +-
> >> >  .../Core/src/main/config/compile-swf-config.xml|   6 +-
> >> >  .../projects/Core/src/main/royale/CoreClasses.as   |   3 +
> >> >  .../royale/org/apache/royale/utils/BinaryData.as   |  11 +-
> >> >  .../Language/src/main/royale/LanguageClasses.as|   2 +-
> >> >  .../apache/royale/language/iterator/arrayLike.as   |  73 +++
> >> >  .../main/royale/flexUnitTests/LanguageTester.as|   8 +-
> >> >  .../language/LanguageTesterTestArraylikeGetSet.as  | 227
> >> +
> >> >  .../language/LanguageTesterTestForEach.as  | 205
> >> +++
> >> >  .../language/support/checkArrayLikeFunc.as |  30 +--
> >> >  15 files changed, 587 insertions(+), 29 deletions(-)
> >> >
> >> > diff --git a/frameworks/projects/Collections/pom.xml
> >> b/frameworks/projects/Collections/pom.xml
> >> > index a105423..59cb218 100644
> >> > --- a/frameworks/projects/Collections/pom.xml
> >> > +++ b/frameworks/projects/Collections/pom.xml
> >> > @@ -60,6 +60,20 @@
> >> >
> >> >  
> >> >org.apache.royale.framework
> >> > +  Language
> >> > +  0.9.6-SNAPSHOT
> >> > +  swc
> >> > +  swf
> >> > +
> >> > +
> >> > +  org.apache.royale.framework
> >> > +  Language
> >> > +  0.9.6-SNAPSHOT
> >> > +  swc
> >> > +  js
> >> > +
> >> > +
> >> > +  org.apache.royale.framework
> >> >Core
> >> >0.9.6-SNAPSHOT
> >> >swc
> >> > diff --git
> >> a/frameworks/projects/Collections/src/main/config/compile-swf-config.xml
> >> b/frameworks/projects/Collections/src/main/config/compile-swf-config.xml
> >> > index 6116aec..1c00110 100644
> >> > ---
> >> a/frameworks/projects/Collections/src/main/config/compile-swf-config.xml
> >> > +++
> >> b/frameworks/projects/Collections/src/main/config/compile-swf-config.xml
> >> > @@ -31,6 +31,7 @@
> >> >  
> >> >
> >>
> ${env.AIR_HOME}/frameworks/libs/air/airglobal.swc
> >> >  ../../../../../libs/Core.swc
> >> > +
> >> ../../../../../libs/Language.swc
> >> >  
> >> >
> >> >   
> >> > diff --git
> >> a/frameworks/projects/Collections/src/main/royale/CollectionsClasses.as
> >> b/frameworks/projects/Collections/src/main/royale/CollectionsClasses.as
> >> > index fe946df..ecc1033 100644
> >> > ---
> >> a/frameworks/projects/Collections/src/main/royale/CollectionsClasses.as
> >> > +++
> >> b/frameworks/projects/Collections/src/main/royale/CollectionsClasses.as
> >> > @@ -43,6 +43,8 @@ internal class CollectionsClasses
> >> >   import org.apache.royale.collections.SortField; SortField;
> >> >   import org.apache.royale.collections.SortFieldCompareTypes;
> >> SortFieldCompareTypes;
> >> >   import org.apache.royale.collections.CompareUtils; CompareUtils;
> >> > +
> >> > + import org.apache.royale.language.iterator.arrayLike;arrayLike;
> >> >
> >> >  }
> >> >
> >> > diff --git
> >>
> a/frameworks/projects/Collections/src/main/royale/org/apache/royale/collections/ArrayList.as
> >>
> b/frameworks/projects/Collections/src/main/royale/org/apache/royale/collections/ArrayList.as
> >> > index 38164aa..75ea856 100644
> >> > ---
> >>
> 

Re: [royale-asjs] 01/06: RoyaleArrayLike support (IArrayList and BinaryData)

2019-10-14 Thread Greg Dove
Thanks for bringing that to my attention, Josh. it should be fixed now (I
tested with your example, thanks for that).

On Tue, Oct 15, 2019 at 10:31 AM Greg Dove  wrote:

>
> Hi Josh, thanks, I will look into that today.
>
>
> On Tue, Oct 15, 2019 at 10:30 AM Josh Tynjala 
> wrote:
>
>> Hey Greg,
>>
>> Starting with the commit, there are times when compilation gets stuck in
>> an infinite loop. It should be possible to reproduce using the following
>> code:
>>
>> for each(var key:Object in Fake.hello)
>> {
>> }
>>
>> "Fake" is a class that does not exist. It should result in an error, but
>> the compiler seems to get stuck trying to resolve it over and over again.
>>
>> - Josh
>>
>> On 2019/10/02 08:39:35, gregd...@apache.org wrote:
>> > This is an automated email from the ASF dual-hosted git repository.
>> >
>> > gregdove pushed a commit to branch develop
>> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>> >
>> > commit e52954b22a4599c75ba242955273627867e00e4d
>> > Author: greg-dove 
>> > AuthorDate: Sun Sep 29 15:16:21 2019 +1300
>> >
>> > RoyaleArrayLike support (IArrayList and BinaryData)
>> > ---
>> >  frameworks/projects/Collections/pom.xml|  14 ++
>> >  .../src/main/config/compile-swf-config.xml |   1 +
>> >  .../src/main/royale/CollectionsClasses.as  |   2 +
>> >  .../org/apache/royale/collections/ArrayList.as |   2 +-
>> >  .../org/apache/royale/collections/IArrayList.as|  13 +-
>> >  frameworks/projects/Core/pom.xml   |  19 +-
>> >  .../Core/src/main/config/compile-swf-config.xml|   6 +-
>> >  .../projects/Core/src/main/royale/CoreClasses.as   |   3 +
>> >  .../royale/org/apache/royale/utils/BinaryData.as   |  11 +-
>> >  .../Language/src/main/royale/LanguageClasses.as|   2 +-
>> >  .../apache/royale/language/iterator/arrayLike.as   |  73 +++
>> >  .../main/royale/flexUnitTests/LanguageTester.as|   8 +-
>> >  .../language/LanguageTesterTestArraylikeGetSet.as  | 227
>> +
>> >  .../language/LanguageTesterTestForEach.as  | 205
>> +++
>> >  .../language/support/checkArrayLikeFunc.as |  30 +--
>> >  15 files changed, 587 insertions(+), 29 deletions(-)
>> >
>> > diff --git a/frameworks/projects/Collections/pom.xml
>> b/frameworks/projects/Collections/pom.xml
>> > index a105423..59cb218 100644
>> > --- a/frameworks/projects/Collections/pom.xml
>> > +++ b/frameworks/projects/Collections/pom.xml
>> > @@ -60,6 +60,20 @@
>> >
>> >  
>> >org.apache.royale.framework
>> > +  Language
>> > +  0.9.6-SNAPSHOT
>> > +  swc
>> > +  swf
>> > +
>> > +
>> > +  org.apache.royale.framework
>> > +  Language
>> > +  0.9.6-SNAPSHOT
>> > +  swc
>> > +  js
>> > +
>> > +
>> > +  org.apache.royale.framework
>> >Core
>> >0.9.6-SNAPSHOT
>> >swc
>> > diff --git
>> a/frameworks/projects/Collections/src/main/config/compile-swf-config.xml
>> b/frameworks/projects/Collections/src/main/config/compile-swf-config.xml
>> > index 6116aec..1c00110 100644
>> > ---
>> a/frameworks/projects/Collections/src/main/config/compile-swf-config.xml
>> > +++
>> b/frameworks/projects/Collections/src/main/config/compile-swf-config.xml
>> > @@ -31,6 +31,7 @@
>> >  
>> >
>> ${env.AIR_HOME}/frameworks/libs/air/airglobal.swc
>> >  ../../../../../libs/Core.swc
>> > +
>> ../../../../../libs/Language.swc
>> >  
>> >
>> >   
>> > diff --git
>> a/frameworks/projects/Collections/src/main/royale/CollectionsClasses.as
>> b/frameworks/projects/Collections/src/main/royale/CollectionsClasses.as
>> > index fe946df..ecc1033 100644
>> > ---
>> a/frameworks/projects/Collections/src/main/royale/CollectionsClasses.as
>> > +++
>> b/frameworks/projects/Collections/src/main/royale/CollectionsClasses.as
>> > @@ -43,6 +43,8 @@ internal class CollectionsClasses
>> >   import org.apache.royale.collections.SortField; SortField;
>> >   import org.apache.royale.collections.SortFieldCompareTypes;
>> SortFieldCompareTypes;
>> >   import org.apache.royale.collections.CompareUtils; CompareUtils;
>> > +
>> > + import org.apache.royale.language.iterator.arrayLike;arrayLike;
>> >
>> >  }
>> >
>> > diff --git
>> a/frameworks/projects/Collections/src/main/royale/org/apache/royale/collections/ArrayList.as
>> b/frameworks/projects/Collections/src/main/royale/org/apache/royale/collections/ArrayList.as
>> > index 38164aa..75ea856 100644
>> > ---
>> a/frameworks/projects/Collections/src/main/royale/org/apache/royale/collections/ArrayList.as
>> > +++
>> b/frameworks/projects/Collections/src/main/royale/org/apache/royale/collections/ArrayList.as
>> > @@ -34,7 +34,6 @@ package org.apache.royale.collections
>> >   import flash.utils.IDataInput;
>> >   import flash.utils.IDataOutput;
>> >   }
>> > -
>> >
>> >  //--
>> >  //  Events
>> > @@ 

Re: [royale-asjs] 01/06: RoyaleArrayLike support (IArrayList and BinaryData)

2019-10-14 Thread Greg Dove
Hi Josh, thanks, I will look into that today.


On Tue, Oct 15, 2019 at 10:30 AM Josh Tynjala 
wrote:

> Hey Greg,
>
> Starting with the commit, there are times when compilation gets stuck in
> an infinite loop. It should be possible to reproduce using the following
> code:
>
> for each(var key:Object in Fake.hello)
> {
> }
>
> "Fake" is a class that does not exist. It should result in an error, but
> the compiler seems to get stuck trying to resolve it over and over again.
>
> - Josh
>
> On 2019/10/02 08:39:35, gregd...@apache.org wrote:
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > gregdove pushed a commit to branch develop
> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >
> > commit e52954b22a4599c75ba242955273627867e00e4d
> > Author: greg-dove 
> > AuthorDate: Sun Sep 29 15:16:21 2019 +1300
> >
> > RoyaleArrayLike support (IArrayList and BinaryData)
> > ---
> >  frameworks/projects/Collections/pom.xml|  14 ++
> >  .../src/main/config/compile-swf-config.xml |   1 +
> >  .../src/main/royale/CollectionsClasses.as  |   2 +
> >  .../org/apache/royale/collections/ArrayList.as |   2 +-
> >  .../org/apache/royale/collections/IArrayList.as|  13 +-
> >  frameworks/projects/Core/pom.xml   |  19 +-
> >  .../Core/src/main/config/compile-swf-config.xml|   6 +-
> >  .../projects/Core/src/main/royale/CoreClasses.as   |   3 +
> >  .../royale/org/apache/royale/utils/BinaryData.as   |  11 +-
> >  .../Language/src/main/royale/LanguageClasses.as|   2 +-
> >  .../apache/royale/language/iterator/arrayLike.as   |  73 +++
> >  .../main/royale/flexUnitTests/LanguageTester.as|   8 +-
> >  .../language/LanguageTesterTestArraylikeGetSet.as  | 227
> +
> >  .../language/LanguageTesterTestForEach.as  | 205
> +++
> >  .../language/support/checkArrayLikeFunc.as |  30 +--
> >  15 files changed, 587 insertions(+), 29 deletions(-)
> >
> > diff --git a/frameworks/projects/Collections/pom.xml
> b/frameworks/projects/Collections/pom.xml
> > index a105423..59cb218 100644
> > --- a/frameworks/projects/Collections/pom.xml
> > +++ b/frameworks/projects/Collections/pom.xml
> > @@ -60,6 +60,20 @@
> >
> >  
> >org.apache.royale.framework
> > +  Language
> > +  0.9.6-SNAPSHOT
> > +  swc
> > +  swf
> > +
> > +
> > +  org.apache.royale.framework
> > +  Language
> > +  0.9.6-SNAPSHOT
> > +  swc
> > +  js
> > +
> > +
> > +  org.apache.royale.framework
> >Core
> >0.9.6-SNAPSHOT
> >swc
> > diff --git
> a/frameworks/projects/Collections/src/main/config/compile-swf-config.xml
> b/frameworks/projects/Collections/src/main/config/compile-swf-config.xml
> > index 6116aec..1c00110 100644
> > ---
> a/frameworks/projects/Collections/src/main/config/compile-swf-config.xml
> > +++
> b/frameworks/projects/Collections/src/main/config/compile-swf-config.xml
> > @@ -31,6 +31,7 @@
> >  
> >
> ${env.AIR_HOME}/frameworks/libs/air/airglobal.swc
> >  ../../../../../libs/Core.swc
> > +
> ../../../../../libs/Language.swc
> >  
> >
> >   
> > diff --git
> a/frameworks/projects/Collections/src/main/royale/CollectionsClasses.as
> b/frameworks/projects/Collections/src/main/royale/CollectionsClasses.as
> > index fe946df..ecc1033 100644
> > ---
> a/frameworks/projects/Collections/src/main/royale/CollectionsClasses.as
> > +++
> b/frameworks/projects/Collections/src/main/royale/CollectionsClasses.as
> > @@ -43,6 +43,8 @@ internal class CollectionsClasses
> >   import org.apache.royale.collections.SortField; SortField;
> >   import org.apache.royale.collections.SortFieldCompareTypes;
> SortFieldCompareTypes;
> >   import org.apache.royale.collections.CompareUtils; CompareUtils;
> > +
> > + import org.apache.royale.language.iterator.arrayLike;arrayLike;
> >
> >  }
> >
> > diff --git
> a/frameworks/projects/Collections/src/main/royale/org/apache/royale/collections/ArrayList.as
> b/frameworks/projects/Collections/src/main/royale/org/apache/royale/collections/ArrayList.as
> > index 38164aa..75ea856 100644
> > ---
> a/frameworks/projects/Collections/src/main/royale/org/apache/royale/collections/ArrayList.as
> > +++
> b/frameworks/projects/Collections/src/main/royale/org/apache/royale/collections/ArrayList.as
> > @@ -34,7 +34,6 @@ package org.apache.royale.collections
> >   import flash.utils.IDataInput;
> >   import flash.utils.IDataOutput;
> >   }
> > -
> >
> >  //--
> >  //  Events
> > @@ -90,6 +89,7 @@ package org.apache.royale.collections
> >*  @productversion Royale 0.0
> >*/
> >   [Event(name="itemUpdated",
> type="org.apache.royale.events.CollectionEvent")]
> > +
> >
> >  /**
> >   *  The ArrayList class provides an event-driven wrapper for the
> > diff