Re: [royale-asjs] branch develop updated: Fix issue where setting "href" in a custom item renderer based on FooterLinkItemRenderer causes NPE

Ahh Ok! Let me explain. If you create your custom item renderer something like that [1] and set there href - without that null check you will have Null Pointer Exception. If you have some other idea how to resolve that I would be open to change that! [1] https://paste.apache.org/emQl Piotr

Re: [royale-asjs] branch develop updated: Fix issue where setting "href" in a custom item renderer based on FooterLinkItemRenderer causes NPE

I mean that I don’t understand why you added the null checking. That seems like "just in case". I also don’t understand how a Foot*Link*ItemRenderer could be missing a link element. > On Oct 27, 2017, at 12:13 AM, Piotr Zarzycki > wrote: > > Hi Harbs, > > You

Re: [royale-asjs] branch develop updated: Fix issue where setting "href" in a custom item renderer based on FooterLinkItemRenderer causes NPE

Hi Harbs, You suggesting remove this part [1], and leave to the user setup it if he want to ? That is what you mean ? [1] https://paste.apache.org/8F4x Piotr 2017-10-26 23:07 GMT+02:00 Harbs : > Isn’t this "just in case” code? > > Why doesn’t the subclass just override

Re: [royale-asjs] branch develop updated: Fix issue where setting "href" in a custom item renderer based on FooterLinkItemRenderer causes NPE

Isn’t this "just in case” code? Why doesn’t the subclass just override the data setter if it doesn’t have a link? (and why doesn’t it have one?) Harbs > On Oct 26, 2017, at 11:45 PM, pio...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > piotrz