RE: [royale-asjs] branch feature/MXRoyale updated: Update SystemManager.as
Hi Alex,
SHMALIB and MainFlexApp were two separate Projects. I shared API report for
both separately. But, [1] contains API's for MainFlexApp only. [2] is updated
API's List
[1] https://github.com/apache/royale-asjs/wiki/Emulation-Components
[2] https://www.dropbox.com/s/n480v72qztrp1lq/updatedAPI.txt?dl=0
Thanks,
Alina
-Original Message-
From: Alex Harui [mailto:aha...@adobe.com.INVALID]
Sent: Tuesday, July 24, 2018 8:46 AM
To: dev@royale.apache.org; comm...@royale.apache.org
Subject: Re: [royale-asjs] branch feature/MXRoyale updated: Update
SystemManager.as
Hi Alina,
Why are these changes being made? I don't see rawChildren in the API report,
and UIComponent probably won't be allowed in SystemManager. Did the API-report
miss these APIs?
Thanks,
-Alex
On 7/20/18, 4:42 AM, "alinak...@apache.org" wrote:
This is an automated email from the ASF dual-hosted git repository.
alinakazi pushed a commit to branch feature/MXRoyale
in repository
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.gitdata=02%7C01%7Caharui%40adobe.com%7C878ea8494fe74d48e8f108d5ee35edb8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636676837742598979sdata=cF4%2BAwHXXZFLulvRadx%2BjxsCDgnviWyKjTf%2BfGd2bIc%3Dreserved=0
The following commit(s) were added to refs/heads/feature/MXRoyale by this
push:
new bfaf72d Update SystemManager.as
bfaf72d is described below
commit bfaf72d42f0f7976f876491f4c47105a70d942e4
Author: alinakazi
AuthorDate: Fri Jul 20 16:42:50 2018 +0500
Update SystemManager.as
---
.../src/main/royale/mx/managers/SystemManager.as | 19
++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git
a/frameworks/projects/MXRoyale/src/main/royale/mx/managers/SystemManager.as
b/frameworks/projects/MXRoyale/src/main/royale/mx/managers/SystemManager.as
index 2277071..46cf4d1 100644
---
a/frameworks/projects/MXRoyale/src/main/royale/mx/managers/SystemManager.as
+++
b/frameworks/projects/MXRoyale/src/main/royale/mx/managers/SystemManager.as
@@ -94,9 +94,9 @@ use namespace mx_internal;
import mx.core.IChildList;
import mx.core.IFlexDisplayObject;
import mx.core.IUIComponent;
-
+import mx.core.UIComponent;
import org.apache.royale.core.IUIBase;
-import org.apache.royale.events.IEventDispatcher;
+import org.apache.royale.events.IEventDispatcher;
//--
// Events
@@ -1286,7 +1286,7 @@ public class SystemManager extends SystemManagerBase
implements ISystemManager,
* Storage for the rawChildren property.
*/
// private var _rawChildren:SystemRawChildrenList;
-
+ private var _rawChildren:IChildList;
/**
* @inheritDoc
*
@@ -1295,18 +1295,18 @@ public class SystemManager extends
SystemManagerBase implements ISystemManager,
* @playerversion AIR 1.1
* @productversion Royale 0.9.4
*/
-/*
+
public function get rawChildren():IChildList
{
//if (!topLevel)
// return _topLevelSystemManager.rawChildren;
- if (!_rawChildren)
-_rawChildren = new SystemRawChildrenList(this);
+ /* if (!_rawChildren)
+_rawChildren = new SystemRawChildrenList(this); */
return _rawChildren;
}
-*/
+
//--
// screen
@@ -3336,9 +3336,10 @@ public class SystemManager extends SystemManagerBase
implements ISystemManager,
* @playerversion AIR 1.1
* @productversion Royale 0.9.4
*/
-public function getSandboxRoot():Object
+public function getSandboxRoot():UIComponent
{
- return this;
+var temp:UIComponent;
+ return temp;
// work our say up the parent chain to the root. This way we
// don't have to rely on this object being added to the stage.
/* var sm:ISystemManager = this;
Re: [royale-asjs] branch feature/MXRoyale updated: Update SystemManager.as
Hi Alina,
Why are these changes being made? I don't see rawChildren in the API report,
and UIComponent probably won't be allowed in SystemManager. Did the API-report
miss these APIs?
Thanks,
-Alex
On 7/20/18, 4:42 AM, "alinak...@apache.org" wrote:
This is an automated email from the ASF dual-hosted git repository.
alinakazi pushed a commit to branch feature/MXRoyale
in repository
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.gitdata=02%7C01%7Caharui%40adobe.com%7C878ea8494fe74d48e8f108d5ee35edb8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636676837742598979sdata=cF4%2BAwHXXZFLulvRadx%2BjxsCDgnviWyKjTf%2BfGd2bIc%3Dreserved=0
The following commit(s) were added to refs/heads/feature/MXRoyale by this
push:
new bfaf72d Update SystemManager.as
bfaf72d is described below
commit bfaf72d42f0f7976f876491f4c47105a70d942e4
Author: alinakazi
AuthorDate: Fri Jul 20 16:42:50 2018 +0500
Update SystemManager.as
---
.../src/main/royale/mx/managers/SystemManager.as | 19
++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git
a/frameworks/projects/MXRoyale/src/main/royale/mx/managers/SystemManager.as
b/frameworks/projects/MXRoyale/src/main/royale/mx/managers/SystemManager.as
index 2277071..46cf4d1 100644
---
a/frameworks/projects/MXRoyale/src/main/royale/mx/managers/SystemManager.as
+++
b/frameworks/projects/MXRoyale/src/main/royale/mx/managers/SystemManager.as
@@ -94,9 +94,9 @@ use namespace mx_internal;
import mx.core.IChildList;
import mx.core.IFlexDisplayObject;
import mx.core.IUIComponent;
-
+import mx.core.UIComponent;
import org.apache.royale.core.IUIBase;
-import org.apache.royale.events.IEventDispatcher;
+import org.apache.royale.events.IEventDispatcher;
//--
// Events
@@ -1286,7 +1286,7 @@ public class SystemManager extends SystemManagerBase
implements ISystemManager,
* Storage for the rawChildren property.
*/
// private var _rawChildren:SystemRawChildrenList;
-
+ private var _rawChildren:IChildList;
/**
* @inheritDoc
*
@@ -1295,18 +1295,18 @@ public class SystemManager extends
SystemManagerBase implements ISystemManager,
* @playerversion AIR 1.1
* @productversion Royale 0.9.4
*/
-/*
+
public function get rawChildren():IChildList
{
//if (!topLevel)
// return _topLevelSystemManager.rawChildren;
- if (!_rawChildren)
-_rawChildren = new SystemRawChildrenList(this);
+ /* if (!_rawChildren)
+_rawChildren = new SystemRawChildrenList(this); */
return _rawChildren;
}
-*/
+
//--
// screen
@@ -3336,9 +3336,10 @@ public class SystemManager extends SystemManagerBase
implements ISystemManager,
* @playerversion AIR 1.1
* @productversion Royale 0.9.4
*/
-public function getSandboxRoot():Object
+public function getSandboxRoot():UIComponent
{
- return this;
+var temp:UIComponent;
+ return temp;
// work our say up the parent chain to the root. This way we
// don't have to rely on this object being added to the stage.
/* var sm:ISystemManager = this;
Re: [royale-asjs] branch feature/MXRoyale updated: Update SystemManager.as
Hi Alina,
Why was this change made? I don't see rawChildren in the API list. I am
taking it out again as it broke some tests. Let me know why you need it before
adding it.
Thanks,
-Alex
On 6/27/18, 12:26 AM, "alinak...@apache.org" wrote:
This is an automated email from the ASF dual-hosted git repository.
alinakazi pushed a commit to branch feature/MXRoyale
in repository
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git=02%7C01%7Caharui%40adobe.com%7C4b3ed7c5b1db414b784c08d5dbff4da3%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636656811921194148=lnI5DxFY6JqsEE38dy5GNC%2BeM%2BAiVaSqmAgxh9Fs5Eg%3D=0
The following commit(s) were added to refs/heads/feature/MXRoyale by this
push:
new b9a9b54 Update SystemManager.as
b9a9b54 is described below
commit b9a9b54082f28e2a099a584eca12adbe3c925069
Author: alinakazi
AuthorDate: Wed Jun 27 12:26:26 2018 +0500
Update SystemManager.as
---
.../MXRoyale/src/main/royale/mx/managers/SystemManager.as| 9
+
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git
a/frameworks/projects/MXRoyale/src/main/royale/mx/managers/SystemManager.as
b/frameworks/projects/MXRoyale/src/main/royale/mx/managers/SystemManager.as
index db2ad6d..14fa67f 100644
---
a/frameworks/projects/MXRoyale/src/main/royale/mx/managers/SystemManager.as
+++
b/frameworks/projects/MXRoyale/src/main/royale/mx/managers/SystemManager.as
@@ -1296,16 +1296,17 @@ public class SystemManager
* @playerversion AIR 1.1
* @productversion Royale 0.9.4
*/
-/* public function get rawChildren():IChildList
+ public function get rawChildren():IChildList
{
//if (!topLevel)
// return _topLevelSystemManager.rawChildren;
-if (!_rawChildren)
+ /* if (!_rawChildren)
_rawChildren = new SystemRawChildrenList(this);
-return _rawChildren;
-} */
+return _rawChildren; */
+ return null;
+}
//--
// screen
