Re: XML Problem with ignoreWhiteSpace=false
Hi Yishay, thanks for letting me know that all is well in your project. I was getting a little concerned that the changes might have impacted you, it is something I have been through a few times in the past so I know what it is like. I will look into that new issue over my weekend if it is not urgent. I might be able to get there sooner, but I am working on something else which I need to finish up asap, so can't promise that. My first thought would be that it should not be related to changes, but if it wasn't happening before the changes then I definitely need to check that. I would have expected that to be something handled by the native DomParser because it seems like it is related to whitespace between attributes in the same node, but I can't rule it out because I did add some changes to the whitespace handling in general. Before you addressed it with the change you made, were you able to verify that it was happening in different browsers? If you didn't, don't worry about doing that. I will check that aspect as well if I need to when I look into it. I have been testing across the main browsers on windows (mainly to include IE11/Edge which seem to be outliers in terms of the native parsing results). I have not yet tested on Safari/MacOS. On Wed, Jun 26, 2019 at 10:12 PM Yishay Weiss wrote: > Hi Greg, > > > > Our app is working with the latest XML fixes. Thanks for taking care of > the issues. It was a headache but we actually found some bugs in our code > in the process. > > > > If you have time, maybe take a look at this different issue [1]. Do you > think it could be related to any of your changes? > > > > Thanks. > > > > [1] > https://github.com/apache/royale-asjs/commit/4b87997aa14d60bba657356a3dd17b6c6a7a4d80 > > > > > From: Greg Dove > Sent: Monday, June 24, 2019 6:59:09 AM > To: dev@royale.apache.org > Subject: Re: XML Problem with ignoreWhiteSpace=false > > Yishay, a few other issues became apparent as I worked on that. So I added > tests for them and fixed them also. > > I can confirm that a lot of the older implementation was failing in many of > the tests, because I reverted to the older implementation locally and > checked against the same tests (which run in parallel with swf). So I do > know that this represents progress. > But what I cannot know is if there are other things that do not work after > these changes outside of the current test coverage (which is why it is > essential to enhance that coverage over time). > However I also have no desire to cause many sudden changes needed in your > project that we could let you manage more gradually if this is causing a > problem, because I have a feeling that you and Harbs are the main users of > XML at the moment. > If you are still encountering problems after my latest changes then we > could revert the XML project to how it was before all my recent changes and > I could move everything to a branch. > I haven't done that to date simply because in terms of what I can see in > the tests so far, I can only consider it to be progress in terms of getting > the implementation closer (than it was before) to the original as3 > XML/XMList. But as I said... that is only as good as the test coverage. > Anyhow, let me know what you think... I have fingers crossed that the > latest changes should address things for you. > Greg > > > On Mon, Jun 24, 2019 at 12:35 AM Greg Dove wrote: > > > Hi Yishay, thanks for the new details. That's another bug. I have a local > > fix for that now, and new tests to cover this and more variations of the > > document level parsing. > > It's late for me now, so I will check everything thoroughly and push the > > fix in my morning. > > > > > > > > On Sun, Jun 23, 2019 at 9:57 PM Yishay Weiss > > wrote: > > > >> Hi Greg, > >> > >> I’m still having issues with xml that were not there before. Can you see > >> why this [1] app, where my.xml is [2] is giving me an exception [3]? > >> > >> > >> > >> [1] https://paste.apache.org/ld1L > >> [2] https://paste.apache.org/d6VX > >> [3] https://paste.apache.org/qpub > >> > >> Yishay > >> > > >
RE: XML Problem with ignoreWhiteSpace=false
Hi Greg, Our app is working with the latest XML fixes. Thanks for taking care of the issues. It was a headache but we actually found some bugs in our code in the process. If you have time, maybe take a look at this different issue [1]. Do you think it could be related to any of your changes? Thanks. [1] https://github.com/apache/royale-asjs/commit/4b87997aa14d60bba657356a3dd17b6c6a7a4d80 From: Greg Dove Sent: Monday, June 24, 2019 6:59:09 AM To: dev@royale.apache.org Subject: Re: XML Problem with ignoreWhiteSpace=false Yishay, a few other issues became apparent as I worked on that. So I added tests for them and fixed them also. I can confirm that a lot of the older implementation was failing in many of the tests, because I reverted to the older implementation locally and checked against the same tests (which run in parallel with swf). So I do know that this represents progress. But what I cannot know is if there are other things that do not work after these changes outside of the current test coverage (which is why it is essential to enhance that coverage over time). However I also have no desire to cause many sudden changes needed in your project that we could let you manage more gradually if this is causing a problem, because I have a feeling that you and Harbs are the main users of XML at the moment. If you are still encountering problems after my latest changes then we could revert the XML project to how it was before all my recent changes and I could move everything to a branch. I haven't done that to date simply because in terms of what I can see in the tests so far, I can only consider it to be progress in terms of getting the implementation closer (than it was before) to the original as3 XML/XMList. But as I said... that is only as good as the test coverage. Anyhow, let me know what you think... I have fingers crossed that the latest changes should address things for you. Greg On Mon, Jun 24, 2019 at 12:35 AM Greg Dove wrote: > Hi Yishay, thanks for the new details. That's another bug. I have a local > fix for that now, and new tests to cover this and more variations of the > document level parsing. > It's late for me now, so I will check everything thoroughly and push the > fix in my morning. > > > > On Sun, Jun 23, 2019 at 9:57 PM Yishay Weiss > wrote: > >> Hi Greg, >> >> I’m still having issues with xml that were not there before. Can you see >> why this [1] app, where my.xml is [2] is giving me an exception [3]? >> >> >> >> [1] https://paste.apache.org/ld1L >> [2] https://paste.apache.org/d6VX >> [3] https://paste.apache.org/qpub >> >> Yishay >> >
Re: XML Problem with ignoreWhiteSpace=false
Yishay, a few other issues became apparent as I worked on that. So I added tests for them and fixed them also. I can confirm that a lot of the older implementation was failing in many of the tests, because I reverted to the older implementation locally and checked against the same tests (which run in parallel with swf). So I do know that this represents progress. But what I cannot know is if there are other things that do not work after these changes outside of the current test coverage (which is why it is essential to enhance that coverage over time). However I also have no desire to cause many sudden changes needed in your project that we could let you manage more gradually if this is causing a problem, because I have a feeling that you and Harbs are the main users of XML at the moment. If you are still encountering problems after my latest changes then we could revert the XML project to how it was before all my recent changes and I could move everything to a branch. I haven't done that to date simply because in terms of what I can see in the tests so far, I can only consider it to be progress in terms of getting the implementation closer (than it was before) to the original as3 XML/XMList. But as I said... that is only as good as the test coverage. Anyhow, let me know what you think... I have fingers crossed that the latest changes should address things for you. Greg On Mon, Jun 24, 2019 at 12:35 AM Greg Dove wrote: > Hi Yishay, thanks for the new details. That's another bug. I have a local > fix for that now, and new tests to cover this and more variations of the > document level parsing. > It's late for me now, so I will check everything thoroughly and push the > fix in my morning. > > > > On Sun, Jun 23, 2019 at 9:57 PM Yishay Weiss > wrote: > >> Hi Greg, >> >> I’m still having issues with xml that were not there before. Can you see >> why this [1] app, where my.xml is [2] is giving me an exception [3]? >> >> >> >> [1] https://paste.apache.org/ld1L >> [2] https://paste.apache.org/d6VX >> [3] https://paste.apache.org/qpub >> >> Yishay >> >
Re: XML Problem with ignoreWhiteSpace=false
Hi Yishay, thanks for the new details. That's another bug. I have a local fix for that now, and new tests to cover this and more variations of the document level parsing. It's late for me now, so I will check everything thoroughly and push the fix in my morning. On Sun, Jun 23, 2019 at 9:57 PM Yishay Weiss wrote: > Hi Greg, > > I’m still having issues with xml that were not there before. Can you see > why this [1] app, where my.xml is [2] is giving me an exception [3]? > > > > [1] https://paste.apache.org/ld1L > [2] https://paste.apache.org/d6VX > [3] https://paste.apache.org/qpub > > Yishay >
XML Problem with ignoreWhiteSpace=false
Hi Greg, I’m still having issues with xml that were not there before. Can you see why this [1] app, where my.xml is [2] is giving me an exception [3]? [1] https://paste.apache.org/ld1L [2] https://paste.apache.org/d6VX [3] https://paste.apache.org/qpub Yishay
