Yes, I follow the commit process exactly (even running rat multiple
times). I think github gets confused with the rebasing from develop in the
commit process -- the pull requests where there aren't any chronological
changes that occur later that have already been merged typically get closed.
On T
To close a github pr, you have to have a commit that makes it to master
with something like "closes #45", where "#45" is the PR number. (Or I think
if you merge the exact commit hash from the head of the PR branch that'll
work).
https://help.github.com/articles/closing-issues-via-commit-messages/
Puja are you still using the "Commit Process for Committers" instructions
at [1]? Can you take a look at these instructions and figure out why they
are not closing the pull requests?
It would be worth it to see how spark is pulling stuff in. Their PRs look
nice: https://github.com/apache/spark/p
Thanks for taking a look at this Josh. I submitted a PR at
https://github.com/apache/incubator-rya/pull/69
On Sat, Aug 13, 2016 at 3:21 PM Josh Elser wrote:
> I'd concur with your assessment, Aaron. I would think that you should
> just remove that configuration from the maven-release-plugin. On
Go ahead and pull in changes. That branch is in a bad state and will be
deleted. Caleb and I will resume the release today.
On Thu, Aug 18, 2016 at 9:00 AM Puja Valiyil wrote:
> Hey Aaron and Caleb,
> I saw that there was a release branch. Should we hold off on merging
> things into develop w
Hey Aaron and Caleb,
I saw that there was a release branch. Should we hold off on merging
things into develop while you are working on the release? I had put off
merging pull requests while you guys were actively working so that it
wouldn't be adding work, but there are a lot of requests at this
