[jira] [Commented] (S2GRAPH-248) HTTP interface integration.

2018-11-22 Thread Daewon Jeong (JIRA)


[ 
https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696384#comment-16696384
 ] 

Daewon Jeong commented on S2GRAPH-248:
--

[~steamshon] Thank you for your feedback.

I will quickly build a basic project that will be the base for HTTP integration 
task.

> HTTP interface integration.
> ---
>
> Key: S2GRAPH-248
> URL: https://issues.apache.org/jira/browse/S2GRAPH-248
> Project: S2Graph
>  Issue Type: Task
>  Components: s2core, s2rest_netty, s2rest_play
>Reporter: Daewon Jeong
>Priority: Minor
>
> The current HTTP interface in S2Graph has the following problems.
>  known issues:
>    1. The `s2rest_netty` project is experimental and supports only `graph 
> traverse` API.
>    2. `s2rest_play` based on Play! Framework. 
>       - Play! Framework is full stack framework, so it has a lot of 
> dependencies that s2graph does not need. 
>       - There is also a conflict with byte buddy for patching asynchbase.
>    3. `GraphQL` is still in the experimental phase and does not yet provide 
> all the functionality.
> The discussion below is written on the link below.
> discussions: 
> [https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E]
>  
> Based on this issue, the following work should be done.
>  * Create an HTTP interface project(without play!)
>  * Remove s2rest_netty
>  * API documentation (GraphQL, Rest)
>  * GraphQL and Rest HTTP interface integration



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (S2GRAPH-243) Limit bug on 'graph/getEdges'

2018-11-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/S2GRAPH-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696310#comment-16696310
 ] 

ASF GitHub Bot commented on S2GRAPH-243:


Github user asfgit closed the pull request at:

https://github.com/apache/incubator-s2graph/pull/187


> Limit bug on 'graph/getEdges' 
> --
>
> Key: S2GRAPH-243
> URL: https://issues.apache.org/jira/browse/S2GRAPH-243
> Project: S2Graph
>  Issue Type: Bug
>  Components: s2core
>Affects Versions: 0.2.0
>Reporter: Daewon Jeong
>Priority: Minor
>
> A limit bug was reported in the getEdges API in the following link.
> link: 
> [https://lists.apache.org/thread.html/57ca77109bf321fcff7be616b5e07eb320f5dfcd81e700ba77e6ffd2@%3Cusers.s2graph.apache.org%3E]
> Bug Description:
> Using version 0.2.0
>  Enter data as example.sh
> Three "friends" in "Elmo" (offset: 0, limit: 3) => Only two results are 
> displayed.
>  
> If offset is 0, 2 results are returned.
> [image 
> link|https://user-images.githubusercontent.com/1182522/47141766-5e456d80-d2fc-11e8-8324-69493e82baa5.png]
>  
> If offset is 1, 3 results are returned.
> [image 
> link|https://user-images.githubusercontent.com/1182522/47141759-5be31380-d2fc-11e8-9b73-1d51ae0dbc14.png]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (S2GRAPH-249) Provide Vertex Mutate and Query APIs to Integrated HTTP Interface.

2018-11-22 Thread DOYUNG YOON (JIRA)
DOYUNG YOON created S2GRAPH-249:
---

 Summary: Provide Vertex Mutate and Query APIs to Integrated HTTP 
Interface. 
 Key: S2GRAPH-249
 URL: https://issues.apache.org/jira/browse/S2GRAPH-249
 Project: S2Graph
  Issue Type: Sub-task
  Components: s2core, s2rest_netty, s2rest_play
Reporter: DOYUNG YOON
Assignee: DOYUNG YOON


Here is the full list of vertex APIs on HTTP interface.

* POST/graphs/getVertices
* POST/graphs/getVertices
* POST/graphs/vertices/insert
* POST/graphs/vertices/delete
* POST/graphs/vertices/deleteAll
* POST/graphs/vertices/insert/:serviceName/:columnName
* POST/graphs/vertices/delete/:serviceName/:columnName
* POST/graphs/vertices/deleteAll/:serviceName/:columnName
* POST/graphs/vertices/insertWithWait
* POST/graphs/vertices/deleteWithWait

Also will include documentation on each APIs while working on this together.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (S2GRAPH-248) HTTP interface integration.

2018-11-22 Thread DOYUNG YOON (JIRA)


[ 
https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696304#comment-16696304
 ] 

DOYUNG YOON commented on S2GRAPH-248:
-

[~daewon] Many thanks for opening up this issue.

In summary, I think the categories for APIs are following.

# Vertex Mutate API
# Vertex Query API
# Edge Mutate API
# Edge Query API
# Admin API
# GraphQL API

I volunteer to work on Vertex Mutate API + Vertex Query API if no one mind.

> HTTP interface integration.
> ---
>
> Key: S2GRAPH-248
> URL: https://issues.apache.org/jira/browse/S2GRAPH-248
> Project: S2Graph
>  Issue Type: Task
>  Components: s2core, s2rest_netty, s2rest_play
>Reporter: Daewon Jeong
>Priority: Minor
>
> The current HTTP interface in S2Graph has the following problems.
>  known issues:
>    1. The `s2rest_netty` project is experimental and supports only `graph 
> traverse` API.
>    2. `s2rest_play` based on Play! Framework. 
>       - Play! Framework is full stack framework, so it has a lot of 
> dependencies that s2graph does not need. 
>       - There is also a conflict with byte buddy for patching asynchbase.
>    3. `GraphQL` is still in the experimental phase and does not yet provide 
> all the functionality.
> The discussion below is written on the link below.
> discussions: 
> [https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E]
>  
> Based on this issue, the following work should be done.
>  * Create an HTTP interface project(without play!)
>  * Remove s2rest_netty
>  * API documentation (GraphQL, Rest)
>  * GraphQL and Rest HTTP interface integration



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-22 Thread DO YUNG YOON
Thanks, daewon. I will follow this on JIRA.

On Thu, Nov 22, 2018 at 3:33 PM daewon  wrote:

> I created an issue  for
> this discussion.
> I think we will make the decisions in JIRA and start working on them.
>
>
> 2018년 11월 22일 (목) 오후 2:00, DO YUNG YOON 님이 작성:
>
> > Thanks for getting involved in the discussion Woonsan.
> >
> > @deawon, can you please create the Jira issue for this?
> >
> > By the way, I merged S2GRAPH-246(integration of documents into S2Graph
> > project) into master yesterday, so I think we are ready to work on this.
> > What if we move the APIs one by one and document them together?
> >
> > Since we have to go through the full list of APIs, I think it is a good
> > time to document them also.
> >
> >
> >
> >
> >
> > On Thu, Nov 22, 2018 at 6:10 AM Woonsan Ko  wrote:
> >
> > > Now I see why it was broken. ;-)
> > > I recently re-subscribed the lists and started reading past messages to
> > > understand the context.
> > > I'm very looking forward to seeing the progress!
> > >
> > > Cheers,
> > >
> > > Woonsan
> > >
> > > On 2018/11/07 07:51:20, daewon  wrote:
> > > > I've looked at the features that are available to remove the Play!
> > > > Framework.
> > > >
> > > > I have written my comments for each function groups.
> > > >
> > > > - The Admin and Create APIs have yet to integrate many functions into
> > the
> > > > Play! controller code, so code separation must be preceded in order
> to
> > > move
> > > > functionality.
> > > > - The API with the `withWait` postfix of the Edge/Vertex creation API
> > is
> > > an
> > > > API that tells the client whether the request is applied correctly.
> > > >This is a duplicate API that exists for backward compatibility.
> > > > - Management routes are suggested to unify API routes with prefixes
> > such
> > > as
> > > > `/admin/?` or `/managment/?`.
> > > > - Server health_check or Counter related features are not available
> > > > anymore, so I suggest you exclude them.
> > > >
> > > > ## Edge creation
> > > >   ### List of APIs to leave
> > > > POST/graphs/edges/insert
> > > >
> > > > POST/graphs/edges/insertBulk
> > > > POST/graphs/edges/delete
> > > >
> > > > POST/graphs/edges/deleteAll
> > > >
> > > > POST/graphs/edges/deleteAllWithOutWait
> > > >
> > > > POST/graphs/edges/update
> > > >
> > > > POST/graphs/edges/increment
> > > > POST/graphs/edges/incrementCount
> > > > POST/graphs/edges/bulk
> > > >
> > > >   ### List of APIs that should be removed
> > > > POST/graphs/edges/deleteWithWait
> > > >
> > > > POST/graphs/edges/updateWithWait
> > > >
> > > > POST/graphs/edges/incrementWithWait
> > > >
> > > > POST/graphs/edges/bulkWithWait
> > > >
> > > > POST/graphs/edges/insertWithWait
> > > >
> > > >
> > > > ## Edge query
> > > >
> > > >   ### List of APIs to leave
> > > > POST/graphs/getEdges
> > > >
> > > > POST/graphs/checkEdges
> > > >
> > > >
> > > >   ### List of APIs that should be removed
> > > > POST/graphs/getEdgesGrouped
> > > >
> > > > POST/graphs/getEdgesGroupedExcluded
> > > >
> > > > POST/graphs/getEdgesGroupedExcludedFormatted
> > > >
> > > > GET /graphs/getEdge/:srcId/:tgtId/:labelName/:direction
> > > >
> > > > POST/graphs/getEdgesExcluded
> > > >
> > > > POST/graphs/getEdgesExcluded/grouped
> > > >
> > > > POST/graphs/getEdges/grouped
> > > >
> > > >
> > > >
> > > > ## Vertex related
> > > >   ### List of APIs to leave
> > > > POST/graphs/getVertices
> > > > POST/graphs/vertices/insert
> > > > POST/graphs/vertices/delete
> > > > POST/graphs/vertices/deleteAll
> > > >
> > > >   ### List of APIs that should be removed
> > > > POST/graphs/vertices/insert/:serviceName/:columnName
> > > > POST/graphs/vertices/delete/:serviceName/:columnName
> > > >
> > > > POST/graphs/vertices/deleteAll/:serviceName/:columnName
> > > >
> > > > POST/graphs/vertices/insertWithWait
> > > >
> > > > POST/graphs/vertices/deleteWithWait
> > > >
> > > >
> > > > ## Vertex related
> > > >   ### List of APIs to leave
> > > > POST/graphs/createService
> > > >
> > > > GET /graphs/getService/:serviceName
> > > >
> > > > GET /graphs/getLabels/:serviceName
> > > >
> > > > POST/graphs/createLabel
> > > >
> > > > POST/graphs/addIndex
> > > >
> > > > GET /graphs/getLabel/:labelName
> > > >
> > > > PUT /graphs/deleteLabelReally/:labelName
> > > >
> > > > POST/graphs/addProp/:labelName
> > > >
> > > > POST/graphs/createServiceColumn
> > > >
> > > > PUT /graphs/deleteServiceColumn/:serviceName/:columnName
> > > >
> >