[ 
https://issues.apache.org/jira/browse/S2GRAPH-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155567#comment-15155567
 ] 

ASF GitHub Bot commented on S2GRAPH-38:
---------------------------------------

Github user emeth-kim commented on the pull request:

    https://github.com/apache/incubator-s2graph/pull/21#issuecomment-186571507
  
    +1


> Transform option gives wrong result since it transform degree edge too.
> -----------------------------------------------------------------------
>
>                 Key: S2GRAPH-38
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-38
>             Project: S2Graph
>          Issue Type: Bug
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>            Priority: Minor
>              Labels: easyfix
>
> There is no check if edge is {{degreeEdge}} or normal {{indexEdge}} when we 
> transform fetched edges using EdgeTransformer on QueryParam. 
> I think it is necessary to skip {{Graph.convertEdges}} when edge is 
> {{degreeEdge}}
> ex) there is no edges exist from srcVertex "a". if we query with "transform": 
> [["from"]], then now query result has one edge {"from": "a", "to": "a"}. this 
> is an edge that transformed from degreeEdge {"from": "a", "to": "0"}. 
> I think using special target vertex id "0" in degree edge yield this problem 
> and buggy, but for now transforming edge based on queryParam's 
> EdgeTransformer can skip transform if considering edge is {{degreeEdge}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to