Re: About s2ab query needs status code in result.

2016-04-27 Thread DO YUNG YOON
Appreciate it. On Fri, Apr 22, 2016 at 11:02 AM Hwansung Yu wrote: > I agree to throw explicit exception. > I created an issue. > > https://issues.apache.org/jira/browse/S2GRAPH-67 > > > > On Wed, Mar 23, 2016 at 2:49 PM, DO YUNG YOON wrote: > > > Hi Hwansung. > > > > Seems like it is validati

Re: About s2ab query needs status code in result.

2016-04-21 Thread Hwansung Yu
I agree to throw explicit exception. I created an issue. https://issues.apache.org/jira/browse/S2GRAPH-67 On Wed, Mar 23, 2016 at 2:49 PM, DO YUNG YOON wrote: > Hi Hwansung. > > Seems like it is validation check issue on 'experiment' routes on s2rest. > I think it is better to throw explicit

Re: About s2ab query needs status code in result.

2016-03-22 Thread DO YUNG YOON
Hi Hwansung. Seems like it is validation check issue on 'experiment' routes on s2rest. I think it is better to throw explicit exception(dedicated exception or BadQueryException which currently exist). Not only this cases, but also I think there is lots to work on regarding exception handling on co

About s2ab query needs status code in result.

2016-03-22 Thread Hwansung Yu
When I query with invalid json by s2ab, s2graph doesn't any notice for user. For example, curl -X POST -H "Content-Type: application/json" -d '{ "[[user_id]]": "A" "[[filter]]" : "(1,2,3)" }' 'localhost:9000/graphs/experiment/f1f2a18e-b83e-4828-9441-746e674907e2/test/test Above json body is i